Update Saccharis #51679
Update Saccharis #51679
Conversation
… sha256 hash, and added --single-version-externally-managed --record=record.txt args to setup.py install as per bioconda test suite
# Conflicts: # recipes/saccharis/meta.yaml
# Conflicts: # recipes/saccharis/meta.yaml
# Conflicts: # recipes/saccharis/meta.yaml
📝 Walkthrough📝 WalkthroughWalkthroughThe pull request introduces several modifications to the Possibly related PRs
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- recipes/saccharis/meta.yaml (2 hunks)
🔇 Additional comments (3)
recipes/saccharis/meta.yaml (3)
Line range hint
33-70: Verify database download functionality without python-wget.The removal of python-wget dependency appears to be related to the database download issues mentioned in the PR objectives. Please ensure:
- Alternative download mechanism is in place
- Database downloads work correctly in the new version
#!/bin/bash # Search for wget usage and potential replacements rg -l "wget" ast-grep --pattern 'import wget'The Python version requirement update to >=3.8 is a significant change.
#!/bin/bash # Check for Python 3.8 specific features that might be used rg -l "walrus|=:|:=|positional-only|f'{'"🧰 Tools
🪛 yamllint
[error] 1-1: syntax error: found character '%' that cannot start any token
(syntax)
17-19: Verify entry point resolution.The comment suggests previous entry point build errors. Please verify if these issues have been resolved in the new build.
#!/bin/bash # Search for any reported entry point issues in previous builds gh issue list -R saccharis/SACCHARIS_2 --search "entry point error" gh pr list -R saccharis/SACCHARIS_2 --search "entry point error"The build number increment to 3 aligns with the PR objectives.
3-3: Verify SHA256 hash.Please ensure the SHA256 hash matches the new tarball content.
| @@ -9,12 +9,12 @@ package: | |||
|
|
|||
| source: | |||
| # url: https://github.com/saccharis/SACCHARIS_2/releases/download/v{{ version }}/saccharis-{{ version }}.tar.gz | |||
| url: https://github.com/saccharis/SACCHARIS_2/releases/download/v2.0.1.dev21/saccharis-2.0.1.dev21_2.tar.gz | |||
| url: https://github.com/saccharis/SACCHARIS_2/releases/download/v2.0.1.dev21/saccharis-2.0.1.dev21_3.tar.gz | |||
There was a problem hiding this comment.
🛠️ Refactor suggestion
Use template variables in URL.
The URL hardcodes the version and build number. Consider using template variables for better maintainability:
- url: https://github.com/saccharis/SACCHARIS_2/releases/download/v2.0.1.dev21/saccharis-2.0.1.dev21_3.tar.gz
+ url: https://github.com/saccharis/SACCHARIS_2/releases/download/v{{ version }}/saccharis-{{ version }}_3.tar.gzCommittable suggestion was skipped due to low confidence.
|
@BiocondaBot please add label |
Update 2.0.1.dev21 to build 3 to fix intermittent database download issue.
Please read the guidelines for Bioconda recipes before opening a pull request (PR).
General instructions
@BiocondaBot please add labelcommand.@bioconda/corein a comment.Instructions for avoiding API, ABI, and CLI breakage issues
Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify
run_exports(see here for the rationale and comprehensive explanation).Add a
run_exportssection like this:with
...being one of:{{ pin_subpackage("myrecipe", max_pin="x") }}{{ pin_subpackage("myrecipe", max_pin="x.x") }}{{ pin_subpackage("myrecipe", max_pin="x.x") }}(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin="x.x.x") }}(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin=None) }}while replacing
"myrecipe"with eithernameif aname|lowervariable is defined in your recipe or with the lowercase name of the package in quotes.Bot commands for PR management
Please use the following BiocondaBot commands:
Everyone has access to the following BiocondaBot commands, which can be given in a comment:
@BiocondaBot please update@BiocondaBot please add labelplease review & mergelabel.@BiocondaBot please fetch artifactsYou can use this to test packages locally.
Note that the
@BiocondaBot please mergecommand is now depreciated. Please just squash and merge instead.Also, the bot watches for comments from non-members that include
@bioconda/<team>and will automatically re-post them to notify the addressed<team>.