Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pybbi: add linux-aarch64 build #51516

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Conversation

martin-g
Copy link
Contributor

Describe your pull request here


Please read the guidelines for Bioconda recipes before opening a pull request (PR).

General instructions

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.

Instructions for avoiding API, ABI, and CLI breakage issues

Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify run_exports (see here for the rationale and comprehensive explanation).
Add a run_exports section like this:

build:
  run_exports:
    - ...

with ... being one of:

Case run_exports statement
semantic versioning {{ pin_subpackage("myrecipe", max_pin="x") }}
semantic versioning (0.x.x) {{ pin_subpackage("myrecipe", max_pin="x.x") }}
known breakage in minor versions {{ pin_subpackage("myrecipe", max_pin="x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
known breakage in patch versions {{ pin_subpackage("myrecipe", max_pin="x.x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
calendar versioning {{ pin_subpackage("myrecipe", max_pin=None) }}

while replacing "myrecipe" with either name if a name|lower variable is defined in your recipe or with the lowercase name of the package in quotes.

Bot commands for PR management

Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update Merge the master branch into a PR.
@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

Note that the @BiocondaBot please merge command is now depreciated. Please just squash and merge instead.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
@martin-g martin-g added the aarch64 Related to adding linux-aarch64 support label Oct 21, 2024
Copy link
Contributor

coderabbitai bot commented Oct 21, 2024

📝 Walkthrough

Walkthrough

The pull request involves updates to the meta.yaml file for the pybbi package. The version number remains at 0.4.1, but the build number has been incremented from 0 to 1. The sha256 hash is unchanged. A new directive in the build section specifies that builds should be skipped on macOS. The requirements section remains unchanged. In the about section, the summary line has been reformatted for consistency. An extra section has been added, introducing additional-platforms with the entry linux-aarch64. The recipe-maintainers entry has not been modified. Overall, the changes focus on the build number increment, the addition of platform support for linux-aarch64, and minor formatting adjustments.

Possibly related PRs

Suggested labels

please review & merge

Suggested reviewers

  • rpetit3

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 50fd1c1 and 4c9da93.

📒 Files selected for processing (1)
  • recipes/pybbi/meta.yaml (2 hunks)
🧰 Additional context used
🔇 Additional comments (4)
recipes/pybbi/meta.yaml (4)

Line range hint 46-46: LGTM: Improved formatting.

The summary line has been reformatted for better consistency. This change is purely cosmetic and improves the overall readability of the file.


Line range hint 1-53: Summary of changes and recommendations

The changes to the meta.yaml file for the pybbi package are generally good and align with the PR objectives. Here's a summary of the key points:

  1. The build number increment is correct.
  2. The addition of linux-aarch64 support is approved.
  3. The formatting improvements in the about section are appreciated.

However, please address the following points:

  1. Verify if skipping the build for macOS is intentional and doesn't negatively impact the package availability.
  2. Ensure that the CI configuration supports building for linux-aarch64 and that appropriate tests are in place for the new platform.

Once these points are addressed, the PR should be ready for final review and merge.


50-51: Verify CI configuration for linux-aarch64 support.

The addition of linux-aarch64 to the additional-platforms list is in line with the PR objective. This change is approved.

To ensure proper implementation, please verify the following:

  1. CI configuration supports building for linux-aarch64.
  2. Necessary tests are in place for the new platform.

Run the following script to check for any existing aarch64-related configuration:

#!/bin/bash
# Description: Check for existing aarch64 configuration

# Test: Search for aarch64-related content in CI configuration
rg -i 'aarch64|arm64' .github

13-14: Verify the macOS build skip directive.

The build number increment is correct. However, the new skip directive for macOS needs verification.

Please confirm if skipping the build for macOS is intentional and aligns with the package requirements. Run the following script to check if there are any macOS-specific dependencies or build instructions that might be affected:

✅ Verification successful

The macOS build skip directive appears unnecessary.

The skip: True # [osx] directive in recipes/pybbi/meta.yaml does not correspond to any macOS-specific dependencies or build instructions in the file. It is recommended to remove this directive unless there's a specific reason supported by other parts of the codebase.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for macOS-specific content in the recipe

# Test: Search for macOS-related content
rg -i 'macos|darwin|osx' recipes/pybbi

Length of output: 676


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@martin-g
Copy link
Contributor Author

@BiocondaBot please fetch artifacts

@BiocondaBot
Copy link
Collaborator

Package(s) built are ready for inspection:

Arch Package Zip File / Repodata CI Instructions
linux-64 pybbi-0.4.1-py310ha96f9f7_1.tar.bz2 LinuxArtifacts.zip Azure
showYou may also use conda to install after downloading and extracting the zip file. From the LinuxArtifacts directory: conda install -c ./packages <package name>
linux-64 pybbi-0.4.1-py311hd74b492_1.tar.bz2 LinuxArtifacts.zip Azure
showYou may also use conda to install after downloading and extracting the zip file. From the LinuxArtifacts directory: conda install -c ./packages <package name>
linux-64 pybbi-0.4.1-py312he52417b_1.tar.bz2 LinuxArtifacts.zip Azure
showYou may also use conda to install after downloading and extracting the zip file. From the LinuxArtifacts directory: conda install -c ./packages <package name>
linux-64 pybbi-0.4.1-py38h23c55b0_1.tar.bz2 LinuxArtifacts.zip Azure
showYou may also use conda to install after downloading and extracting the zip file. From the LinuxArtifacts directory: conda install -c ./packages <package name>
linux-64 pybbi-0.4.1-py39had97721_1.tar.bz2 LinuxArtifacts.zip Azure
showYou may also use conda to install after downloading and extracting the zip file. From the LinuxArtifacts directory: conda install -c ./packages <package name>
linux-aarch64 pybbi-0.4.1-py310hd315b43_1.tar.bz2 repodata.json CircleCI
showYou may also use conda to install:conda install -c https://output.circle-artifacts.com/output/job/bfdd772e-c898-45a2-ba42-9f66af0d52e5/artifacts/0/tmp/artifacts/packages <package name>
linux-aarch64 pybbi-0.4.1-py311hd89847b_1.tar.bz2 repodata.json CircleCI
showYou may also use conda to install:conda install -c https://output.circle-artifacts.com/output/job/bfdd772e-c898-45a2-ba42-9f66af0d52e5/artifacts/0/tmp/artifacts/packages <package name>
linux-aarch64 pybbi-0.4.1-py312h4a69d50_1.tar.bz2 repodata.json CircleCI
showYou may also use conda to install:conda install -c https://output.circle-artifacts.com/output/job/bfdd772e-c898-45a2-ba42-9f66af0d52e5/artifacts/0/tmp/artifacts/packages <package name>
linux-aarch64 pybbi-0.4.1-py38h2cdc35c_1.tar.bz2 repodata.json CircleCI
showYou may also use conda to install:conda install -c https://output.circle-artifacts.com/output/job/bfdd772e-c898-45a2-ba42-9f66af0d52e5/artifacts/0/tmp/artifacts/packages <package name>
linux-aarch64 pybbi-0.4.1-py39he49a98d_1.tar.bz2 repodata.json CircleCI
showYou may also use conda to install:conda install -c https://output.circle-artifacts.com/output/job/bfdd772e-c898-45a2-ba42-9f66af0d52e5/artifacts/0/tmp/artifacts/packages <package name>

Docker image(s) built:

Package Tag CI Install with docker
pybbi 0.4.1--py310ha96f9f7_1 Azure
showImages for Azure are in the LinuxArtifacts zip file above.gzip -dc LinuxArtifacts/images/pybbi:0.4.1--py310ha96f9f7_1.tar.gz | docker load
pybbi 0.4.1--py311hd74b492_1 Azure
showImages for Azure are in the LinuxArtifacts zip file above.gzip -dc LinuxArtifacts/images/pybbi:0.4.1--py311hd74b492_1.tar.gz | docker load
pybbi 0.4.1--py312he52417b_1 Azure
showImages for Azure are in the LinuxArtifacts zip file above.gzip -dc LinuxArtifacts/images/pybbi:0.4.1--py312he52417b_1.tar.gz | docker load
pybbi 0.4.1--py38h23c55b0_1 Azure
showImages for Azure are in the LinuxArtifacts zip file above.gzip -dc LinuxArtifacts/images/pybbi:0.4.1--py38h23c55b0_1.tar.gz | docker load
pybbi 0.4.1--py39had97721_1 Azure
showImages for Azure are in the LinuxArtifacts zip file above.gzip -dc LinuxArtifacts/images/pybbi:0.4.1--py39had97721_1.tar.gz | docker load

@martin-g
Copy link
Contributor Author

mgrigorov in 🌐 euler-arm-22 in /tmp/pybbi via 🅒 test123 took 2s 
❯ tar xvf pybbi-0.4.1-py310hd315b43_1.tar.bz2                                                                                                                                                              (test123) 
info/test/run_test.py
info/run_exports.json
info/recipe/build.sh
info/hash_input.json
info/has_prefix
info/index.json
info/files
info/recipe/meta.yaml.template
info/recipe/meta.yaml
info/paths.json
info/recipe/conda_build_config.yaml
info/about.json
info/git
lib/python3.10/site-packages/bbi/cbbi.pxd
lib/python3.10/site-packages/bbi/cbbi.c
lib/python3.10/site-packages/bbi/__init__.py
lib/python3.10/site-packages/bbi/_bbi.py
lib/python3.10/site-packages/pybbi-0.4.1.dist-info/INSTALLER
lib/python3.10/site-packages/pybbi-0.4.1.dist-info/WHEEL
lib/python3.10/site-packages/pybbi-0.4.1.dist-info/LICENSE
lib/python3.10/site-packages/pybbi-0.4.1.dist-info/RECORD
lib/python3.10/site-packages/pybbi-0.4.1.dist-info/METADATA
lib/python3.10/site-packages/pybbi-0.4.1.dist-info/REQUESTED
lib/python3.10/site-packages/bbi/cbbi.pyx
lib/python3.10/site-packages/bbi/__pycache__/__init__.cpython-310.pyc
lib/python3.10/site-packages/bbi/__pycache__/_bbi.cpython-310.pyc
lib/python3.10/site-packages/bbi/cbbi.cpython-310-aarch64-linux-gnu.so
lib/python3.10/site-packages/pybbi-0.4.1.dist-info/direct_url.json
lib/python3.10/site-packages/pybbi-0.4.1.dist-info/top_level.txt

mgrigorov in 🌐 euler-arm-22 in /tmp/pybbi via 🅒 test123 
❯ file lib/python3.10/site-packages/bbi/cbbi.cpython-310-aarch64-linux-gnu.so                                                                                                                              (test123) 
lib/python3.10/site-packages/bbi/cbbi.cpython-310-aarch64-linux-gnu.so: ELF 64-bit LSB shared object, ARM aarch64, version 1 (SYSV), dynamically linked, with debug_info, not stripped

LGTM!

@martin-g
Copy link
Contributor Author

@BiocondaBot please add label

@BiocondaBot BiocondaBot added the please review & merge set to ask for merge label Oct 21, 2024
@mencian mencian merged commit f1eaec7 into bioconda:master Oct 21, 2024
7 checks passed
@martin-g martin-g deleted the aarch64-pybbi branch October 21, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aarch64 Related to adding linux-aarch64 support please review & merge set to ask for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants