Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d4binding: add aarch64/arm64 builds #51598

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Conversation

martin-g
Copy link
Contributor

Describe your pull request here


Please read the guidelines for Bioconda recipes before opening a pull request (PR).

General instructions

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.

Instructions for avoiding API, ABI, and CLI breakage issues

Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify run_exports (see here for the rationale and comprehensive explanation).
Add a run_exports section like this:

build:
  run_exports:
    - ...

with ... being one of:

Case run_exports statement
semantic versioning {{ pin_subpackage("myrecipe", max_pin="x") }}
semantic versioning (0.x.x) {{ pin_subpackage("myrecipe", max_pin="x.x") }}
known breakage in minor versions {{ pin_subpackage("myrecipe", max_pin="x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
known breakage in patch versions {{ pin_subpackage("myrecipe", max_pin="x.x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
calendar versioning {{ pin_subpackage("myrecipe", max_pin=None) }}

while replacing "myrecipe" with either name if a name|lower variable is defined in your recipe or with the lowercase name of the package in quotes.

Bot commands for PR management

Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update Merge the master branch into a PR.
@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

Note that the @BiocondaBot please merge command is now depreciated. Please just squash and merge instead.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

@martin-g martin-g added aarch64 Related to adding linux-aarch64 support osx-arm64 Related to adding osx-arm64 support labels Oct 23, 2024
Copy link
Contributor

coderabbitai bot commented Oct 23, 2024

📝 Walkthrough
📝 Walkthrough

Walkthrough

The pull request introduces changes to the build.sh and meta.yaml files within the d4binding package. In build.sh, the script has been adjusted to modify the export of environment variables and execution settings. The shebang line is simplified to #!/bin/bash, and the set -x command is updated to set -xe. The environment variable CARGO_NET_GIT_FETCH_WITH_CLI has been removed, while CARGO_HOME is now set to ${BUILD_PREFIX}/.cargo. The script continues to copy build_htslib.sh and execute install.sh. In meta.yaml, the build number has been incremented from 0 to 1, and the extra section has been expanded to include support for linux-aarch64.

Possibly related PRs

  • update d4tools and d4binding #48077: This PR updates the d4binding package, which includes modifications to the build.sh script that are relevant to the changes made in the main PR regarding environment variable exports.
  • gxf2bed: add aarch64/arm64 builds #51120: This PR adds support for linux-aarch64 in the gxf2bed package, which is relevant as it also involves modifications to the meta.yaml file similar to those in the main PR.
  • pydustmasker: add aarch64 build #51158: This PR introduces linux-aarch64 builds for the pydustmasker package, which aligns with the changes in the main PR regarding platform support in the meta.yaml.
  • mashmap: add aarch64 build #51161: This PR adds linux-aarch64 builds for the mashmap package, which is relevant due to the similar updates in platform support in the main PR.
  • r-cobrar: add aarch64/arm64 builds #51203: This PR adds linux-aarch64 builds for the r-cobrar package, which is relevant as it involves similar modifications to the meta.yaml file.
  • Rebuild breseq #51221: This PR updates the breseq package, which may relate to the changes in the main PR regarding build configurations.
  • Add FMSI #51277: This PR introduces a new package fmsi, which includes a meta.yaml file that may relate to the changes in the main PR regarding package configurations.
  • Update Earl Grey build.sh #51324: This PR updates the earlgrey package, which includes changes to the build.sh script that may relate to the modifications in the main PR.
  • vcf-validator: add linux-aarch64 build #51425: This PR adds linux-aarch64 builds for the vcf-validator package, which is relevant due to the similar updates in platform support in the main PR.
  • genbank: add aarch64/arm64 builds #51448: This PR adds linux-aarch64 builds for the genbank package, which is relevant as it involves similar modifications to the meta.yaml file.
  • Update diamond recipe #51515: This PR updates the diamond recipe, which may relate to the changes in the main PR regarding build configurations.
  • pybbi: add linux-aarch64 build #51516: This PR adds linux-aarch64 builds for the pybbi package, which is relevant due to the similar updates in platform support in the main PR.
  • centrifuge-core: add linux-aarch64 build #51517: This PR adds linux-aarch64 builds for the centrifuge-core package, which is relevant as it involves similar modifications to the meta.yaml file.
  • genodsp: add linux-aarch64 build #51597: This PR adds linux-aarch64 builds for the genodsp package, which is relevant due to the similar updates in platform support in the main PR.

Suggested labels

please review & merge

Suggested reviewers

  • mencian

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between e9b4f27 and cc446ce.

📒 Files selected for processing (1)
  • recipes/d4binding/meta.yaml (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • recipes/d4binding/meta.yaml

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
@martin-g
Copy link
Contributor Author

@BiocondaBot please add label

@BiocondaBot BiocondaBot added the please review & merge set to ask for merge label Oct 25, 2024
@mencian mencian merged commit 0c0bc88 into bioconda:master Oct 28, 2024
7 checks passed
@martin-g martin-g deleted the aarch64-d4binding branch October 28, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aarch64 Related to adding linux-aarch64 support osx-arm64 Related to adding osx-arm64 support please review & merge set to ask for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants