phables: add aarch64/arm64 builds #51124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
martin-g
added
aarch64
📝 WalkthroughWalkthroughThe pull request modifies the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
@BiocondaBot please fetch artifacts |
|
Package(s) built are ready for inspection:
Docker image(s) built:
|
There are no arch specific binaries! |
|
@BiocondaBot please add label |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
recipes/phables/meta.yaml (1)
Line range hint
13-19: LGTM: Build section changes are appropriate.The build number increment and
noarch: falsesetting are correct for this update. The addition ofrun_exportsis a good practice for maintaining compatibility with dependent packages.Consider adding a comment explaining why
noarch: falseis set, as it's not immediately obvious without the context of the PR objectives.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- recipes/phables/meta.yaml (2 hunks)
🔇 Additional comments (3)
recipes/phables/meta.yaml (3)
Line range hint
2-11: LGTM: Version update and source changes look good.The version has been correctly updated to 1.4.1, and the source URL has been adjusted accordingly. The inclusion of a new SHA256 checksum is a good practice for ensuring the integrity of the downloaded source.
Line range hint
1-57: Overall, the changes look good and achieve the PR objectives.The updates to version, build number, and additional platforms are consistent with the goal of adding aarch64/arm64 builds for the phables package. The
run_exportsaddition is a good practice for maintaining compatibility.A few minor suggestions:
- Consider adding a comment explaining the
noarch: falsesetting.- Verify the successful creation of build artifacts for the new platforms.
These changes should be ready for merging once the suggested verifications are complete.
51-53: LGTM: Additional platforms added as intended.The addition of
linux-aarch64andosx-arm64to theadditional-platformslist is consistent with the PR objective of adding aarch64/arm64 builds.To ensure these changes are reflected in the build process, let's verify the build artifacts:
This script will search for mentions of the new platforms in the PR comments, which should include information about the build artifacts if they were successfully created.
✅ Verification successful
Verification Successful: Builds for added platforms are present.
The build artifacts for
linux-aarch64andosx-arm64have been successfully generated, confirming the changes.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that builds for the new platforms exist # Test: Check if build artifacts for the new platforms are present gh pr view 51124 --json comments -q '.comments[].body' | grep -E 'linux-aarch64|osx-arm64'Length of output: 1356
This was referenced Oct 4, 2024
This was referenced Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your pull request here
Please read the guidelines for Bioconda recipes before opening a pull request (PR).
General instructions
@BiocondaBot please add labelcommand.@bioconda/corein a comment.Instructions for avoiding API, ABI, and CLI breakage issues
Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify
run_exports(see here for the rationale and comprehensive explanation).Add a
run_exportssection like this:with
...being one of:{{ pin_subpackage("myrecipe", max_pin="x") }}{{ pin_subpackage("myrecipe", max_pin="x.x") }}{{ pin_subpackage("myrecipe", max_pin="x.x") }}(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin="x.x.x") }}(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin=None) }}while replacing
"myrecipe"with eithernameif aname|lowervariable is defined in your recipe or with the lowercase name of the package in quotes.Bot commands for PR management
Please use the following BiocondaBot commands:
Everyone has access to the following BiocondaBot commands, which can be given in a comment:
@BiocondaBot please update@BiocondaBot please add labelplease review & mergelabel.@BiocondaBot please fetch artifactsYou can use this to test packages locally.
Note that the
@BiocondaBot please mergecommand is now depreciated. Please just squash and merge instead.Also, the bot watches for comments from non-members that include
@bioconda/<team>and will automatically re-post them to notify the addressed<team>.Summary by CodeRabbit
dev_urlentry for consistency.