Revert back to medium VM for Linux aarch64. #51241
Conversation
Needed `large` for bioconda#51214 Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
📝 WalkthroughWalkthroughThe pull request modifies the CircleCI configuration file Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
.circleci/config.yml (1)
Line range hint
180-189: Approved: Added check for [ci run] marker in bulk_build jobThe addition of a check for the "[ci run]" marker in the commit message is a good improvement. This allows for more granular control over when the bulk build job runs, potentially saving resources by preventing unnecessary builds.
Consider updating the project documentation to explain:
- When and how to use the "[ci run]" marker in commit messages.
- The implications of including or omitting this marker for the bulk build process.
This will ensure that all contributors are aware of this new feature and can use it effectively.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- .circleci/config.yml (1 hunks)
🧰 Additional context used
🔇 Additional comments (4)
.circleci/config.yml (4)
Line range hint
24-30: Approved: Updated git range for checking additional platformsThe change to use "origin/master...HEAD" as the git range for checking additional platforms is an improvement. This range ensures that all changes from the master branch up to the current commit are considered, potentially catching more relevant changes that require building and testing.
Line range hint
117-123: Approved: Updated git range and build command for merged PRsThe changes in the build_and_upload job are appropriate:
- The git range "${CIRCLE_SHA1}~1 ${CIRCLE_SHA1}" focuses on the specific commit being built, which is suitable for this job.
- The use of "bioconda-utils handle-merged-pr" instead of "bioconda-utils build" suggests a more specialized handling of merged pull requests.
Could you provide more information about the "handle-merged-pr" command? Specifically:
- What additional steps does it perform compared to the regular "build" command?
- Are there any new dependencies or configuration changes required for this command?
To verify the behavior of the new command, you could run:
#!/bin/bash # Check the help output of the handle-merged-pr command bioconda-utils handle-merged-pr --help # Compare the output of the old and new commands bioconda-utils build --help bioconda-utils handle-merged-pr --help | diff - <(bioconda-utils build --help)Also applies to: 160-163
12-12: Approved: Revert to medium VM for Linux aarch64This change aligns with the PR objective of reverting back to a medium VM for Linux aarch64.
To ensure this change doesn't negatively impact build times, please monitor the performance of Linux aarch64 builds after this change is implemented. Consider running the following command to compare build times before and after the change:
Line range hint
240-246: Approved: Added build and push for leftover packages in nightly_build jobThe addition of a command to build and push leftover packages in the nightly_build job is a good improvement. This ensures that any packages not built during regular jobs are handled, improving the overall reliability of the build process.
To ensure this addition doesn't significantly impact the duration of nightly builds, please monitor the nightly build times after this change is implemented. You can use the following command to track nightly build durations:
If you notice a significant increase in build times, consider optimizing the process or adjusting the scheduling of the nightly builds.
Needed
largefor #51214Describe your pull request here
Please read the guidelines for Bioconda recipes before opening a pull request (PR).
General instructions
@BiocondaBot please add labelcommand.@bioconda/corein a comment.Instructions for avoiding API, ABI, and CLI breakage issues
Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify
run_exports(see here for the rationale and comprehensive explanation).Add a
run_exportssection like this:with
...being one of:{{ pin_subpackage("myrecipe", max_pin="x") }}{{ pin_subpackage("myrecipe", max_pin="x.x") }}{{ pin_subpackage("myrecipe", max_pin="x.x") }}(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin="x.x.x") }}(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin=None) }}while replacing
"myrecipe"with eithernameif aname|lowervariable is defined in your recipe or with the lowercase name of the package in quotes.Bot commands for PR management
Please use the following BiocondaBot commands:
Everyone has access to the following BiocondaBot commands, which can be given in a comment:
@BiocondaBot please update@BiocondaBot please add labelplease review & mergelabel.@BiocondaBot please fetch artifactsYou can use this to test packages locally.
Note that the
@BiocondaBot please mergecommand is now depreciated. Please just squash and merge instead.Also, the bot watches for comments from non-members that include
@bioconda/<team>and will automatically re-post them to notify the addressed<team>.