-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pgscatalog.core to 0.3.1 #51201
Conversation
📝 Walkthrough📝 WalkthroughWalkthroughThe pull request includes updates to the Possibly related PRs
Suggested labels
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
recipes/pgscatalog.core/meta.yaml (1)
Line range hint
18-18
: Consider resetting the build number for the new version.The update from version 0.2.2 to 0.3.1, along with the addition of pydantic as a dependency, represents a significant change in the package. These changes may impact users, particularly those who might need to adapt their code to work with pydantic.
Given these substantial changes, it's recommended to reset the build number to 0 for this new version. This helps to clearly differentiate it from previous builds and follows the common practice for version updates in conda recipes.
Please consider updating the build number:
- number: 0 + number: 0 # Reset to 0 for new version🧰 Tools
🪛 yamllint
[error] 1-1: syntax error: found character '%' that cannot start any token
(syntax)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- recipes/pgscatalog.core/meta.yaml (2 hunks)
🧰 Additional context used
🔇 Additional comments (3)
recipes/pgscatalog.core/meta.yaml (3)
2-2
: Version update looks good.The version has been correctly updated from 0.2.2 to 0.3.1, which aligns with the PR objective.
10-10
: SHA256 checksum updated.The SHA256 checksum has been updated, which is consistent with the version change. However, it's important to verify that this checksum is correct for the new version of the package.
To verify the SHA256 checksum, you can run the following command:
Compare the output with the SHA256 value in the meta.yaml file.
36-36
: New dependency added: pydantic.The addition of pydantic as a dependency is in line with the PR objectives. The version constraint (>=2.9.0,<3.0.0) is appropriate, allowing for minor updates while preventing major version changes.
To ensure this change is fully integrated:
- Check if the package's code has been updated to use pydantic where appropriate.
- Verify that any documentation or README files have been updated to reflect this new dependency.
- Consider running the package's test suite to ensure compatibility with pydantic.
You can use the following command to check for pydantic usage in the package code:
This will help verify that the new dependency is being utilized in the codebase.
No artifacts found on the most recent builds. Either the builds failed, the artifacts have been removed due to age, or the recipe was blacklisted/skipped. |
@BiocondaBot please add label |
@BiocondaBot please fetch artifacts |
Package(s) built are ready for inspection:
Docker image(s) built:
|
Bump pgscatalog.core from
0.2.2
->0.3.1
0.3.x
added pydantic as a dependency, which broke autobumpBot commands for PR management
Please use the following BiocondaBot commands:
Everyone has access to the following BiocondaBot commands, which can be given in a comment:
@BiocondaBot please update
@BiocondaBot please add label
please review & merge
label.@BiocondaBot please fetch artifacts
You can use this to test packages locally.
Note that the
@BiocondaBot please merge
command is now depreciated. Please just squash and merge instead.Also, the bot watches for comments from non-members that include
@bioconda/<team>
and will automatically re-post them to notify the addressed<team>
.