Update pgscatalog-utils to 1.4.0 #51235
Conversation
📝 Walkthrough📝 WalkthroughWalkthroughThe changes in this pull request focus on the Possibly related PRs
Suggested labels
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
recipes/pgscatalog-utils/meta.yaml (1)
1-1: Minor: Consider removing the extra blank line at the beginning of the file.While it doesn't affect functionality, removing the extra blank line at the beginning of the file would improve adherence to YAML style guidelines.
🧰 Tools
🪛 yamllint
[warning] 1-1: too many blank lines
(1 > 0) (empty-lines)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- recipes/pgscatalog-utils/meta.yaml (2 hunks)
🧰 Additional context used
🪛 yamllint
recipes/pgscatalog-utils/meta.yaml
[warning] 1-1: too many blank lines
(1 > 0) (empty-lines)
[error] 2-2: syntax error: found character '%' that cannot start any token
(syntax)
🔇 Additional comments (4)
recipes/pgscatalog-utils/meta.yaml (4)
3-3: Version update looks good.The package version has been correctly updated to 1.4.0, which aligns with the PR objective.
18-18: run_exports section is correctly updated.The
pin_subpackagemacro withmax_pin='x.x'ensures that downstream dependencies will use a compatible version of pgscatalog-utils, allowing for minor version updates. This is a good practice for maintaining compatibility.
27-29: Dependency versions have been updated appropriately.The minimum versions for pgscatalog.calc, pgscatalog.core, and pgscatalog.match have been increased while maintaining an upper bound at the next major version. This aligns with the PR objective and follows good versioning practices.
To ensure compatibility with the updated dependencies, please run the following script:
This script will perform a dry-run installation of each dependency to verify their availability and compatibility.
11-11: SHA256 checksum has been updated.The SHA256 checksum has been changed to match the new version of the package. This is necessary and expected.
To verify the correctness of the SHA256 checksum, you can run the following script:
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
recipes/pgscatalog-utils/meta.yaml (1)
1-2: Static analysis hints can be ignored.The static analysis tool reported two issues:
- Too many blank lines at the beginning of the file.
- Syntax error with '%' character on line 2.
These can be safely ignored:
- The blank line at the beginning doesn't affect functionality.
- The '%' character is part of the Jinja2 templating syntax used in Conda recipes, which is correct and expected in this context.
If desired, you could remove the blank line at the beginning of the file for consistency, but it's not necessary.
🧰 Tools
🪛 yamllint
[warning] 1-1: too many blank lines
(1 > 0) (empty-lines)
[error] 2-2: syntax error: found character '%' that cannot start any token
(syntax)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- recipes/pgscatalog-utils/meta.yaml (2 hunks)
🧰 Additional context used
🪛 yamllint
recipes/pgscatalog-utils/meta.yaml
[warning] 1-1: too many blank lines
(1 > 0) (empty-lines)
[error] 2-2: syntax error: found character '%' that cannot start any token
(syntax)
🔇 Additional comments (6)
recipes/pgscatalog-utils/meta.yaml (6)
3-3: Version update looks good.The version has been correctly updated to 1.4.0, which is consistent with the PR objectives.
16-16: Build number increment is correct.The build number has been properly incremented from 0 to 1. This is the correct practice when updating a package, as it allows for distinguishing between different builds of the same version.
37-37: Addition of 'pip check' and 'pip' requirement is beneficial.The inclusion of the 'pip check' command in the test section and the addition of 'pip' to the test requirements are positive changes. These additions will help ensure that all dependencies are properly satisfied during the package installation and testing process.
Also applies to: 45-46
Line range hint
1-58: Overall, the changes look good and are consistent with the PR objectives.Summary of changes:
- Version updated to 1.4.0
- SHA256 checksum updated
- Build number incremented
- Dependency versions updated
- 'pip check' command and 'pip' requirement added to test section
All changes follow good practices for updating a Conda recipe. The version update, dependency changes, and additional checks will help ensure the package is up-to-date and properly tested. Please make sure to verify the SHA256 checksum and run the suggested compatibility checks before merging.
27-29: Dependency version updates look appropriate.The version constraints for
pgscatalog.calc,pgscatalog.core, andpgscatalog.matchhave been updated to align with the new package version. The use of both lower and upper bounds is a good practice for maintaining compatibility.To ensure these updated dependencies are compatible with the new version of pgscatalog-utils, you can run the following command:
#!/bin/bash # Check if the updated dependencies are compatible with the new version pip install pgscatalog-utils==1.4.0 pgscatalog.calc==0.3.0 pgscatalog.core==0.3.1 pgscatalog.match==0.3.2 pip checkThis will attempt to install the package with the minimum versions of the updated dependencies and check for any compatibility issues.
11-11: SHA256 checksum has been updated.The SHA256 checksum has been changed, which is expected when updating the package version. However, it's important to ensure that this checksum is correct for the new version's source tarball.
To verify the SHA256 checksum, you can run the following command:
Compare the output with the checksum in the meta.yaml file to ensure they match.
Dependencies received a minor version bump, so need to manually update
Not sure how #51234 is passing CI/CD 🤔
pyproject.tomlspecifies different dependencies:to the
meta.yaml(which is fixed in this PR)TODO:
Bot commands for PR management
Please use the following BiocondaBot commands:
Everyone has access to the following BiocondaBot commands, which can be given in a comment:
@BiocondaBot please update@BiocondaBot please add labelplease review & mergelabel.@BiocondaBot please fetch artifactsYou can use this to test packages locally.
Note that the
@BiocondaBot please mergecommand is now depreciated. Please just squash and merge instead.Also, the bot watches for comments from non-members that include
@bioconda/<team>and will automatically re-post them to notify the addressed<team>.