Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make seqvar ACMG criterias upper case (#288) #317

Conversation

gromdimon
Copy link
Contributor

No description provided.

@gromdimon gromdimon self-assigned this Dec 20, 2023
@gromdimon gromdimon linked an issue Dec 20, 2023 that may be closed by this pull request
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (17eee05) 80.12% compared to head (54ea2f8) 88.21%.

❗ Current head 54ea2f8 differs from pull request most recent head 90f2c34. Consider uploading reports for the commit 90f2c34 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #317      +/-   ##
==========================================
+ Coverage   80.12%   88.21%   +8.08%     
==========================================
  Files         153       48     -105     
  Lines        5192      984    -4208     
  Branches     1240        0    -1240     
==========================================
- Hits         4160      868    -3292     
+ Misses        936      116     -820     
+ Partials       96        0      -96     
Files Coverage Δ
backend/app/schemas/acmgseqvar.py 100.00% <100.00%> (ø)

... and 105 files with indirect coverage changes

@gromdimon gromdimon enabled auto-merge (squash) December 20, 2023 09:44
@gromdimon gromdimon merged commit 0bfd3c0 into main Dec 20, 2023
8 checks passed
@gromdimon gromdimon deleted the 288-make-abbreviation-display-of-seqvar-acmg-rating-all-upper-case branch December 20, 2023 09:48
@holtgrewe holtgrewe added this to the 0.3.0 milestone Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make abbreviation display of seqvar ACMG rating all upper case
2 participants