fix: Make criterias upper case

bihealth · Dec 20, 2023 · 54ea2f8 · 54ea2f8
1 parent 17eee05
commit 54ea2f8
Show file tree

Hide file tree

Showing 11 changed files with 336 additions and 349 deletions.
diff --git a/backend/app/schemas/acmgseqvar.py b/backend/app/schemas/acmgseqvar.py
@@ -22,34 +22,34 @@ class Evidence(str, Enum):
 
 
 class Criteria(str, Enum):
-    Pvs1 = "Pvs1"
-    Ps1 = "Ps1"
-    Ps2 = "Ps2"
-    Ps3 = "Ps3"
-    Ps4 = "Ps4"
-    Pm1 = "Pm1"
-    Pm2 = "Pm2"
-    Pm3 = "Pm3"
-    Pm4 = "Pm4"
-    Pm5 = "Pm5"
-    Pm6 = "Pm6"
-    Pp1 = "Pp1"
-    Pp2 = "Pp2"
-    Pp3 = "Pp3"
-    Pp4 = "Pp4"
-    Pp5 = "Pp5"
-    Ba1 = "Ba1"
-    Bs1 = "Bs1"
-    Bs2 = "Bs2"
-    Bs3 = "Bs3"
-    Bs4 = "Bs4"
-    Bp1 = "Bp1"
-    Bp2 = "Bp2"
-    Bp3 = "Bp3"
-    Bp4 = "Bp4"
-    Bp5 = "Bp5"
-    Bp6 = "Bp6"
-    Bp7 = "Bp7"
+    PVS1 = "PVS1"
+    PS1 = "PS1"
+    PS2 = "PS2"
+    PS3 = "PS3"
+    PS4 = "PS4"
+    PM1 = "PM1"
+    PM2 = "PM2"
+    PM3 = "PM3"
+    PM4 = "PM4"
+    PM5 = "PM5"
+    PM6 = "PM6"
+    PP1 = "PP1"
+    PP2 = "PP2"
+    PP3 = "PP3"
+    PP4 = "PP4"
+    PP5 = "PP5"
+    BA1 = "BA1"
+    BS1 = "BS1"
+    BS2 = "BS2"
+    BS3 = "BS3"
+    BS4 = "BS4"
+    BP1 = "BP1"
+    BP2 = "BP2"
+    BP3 = "BP3"
+    BP4 = "BP4"
+    BP5 = "BP5"
+    BP6 = "BP6"
+    BP7 = "BP7"
 
 
 class SeqVarCriteria(BaseModel):

diff --git a/backend/tests/api/api_v1/test_acmgseqvar.py b/backend/tests/api/api_v1/test_acmgseqvar.py
@@ -21,7 +21,7 @@ def acmgseqvar_post_data() -> dict[str, Any]:
             "comment": "No comment",
             "criterias": [
                 {
-                    "criteria": "Pm4",
+                    "criteria": "PM4",
                     "presence": "Absent",
                     "evidence": "Pathogenic Moderate",
                 }
@@ -482,7 +482,7 @@ def acmgseqvar_update_data() -> dict[str, Any]:
             "comment": "Update",
             "criterias": [
                 {
-                    "criteria": "Pm4",
+                    "criteria": "PM4",
                     "presence": "Present",
                     "evidence": "Pathogenic Moderate",
                 }

diff --git a/backend/tests/crud/test_acmgseqvar.py b/backend/tests/crud/test_acmgseqvar.py
@@ -18,7 +18,7 @@
 def acmgseqvar_create() -> AcmgSeqVarCreate:
     """Create a AcmgSeqVarCreate object."""
     pm4 = SeqVarCriteria(
-        criteria=Criteria.Pm4,
+        criteria=Criteria.PM4,
         presence=Presence.Absent,
         evidence=Evidence.PathogenicModerate,
     )

diff --git a/frontend/src/components/__tests__/CriterionSwitch.spec.ts b/frontend/src/components/__tests__/CriterionSwitch.spec.ts
@@ -9,8 +9,8 @@ import { setupMountedComponents } from '@/lib/test-utils'
 describe.concurrent('ClinsigCard', async () => {
   it('renders the AcmgRating info', async () => {
     const acmgRating = new MultiSourceAcmgCriteriaState()
-    acmgRating.setPresence(StateSource.InterVar, AcmgCriteria.Pvs1, Presence.Present)
-    const criteria = AcmgCriteria.Pvs1
+    acmgRating.setPresence(StateSource.InterVar, AcmgCriteria.PVS1, Presence.Present)
+    const criteria = AcmgCriteria.PVS1
     const criteriaState = acmgRating.getCriteriaState(criteria)
 
     const { wrapper } = await setupMountedComponents(
@@ -24,19 +24,19 @@ describe.concurrent('ClinsigCard', async () => {
       }
     )
     expect(wrapper.text()).toContain('Pathogenic')
-    expect(wrapper.text()).toContain('Pvs1')
+    expect(wrapper.text()).toContain('PVS1')
 
     const switcher = wrapper.find('.v-switch')
-    expect(switcher.text()).toContain('Pvs1')
+    expect(switcher.text()).toContain('PVS1')
 
     const selection = wrapper.find('.v-select')
     expect(selection.text()).toContain('Pathogenic')
   })
 
   it('should correctly update the ClinsigCard info', async () => {
     const acmgRating = new MultiSourceAcmgCriteriaState()
-    acmgRating.setPresence(StateSource.InterVar, AcmgCriteria.Pvs1, Presence.Present)
-    const criteria = AcmgCriteria.Pvs1
+    acmgRating.setPresence(StateSource.InterVar, AcmgCriteria.PVS1, Presence.Present)
+    const criteria = AcmgCriteria.PVS1
     const criteriaState = acmgRating.getCriteriaState(criteria)
 
     const { wrapper } = await setupMountedComponents(

diff --git a/frontend/src/components/__tests__/SeqvarDetails/ClinsigCard.spec.ts b/frontend/src/components/__tests__/SeqvarDetails/ClinsigCard.spec.ts
@@ -27,15 +27,15 @@ const makeWrapper = () => {
     store.storeState = StoreState.Active
     store.seqvar = deepCopy(seqvarInfo)
     store.acmgRating = new MultiSourceAcmgCriteriaState()
-    store.acmgRating.setPresence(StateSource.InterVar, AcmgCriteria.Pvs1, Presence.Present)
+    store.acmgRating.setPresence(StateSource.InterVar, AcmgCriteria.PVS1, Presence.Present)
     store.acmgRatingStatus = true
   })
   store.fetchAcmgRating = mockRetrieveAcmgRating
 
   store.storeState = StoreState.Active
   store.seqvar = deepCopy(seqvarInfo)
   store.acmgRating = new MultiSourceAcmgCriteriaState()
-  store.acmgRating.setPresence(StateSource.InterVar, AcmgCriteria.Pvs1, Presence.Present)
+  store.acmgRating.setPresence(StateSource.InterVar, AcmgCriteria.PVS1, Presence.Present)
   store.acmgRatingStatus = true
 
   return setupMountedComponents(

diff --git a/frontend/src/components/__tests__/SeqvarDetails/ClinsigCard/CriterionSwitch.spec.ts b/frontend/src/components/__tests__/SeqvarDetails/ClinsigCard/CriterionSwitch.spec.ts
@@ -13,23 +13,23 @@ import { setupMountedComponents } from '@/lib/test-utils'
 describe.concurrent('CriterionSwitch', async () => {
   it('renders the CriterionSwitch', async () => {
     const acmgRating = new MultiSourceAcmgCriteriaState()
-    acmgRating.setPresence(StateSource.User, AcmgCriteria.Pm1, Presence.Present)
+    acmgRating.setPresence(StateSource.User, AcmgCriteria.PM1, Presence.Present)
     const { wrapper } = await setupMountedComponents(
       { component: CriterionSwitch, template: false },
       {
         props: {
           acmgRating: acmgRating,
-          criteria: AcmgCriteria.Pm1,
+          criteria: AcmgCriteria.PM1,
           criteriaState: {
-            criteria: AcmgCriteria.Pm1,
+            criteria: AcmgCriteria.PM1,
             presence: Presence.Present,
             evidenceLevel: AcmgEvidenceLevel.PathogenicModerate
           }
         }
       }
     )
 
-    expect(wrapper.text()).contains('Pm1')
+    expect(wrapper.text()).contains('PM1')
     expect(wrapper.text()).contains('Pathogenic Moderate')
     const vSwitch = wrapper.findComponent({ name: 'VSwitch' })
     const vTooltip = wrapper.findComponent({ name: 'VTooltip' })