Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make abbreviation display of seqvar ACMG rating all upper case #288

Closed
holtgrewe opened this issue Dec 15, 2023 · 0 comments · Fixed by #317
Closed

Make abbreviation display of seqvar ACMG rating all upper case #288

holtgrewe opened this issue Dec 15, 2023 · 0 comments · Fixed by #317
Assignees
@gromdimon
Labels
bug Something isn't working
Milestone
0.3.0

Comments

@holtgrewe
Copy link
Member

Describe the bug
Currently, we display Pvs1, for example.

Expected behavior
All criteria should be all upper case, e.g., PVS1.

Additional context
N/A
@holtgrewe holtgrewe added the bug Something isn't working label Dec 15, 2023
@holtgrewe holtgrewe added this to the 0.3.0 milestone Dec 15, 2023
@gromdimon gromdimon linked a pull request Dec 20, 2023 that will close this issue
fix: Make seqvar ACMG criterias upper case (#288) #317
Merged
gromdimon added a commit that referenced this issue Dec 20, 2023
@gromdimon
fix: Make seqvar ACMG criterias upper case (#288) (#317)
0bfd3c0
@varfish-bot varfish-bot mentioned this issue Dec 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gromdimon gromdimon

Labels
bug Something isn't working
Projects
None yet
Milestone
0.3.0
Development

Successfully merging a pull request may close this issue.

fix: Make seqvar ACMG criterias upper case (#288) bihealth/reev
2 participants
@holtgrewe @gromdimon