-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nextest compatibility #602
Conversation
(Let me know if I should target 0.4 or master for this) |
This is awesome, would be great to have this reviewed and land. Wonder if there is anything blocking? |
No, the only blocker is that I have limited time and energy to spend on open-source work lately. My apologies for the delay, I'll try to get to it at some point. |
This makes a plain `--list` work. Note that this shouldn't result in any compatibility issues since --list is mutually exclusive with --test.
5bcec81
to
198acfb
Compare
Warnings shouldn't go to stdout.
Match libtest benchmarks.
This is required for cargo-nextest.
Since criterion doesn't have a notion of ignored tests, this skips over all tests.
Required by cargo-nextest.
GitHub CI supports ANSI color codes, so this makes the output look a lot prettier.
198acfb
to
523d42c
Compare
@lemmih do you think you'd be able to get a version out with this soon? Had another request come in today. |
Releases are managed by @bheisler. |
Hi @bheisler, do you think you'd be able to make a release soon? Thank you so much for maintaining criterion! |
Thanks @lemmih. Happy to spend some time on this tomorrow. What would be a good way to coordinate our efforts? |
If you begin updating the changelog, put the changes in a draft PR. |
work-in-progress updates for the changelog -> #680 |
This commit stack makes criterion compatible with nextest using the rules listed here. Each commit is independently reviewable.
Note that none of these changes do anything special for nextest -- they just make criterion implement more of the libtest command-line interface, just enough to make nextest happy.
Addresses #562 -- once this commit stack lands and a new version of criterion goes out, I'd be happy to advertise compatibility on the nextest site.