Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post v0.4 CHANGELOG updates #680

Merged
merged 5 commits into from
May 23, 2023
Merged

Conversation

nbarrios1337
Copy link
Contributor

@nbarrios1337 nbarrios1337 commented May 13, 2023

Note: criterion would likely need a release-related PR bumping all the criterion = "0.4" instances across the documentation

Misplaced the MSRV bump changelog update
Used prior updates as a basis for what changes to include and phrasing.
Copy link
Contributor

@sunshowers sunshowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I also reviewed #679 which looks great.

@nbarrios1337
Copy link
Contributor Author

nbarrios1337 commented May 16, 2023

@lemmih Happy to set this to a ready state, but I think we need more details on the upcoming release to finalize the changelog update:

  • Will the upcoming release require a minor or patch version bump?
  • Should we have a similar PR addressing all the instances of "criterion = 0.4" in the examples and sample code?
  • Should this PR merge before or after the release?

@lemmih
Copy link
Collaborator

lemmih commented May 16, 2023

@lemmih Happy to set this to a ready state, but I think we need more details on the upcoming release to finalize the changelog update:

  • Will the upcoming release require a minor or patch version bump?

Semantic versioning is fuzzy regarding changes to MSRV but let's make it a major release out of an abundance of caution.

  • Should we have a similar PR addressing all the instances of "criterion = 0.4" in the examples and sample code?

Yes.

  • Should this PR merge before or after the release?

Before.

@nbarrios1337 nbarrios1337 marked this pull request as ready for review May 17, 2023 19:39
@lemmih lemmih merged commit 3e2849e into bheisler:master May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants