Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect arguments passed to benchmarks #871

Closed
Wodann opened this issue May 10, 2023 · 1 comment
Closed

Incorrect arguments passed to benchmarks #871

Wodann opened this issue May 10, 2023 · 1 comment

Comments

@Wodann
Copy link

Wodann commented May 10, 2023

When I run nextest with --all-targets, testing of benchmarks fails with the following error message:

Error: creating test list failed
Caused by:
  for `rethnet_evm::bench/state`, command `/home/runner/work/hardhat/hardhat/target/debug/deps/state-3c982b29c4c2de0f --list --format terse` exited with code 2
--- stdout:

--- stderr:
Gnuplot not found, using plotters backend
error: Found argument '--format' which wasn't expected, or isn't valid in this context
Error: Found argument '--format' which wasn't expected, or isn't valid in this context
	If you tried to supply `--format` as a value rather than a flag, use `-- --format`

It seems like the --format argument that's passed follows the wrong convention

@sunshowers
Copy link
Member

Thanks for the report! This is actually a bug in criterion: #96.

The fix to make criterion support nextest has landed (bheisler/criterion.rs#602), but has not been released yet.

Closing as a dup of #96.

@sunshowers sunshowers closed this as not planned Won't fix, can't repro, duplicate, stale May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants