Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete pit service layer changes #8

Open
wants to merge 30 commits into
base: createpitservice
Choose a base branch
from
Open

Delete pit service layer changes #8

wants to merge 30 commits into from

Conversation

bharath-techie
Copy link
Owner

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link

Gradle Check (Jenkins) Run Completed with:

  • RESULT: null ❌
  • URL:
  • CommitID: f20dbdc

@github-actions
Copy link

Gradle Check (Jenkins) Run Completed with:

  • RESULT: null ❌
  • URL:
  • CommitID: bba02294e075579aa7c2167911a3cc5c31a530f6

@github-actions
Copy link

Gradle Check (Jenkins) Run Completed with:

  • RESULT: null ❌
  • URL:
  • CommitID: 8f673c5

@github-actions
Copy link

Gradle Check (Jenkins) Run Completed with:

  • RESULT: null ❌
  • URL:
  • CommitID: 97c4f77

@bharath-techie bharath-techie force-pushed the createpitservice branch 3 times, most recently from 6963b68 to 987cb57 Compare July 19, 2022 08:11
@github-actions
Copy link

Gradle Check (Jenkins) Run Completed with:

  • RESULT: null ❌
  • URL:
  • CommitID: 9497923

@github-actions
Copy link

Gradle Check (Jenkins) Run Completed with:

  • RESULT: null ❌
  • URL:
  • CommitID: 5c452d46bbb5c6cc0629a55cec8792ad7de9c6f7

@github-actions
Copy link

Gradle Check (Jenkins) Run Completed with:

  • RESULT: null ❌
  • URL:
  • CommitID: ab3f0d4

@bharath-techie bharath-techie force-pushed the createpitservice branch 2 times, most recently from ed20a79 to 8067e7b Compare July 19, 2022 11:16
@bharath-techie
Create pit service layer changes (opensearch-project#3921)
55eb86d 
* Create pit service layer changes

Signed-off-by: Bharathwaj G <[email protected]>
@github-actions
Copy link

Gradle Check (Jenkins) Run Completed with:

  • RESULT: null ❌
  • URL:
  • CommitID: a30911349377483d8935f01309035f7dfc261a21

@bharath-techie
Resolving conflicts
41d342d 
Signed-off-by: Bharathwaj G <[email protected]>
@github-actions
Copy link

Gradle Check (Jenkins) Run Completed with:

  • RESULT: null ❌
  • URL:
  • CommitID: 41d342d

@bharath-techie
Addressing comments
25bb645 
Signed-off-by: Bharathwaj G <[email protected]>
@github-actions
Copy link

Gradle Check (Jenkins) Run Completed with:

  • RESULT: null ❌
  • URL:
  • CommitID: 25bb645

@Rishikesh1159
[Segment Replication] Fixing flaky test failure happening for testSha…
4466a1f 
…rdAlreadyReplicating() (opensearch-project#3943)

* Fixing flaky test failure happening for testShardAlreadyReplicating()

Signed-off-by: Rishikesh1159 <[email protected]>
@github-actions
Copy link

Gradle Check (Jenkins) Run Completed with:

  • RESULT: null ❌
  • URL:
  • CommitID: e36c60a80a67169a195d96248bdc03a724a3634f

@github-actions
Copy link

Gradle Check (Jenkins) Run Completed with:

  • RESULT: null ❌
  • URL:
  • CommitID: 595afcd92328bd2ef58985c8856af08eaf19a797

@bharath-techie
Addressing comments
717cd66 
Signed-off-by: Bharathwaj G <[email protected]>
@github-actions
Copy link

Gradle Check (Jenkins) Run Completed with:

  • RESULT: null ❌
  • URL:
  • CommitID: 717cd66

Rishikesh1159 and others added 4 commits July 21, 2022 06:59
@Rishikesh1159
Fix possible flaky test for testBeforeIndexShardClosed_CancelsOngoing…
8b5a10c 
…Replications() (opensearch-project#3963)

* Fixing flaky test failure happening for testShardAlreadyReplicating()

Signed-off-by: Rishikesh1159 <[email protected]>
@Rishikesh1159
[Segment Replication] Checkpoint Replay on Replica Shard (opensearch-…
bb593d6 
…project#3658)

* Adding Latest Recevied checkpoint, replay checkpoint logic along with tests

Signed-off-by: Rishikesh1159 <[email protected]>
@mattweber
Make HybridDirectory MMAP Extensions Configurable (opensearch-project…
b08a2b8 
…#3837)

* Make HybridDirectory MMAP Extensions Configurable

Make the HybridDirectory's list of mmap extensions configurable
via index settings instead of being hard-coded to a specfic set.
Set defaults to the list of currently hard-coded values for
backwards compatibility.

Signed-off-by: Matt Weber <[email protected]>

* Add javadoc to INDEX_STORE_HYBRID_MMAP_EXTENSIONS.

Signed-off-by: Matt Weber <[email protected]>
Deprecate public methods and variables that contain 'master' terminol…
ccf1d15 
…ogy in 'client' directory (opensearch-project#3966)

* Deprecate public methods and variables that contain 'master' terminology in 'client' directory

Signed-off-by: Tianli Feng <[email protected]>

* Change 3 String type usages with 'master' to 'cluster manager'

Signed-off-by: Tianli Feng <[email protected]>
@github-actions
Copy link

Gradle Check (Jenkins) Run Completed with:

  • RESULT: null ❌
  • URL:
  • CommitID: 31668b2bbfce2b44ffc279f84892eab1f387bbfb

@bharath-techie
Addressing review comment
f4db20b 
Signed-off-by: Bharathwaj G <[email protected]>
@github-actions
Copy link

Gradle Check (Jenkins) Run Completed with:

  • RESULT: null ❌
  • URL:
  • CommitID: f4db20b

mch2 and others added 5 commits July 22, 2022 09:31
@mch2
[Segment Replication] Wire up segment replication with peer recovery …
197909c 
…and add ITs. (opensearch-project#3743)

* Add null check when computing max segment version.

With segment replication enabled it is possible Lucene does not set the SegmentInfos
min segment version, leaving the default value as null.

Signed-off-by: Marc Handalian <[email protected]>

* Update peer recovery to set the translogUUID of replicas to the UUID generated on the primary.

This change updates the UUID when the translog is created to the value stored in the passed segment userdata.
This is to ensure during failover scenarios that the replica can be promoted and not have a uuid mismatch with the value stored in user data.

Signed-off-by: Marc Handalian <[email protected]>

* Wire up Segment Replication under the feature flag.

This PR wires up segment replication and adds some initial integration tests.

Signed-off-by: Marc Handalian <[email protected]>

* Add test to ensure replicas use primary translog uuid with segrep.

Signed-off-by: Marc Handalian <[email protected]>

* Update SegmentReplicationIT to assert previous commit points are valid and SegmentInfos can be built.
Fix nitpicks in PR feedback.

Signed-off-by: Marc Handalian <[email protected]>

* Fix test with Assert.fail to include a message.

Signed-off-by: Marc Handalian <[email protected]>
@hauck-jvsh @reta
Adds a new parameter, max_analyzer_offset, for the highlighter (opens…
931813f 
…earch-project#3893)

* opensearch-project#3842 adds a new parameter to the highlighter, the max_analyzer_offset. When this parameter is provided the highlight stops in its value. This prevents the highlighter to go beyond the index maxAnalyzedOffset.

Signed-off-by: Hauck <[email protected]>

* Adds a test for the new parameter

Signed-off-by: Hauck <[email protected]>

* Fix the test add in the previous commit;

Signed-off-by: Hauck <[email protected]>

* This was checking against the wrong field

Signed-off-by: Hauck <[email protected]>

* Only runs the test for the correct version

Signed-off-by: Hauck <[email protected]>

* Skips the test in Elasticsearch as well;

Signed-off-by: Hauck <[email protected]>

* Remove elastic 3.0 to test

Signed-off-by: Hauck <[email protected]>

* Skips all versions

Signed-off-by: Hauck <[email protected]>

* Remove unnecessary fields as pointed by @reta

Signed-off-by: Hauck <[email protected]>

* Compute if fieldMaxAnalyzedIsNotValid in the constructor as suggest by @reta

Signed-off-by: Hauck <[email protected]>

* As discussed, it is better to throws different exceptions for when the fieldMaxAnalyzed is not valid and for when it is disabled;

Signed-off-by: Hauck <[email protected]>

* hint what to do to allow highlight of bigger documents
Signed-off-by: Hauck <[email protected]>

* Let the user define the new parameter globally for all fields highlighted

Signed-off-by: Hauck <[email protected]>

* Change the  fieldMaxAnalyzedOffset Integer in order to use null when it is absent in highlight. This allows the error messages to much more precise, showing invalid for all negative numbers;

Signed-off-by: Hauck <[email protected]>

* Update javadocs and implements the stream methods for the new fields;

Signed-off-by: Hauck <[email protected]>

* builder.field do not accept null, so check before calling the method is necessary

Signed-off-by: Hauck <[email protected]>

* Only send and read the new fields if the version supports it

Signed-off-by: Hauck <[email protected]>

* the previous commit was checking the wrong field

Signed-off-by: Hauck <[email protected]>

* Check for version 3.0.0 instead of current version

Signed-off-by: Hauck <[email protected]>

* Update server/src/main/java/org/apache/lucene/search/uhighlight/CustomUnifiedHighlighter.java

Co-authored-by: Andriy Redko <[email protected]>
Signed-off-by: Hauck <[email protected]>

* Execute the test after version 3.0.0

Signed-off-by: Hauck <[email protected]>

Co-authored-by: Andriy Redko <[email protected]>
Deprecate public methods and variables that contain 'master' terminol…
5db75c1 
…ogy in 'test/framework' directory (opensearch-project#3978)

* Deprecate methods with 'master' name mainly in class 'InternalTestCluster', 'NodeRoles', and 'AbstractSnapshotIntegTestCase'

* Deprecate variables contain 'master' in the name in class 'InternalTestCluster'

Signed-off-by: Tianli Feng <[email protected]>
@piyushdaftary
Parallelize stale blobs deletion during snapshot delete (opensearch-p…
1c787e8 
…roject#3796)

* Parallelize stale blobs deletion during snapshot delete

Signed-off-by: Piyush Daftary <[email protected]>

* Adding test which throws exception

Signed-off-by: Piyush Daftary <[email protected]>

* Adusting identation for spotlessJavaCheck

Signed-off-by: Piyush Daftary <[email protected]>

* Adding more description to MAX_SHARD_BLOB_DELETE_BATCH_SIZE

Signed-off-by: Piyush Daftary <[email protected]>

* Renaming max_shard_blob_delete_batch_size to max_snapshot_shard_blob_delete_batch_size

Signed-off-by: Piyush Daftary <[email protected]>
@adnapibar
Add guidelines for code contributions (opensearch-project#3976)
efde8c5 
A set of guidelines to decide whether a feature should be included in OpenSearch.

Signed-off-by: Rabi Panda <[email protected]>
@github-actions
Copy link

Gradle Check (Jenkins) Run Completed with:

  • RESULT: null ❌
  • URL:
  • CommitID: 38313f4db8cf8380163f128981b3fd0d9af456a2

shdubsh and others added 2 commits July 25, 2022 19:51
@shdubsh
Use bash in systemd-entrypoint shebang (opensearch-project#4008)
b24b02f 
Uses a shell environment where `-o pipefail` is available.

Closes opensearch-project#4005

Signed-off-by: Cole White <[email protected]>
@bharath-techie
Addressing review comment - adding tests to test concurrency
3f08013 
Signed-off-by: Bharathwaj G <[email protected]>
@github-actions
Copy link

Gradle Check (Jenkins) Run Completed with:

  • RESULT: null ❌
  • URL:
  • CommitID: 3f08013

@github-actions
Copy link

Gradle Check (Jenkins) Run Completed with:

  • RESULT: null ❌
  • URL:
  • CommitID: 61923493514304da08c8de580ffce26bbd5961d3

@github-actions
Copy link

Gradle Check (Jenkins) Run Completed with:

  • RESULT: null ❌
  • URL:
  • CommitID: ae618ff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@bharath-techie @Rishikesh1159 @saratvemulapalli @mattweber @mch2 @hauck-jvsh @piyushdaftary @adnapibar @shdubsh