[Segment Replication] Wire up segment replication with peer recovery and add ITs.

[mch2]

Signed-off-by: Marc Handalian [email protected]

Description

This change wires up segment replication under the feature flag and adds some ITs. This PR reuses peer recovery with segment replication. Replicas will be in sync in that they have durably persisted all docs, but will not have all docs searchable until the next refresh on the primary & replication event.

Other changes:

• Add null check when computing max segment version in store.java.
  With segment replication enabled Lucene does not set the SegmentInfos
  min segment version on a refresh or flush, leaving the default value as null. The value is only set when reading infos from a commit point.
• Update peer recovery to set the translogUUID of replicas to the UUID generated on the primary.
  This change updates the UUID when the translog is created to the value stored in the passed segment userdata.
  This is to ensure during failover scenarios that the replica can be promoted and not have a uuid mismatch with the value stored in user data.

Issues Resolved

#3483

Check List

• [ x] New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• [ x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[peterzhuamazon]

Hi @mch2 please rebase on main to consume latest gradle check changes.
Thanks.

[mch2]

FYI this is still a draft, I expect the gradle check to fail here as I'm hardcoding the segrep feature flag to true for now.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: ABORTED ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/111/
• CommitID: 4222bee

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/144/
• CommitID: 9ddaf66455c034c982768a33fb4d52a17e165da6

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/358/
• CommitID: eca7176037d944d8e7a23edbb85a54e35203e15c

[kartg]

2 nitpicks here:

First, remove the shardId member variable in this class and have shardId() return indexShard.shardId() instead. Then use shardId() here to parallel the else clause

Second, (and you can punt this to a follow-up PR), it'd be nice to have the arguments of createEmptyTranslog maintain a consistent ordering across the various overloaded definitions.

[mch2]

1 - Done. 2 - Will follow up with this to not inflate this pr.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/893/
• CommitID: c37b752

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/896/
• CommitID: 148e2b8

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-3743-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 197909c71f91f1e26da7bc6c7218b53fbb73cdae
# Push it to GitHub
git push --set-upstream origin backport/backport-3743-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-3743-to-2.x.