[Segment Replication] Fixing flaky test failure happening for testShardAlreadyReplicating() #3943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rishikesh1159 <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #3943 +/- ##
============================================
- Coverage 70.57% 70.57% -0.01%
- Complexity 56679 56748 +69
============================================
Files 4563 4573 +10
Lines 272755 273255 +500
Branches 40040 40076 +36
============================================
+ Hits 192505 192839 +334
- Misses 64014 64178 +164
- Partials 16236 16238 +2
|
…rviceTests Signed-off-by: Rishikesh1159 <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
mch2
reviewed
Jul 19, 2022
| public void testShardAlreadyReplicating() { | ||
| SegmentReplicationTargetService spy = spy(sut); | ||
| public void testShardAlreadyReplicating() throws InterruptedException { | ||
| SegmentReplicationTargetService serviceSpy = spy(sut); |
There was a problem hiding this comment.
nit - A comment here explaining why we need to spy on the service and what we are asserting would be useful.
kartg
approved these changes
Jul 19, 2022
There was a problem hiding this comment.
Approving since the test is functioning properly, but please consider adding more comments to the testShardAlreadyReplicating test case to make it easier to understand. The test is manipulating a lot of objects to achieve a specific scenario and it's hard to quickly grok what each step is doing.
Comment on lines
63
to
64
| cp = indexShard.getLatestReplicationCheckpoint(); | ||
| newCheckpoint = new ReplicationCheckpoint( |
There was a problem hiding this comment.
Nitpick - more descriptive variable names, please. cp is hard to decipher at first glance and newCheckpoint is confusing when it's being initialized to be equal to cp
| public void testShardAlreadyReplicating() { | ||
| SegmentReplicationTargetService spy = spy(sut); | ||
| public void testShardAlreadyReplicating() throws InterruptedException { | ||
| SegmentReplicationTargetService serviceSpy = spy(sut); | ||
| // Create a separate target and start it so the shard is already replicating. |
There was a problem hiding this comment.
This comment seems out of place now since the replication is not started until multiple lines later. Consider removing it
…cating() test case Signed-off-by: Rishikesh1159 <[email protected]>
…to main Signed-off-by: Rishikesh1159 <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Rishikesh1159
added a commit
to Rishikesh1159/OpenSearch
that referenced
this pull request
Aug 10, 2022
…rdAlreadyReplicating() (opensearch-project#3943) * Fixing flaky test failure happening for testShardAlreadyReplicating() Signed-off-by: Rishikesh1159 <[email protected]>
Rishikesh1159
added a commit
to Rishikesh1159/OpenSearch
that referenced
this pull request
Aug 10, 2022
Signed-off-by: Rishikesh1159 <[email protected]>
Rishikesh1159
added a commit
that referenced
this pull request
Aug 11, 2022
…#3943 #3963 From main branch (#4181) * Resolving import conflict in Node.java and mergining PR #3525. Signed-off-by: Rishikesh1159 <[email protected]> * Resolving conflicts and merging PR #3533. Signed-off-by: Rishikesh1159 <[email protected]> * Resolving conflicts and Merging PR #3540. Signed-off-by: Rishikesh1159 <[email protected]> * Applying spotlesscheck and fixing wildcard imports. Signed-off-by: Rishikesh1159 <[email protected]> * [Segment Replication] Fixing flaky test failure happening for testShardAlreadyReplicating() (#3943) * Fixing flaky test failure happening for testShardAlreadyReplicating() Signed-off-by: Rishikesh1159 <[email protected]> * Fix possible flaky test for testBeforeIndexShardClosed_CancelsOngoingReplications() (#3963) * Fixing flaky test failure happening for testShardAlreadyReplicating() Signed-off-by: Rishikesh1159 <[email protected]> * Removing assert segrep() in getProcessedLocalCheckpoint() of Index.shard class. Signed-off-by: Rishikesh1159 <[email protected]> * Adding back assert statement and make index setting to segment replication in SegmentReplicationSourceHandlerTests and SegmentReplicationTargetServiceTests. Signed-off-by: Rishikesh1159 <[email protected]> * Revert "Adding back assert statement and make index setting to segment replication in SegmentReplicationSourceHandlerTests and SegmentReplicationTargetServiceTests." Signed-off-by: Rishikesh1159 <[email protected]> This reverts commit 8c5753b. Signed-off-by: Rishikesh1159 <[email protected]> Co-authored-by: Marc Handalian <[email protected]> Co-authored-by: Poojita Raj <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rishikesh1159 [email protected]
Description
This PR fixes flaky test failure of testShardAlreadyReplicating()
Issues Resolved
#3872
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.