incompatible_disable_expand_if_all_available_in_flag_set: Only use expand_if_all_available in flag_group in CROSSTOOL #7008
Assignees
Labels
Comments
hlopko
added
team-Rules-CPP
bazel-io
pushed a commit
that referenced
this issue
Jan 2, 2019
Corresponding issue: #7008 RELNOTES: None. PiperOrigin-RevId: 227522028
meteorcloudy
changed the title
bazel-io
pushed a commit
to bazelbuild/rules_cc
that referenced
this issue
Jan 11, 2019
Corresponding issue: bazelbuild/bazel#7008 RELNOTES: None. PiperOrigin-RevId: 227522028
bazel-io
pushed a commit
to bazelbuild/rules_cc
that referenced
this issue
Feb 18, 2019
FlagSets in the CROSSTOOL no longer accept expand_if_all_available field Fixes #7008 RELNOTES: `--incompatible_disable_expand_if_all_available_in_flag_set` has been flipped (bazelbuild/bazel#7008) PiperOrigin-RevId: 234466411
|
Reopening, the change was rolled back. I still plan to flip this flag in 0.23 though. |
|
Because of #6861, we also postpone this flag flip till 0.25. |
hlopko
added a commit
that referenced
this issue
Mar 12, 2019
…e_disable_expand_if_all_available_in_flag_set Fixes #7008 Fixes #6861 RELNOTES: `--incompatible_disable_legacy_crosstool_fields` has been flipped (#6861) `--incompatible_disable_expand_if_all_available_in_flag_set` has been flipped (#7008) PiperOrigin-RevId: 234759266 Change-Id: I54a1213991b161ccddfebdcd3ba83239adf0c66d
|
This broke bazel's ndk crosstools, reopening. |
bazel-io
pushed a commit
that referenced
this issue
Mar 21, 2019
Before this cl, AndroidNdkRepositoryFunction generated CROSSTOOL file that configured the C++ toolchain for ndk. This cl changes this function to generate a Starlark rule providing CcToolchainConfigInfo, which is the "new" way of configuring C++ toolchains. This change should not be observable by ndk users. As a result, generated ndk toolchain is forward compatible with incompatible changes: * #7008 * #6861 * #7320 * #7075 RELNOTES: Android NDK C++ toolchain is now configured in Starlark. This should be a backwards compatible change, but in case of bugs blame unknown commit. PiperOrigin-RevId: 239565213
bazel-io
pushed a commit
that referenced
this issue
Mar 26, 2019
Baseline: 235e76b Cherry picks: + badd82e: Automated rollback of commit 1b4c37c. + 33e5719: Fix the Python version select() mechanism to handle PY3-as-default + 56366ee: Set non-empty values for msvc_env_* when VC not installed + 22b3fbf: Windows, test wrapper: fix broken integration test + f14d447: Add whitelist file for starlark transitions + d99bc47: Update BUILD + 3529ad7: Rename tools/function_transition_whitelist/BUILD to tools/whitelists/function_transition_whitelist/BUILD + de0612a: Update bazel_toolchains to latest release and add toolchain config target for BuildKite CI (rbe_ubuntu1604) + 3e660ad: Automated rollback of commit 0877340. + 314cf1f: Pass -undefined dynamic_lookup to dynamic library linking actions on Mac + fc586a8: Move cc_flags target into @bazel_tools//tools/cpp. + ea1703b: C++: Fix crash reported in #7721 + 803801d: Pass execution info to xml generating spawn. Fixes #7794 Incompatible changes: - Added --incompatible_py3_is_default to test switching the default Python version to PY3 for py_binary/py_test targets that do not specify a version. See #7359. - //tools/cmd_line_differ has been renamed to //tools/aquery_differ & can now compare (in addition to command lines) inputs of actions given 2 aquery results. - java_(mutable_|)proto_library: removed strict_deps attribute. - The flag --incompatible_list_based_execution_strategy_selection was added and is used to ease the migration to the new style of specifying execution strategy selection and fallback behavior. The documentation for this flag is here: #7480 - Added --incompatible_py2_outputs_are_suffixed, for switching the bazel-bin symlink to point to Python 3 outputs instead of Python 2 outputs. See [#7593](#7593). New features: - Make actions.args() object chainable. - Added --incompatible_windows_style_arg_escaping flag: enables correct subprocess argument escaping on Windows. (No-op on other platforms.) - Added --incompatible_windows_escape_jvm_flags flag: enables correct java_binary.jvm_flags and java_test.jvm_flags tokenization and escaping on Windows. (No-op on other platforms.) Important changes: - Allow running aquery against the current state of Skyframe - Added support for the "navigation" resource directory to Android resource processing in Bazel. This is used by the Navigation Architecture Component. - --incompatible_disable_runtimes_filegroups was flipped (#6942) - Incompatible flag `--incompatible_linkopts_in_user_link_flags` has been flipped (#6826) - Incompatible flag `--incompatible_dont_emit_static_libgcc` has been flipped (#6825) - --incompatible_disallow_filetype is enabled by default. - Fixed issue where exceptions and stacktraces were silently swallowed in the Android resource processing pipeline. - `--incompatible_disable_expand_if_all_available_in_flag_set` has been flipped (#7008) - --incompatible_disallow_dict_plus is enabled by default - Adds --incompatible_disable_objc_library_resources to disable resource attributes in objc_library. Please migrate these attributes to `data` instead. - --incompatible_disallow_old_style_args_add is enabled by default. - Using the `native` module in BUILD files is deprecated. It will be forbidden with --incompatible_disallow_native_in_build_file. - (Python rules) PyRuntimeInfo is exposed to Starlark, making it possible for Starlark rules to depend on or imitate `py_runtime`. The `files` attribute of `py_runtime` is no longer mandatory. - incompatible_use_toolchain_providers_in_java_common: pass JavaToolchainInfo and JavaRuntimeInfo providers to java_common APIs instead of configured targetshttps://github.com//issues/7186. - is_using_fission crosstool variable is now exposed in all compile actions when fission is active (it used to be exposed only for linking actions). - incompatible_use_toolchain_providers_in_java_common: pass JavaToolchainInfo and JavaRuntimeInfo providers to java_common APIs instead of configured targetshttps://github.com//issues/7186. - `py_runtime` gains a `python_version` attribute for specifying whether it represents a Python 2 or 3 interpreter. - `--incompatible_java_coverage` is enabled by default. - Starlark rules can safely declare attributes named "licenses" - When using --incompatible_list_based_execution_strategy_selection, Bazel will use remote execution by default (if you specify --remote_executor), otherwise persistent workers (if the action supports it), otherwise sandboxed local execution (if the action and platform supports it) and at last unsandboxed local execution. The flags --spawn_strategy and --strategy continue to work as before - this only sets new defaults for the case where you don't specify these flags. - Set default value of --incompatible_remap_main_repo to true. - Set default value of --incompatible_remap_main_repo to true. This release contains contributions from many people at Google, as well as Andrew Suffield, Brandon Lico, Chris Eason, Clint Harrison, Ed Schouten, Garrett Hopper, George Gensure, Greg, John Millikin, Julie, Keith Smiley, Laurent Le Brun, Ryan Beasley, Shmuel H, Travis Cline, Vladimir Chebotarev.
katre
pushed a commit
that referenced
this issue
Mar 29, 2019
Baseline: 235e76b Cherry picks: + badd82e: Automated rollback of commit 1b4c37c. + 33e5719: Fix the Python version select() mechanism to handle PY3-as-default + 56366ee: Set non-empty values for msvc_env_* when VC not installed + 22b3fbf: Windows, test wrapper: fix broken integration test + f14d447: Add whitelist file for starlark transitions + d99bc47: Update BUILD + 3529ad7: Rename tools/function_transition_whitelist/BUILD to tools/whitelists/function_transition_whitelist/BUILD + de0612a: Update bazel_toolchains to latest release and add toolchain config target for BuildKite CI (rbe_ubuntu1604) + 3e660ad: Automated rollback of commit 0877340. + 314cf1f: Pass -undefined dynamic_lookup to dynamic library linking actions on Mac + fc586a8: Move cc_flags target into @bazel_tools//tools/cpp. + ea1703b: C++: Fix crash reported in #7721 + 803801d: Pass execution info to xml generating spawn. Fixes #7794 Incompatible changes: - Added --incompatible_py3_is_default to test switching the default Python version to PY3 for py_binary/py_test targets that do not specify a version. See #7359. - //tools/cmd_line_differ has been renamed to //tools/aquery_differ & can now compare (in addition to command lines) inputs of actions given 2 aquery results. - java_(mutable_|)proto_library: removed strict_deps attribute. - The flag --incompatible_list_based_execution_strategy_selection was added and is used to ease the migration to the new style of specifying execution strategy selection and fallback behavior. The documentation for this flag is here: #7480 - Added --incompatible_py2_outputs_are_suffixed, for switching the bazel-bin symlink to point to Python 3 outputs instead of Python 2 outputs. See [#7593](#7593). New features: - Make actions.args() object chainable. - Added --incompatible_windows_style_arg_escaping flag: enables correct subprocess argument escaping on Windows. (No-op on other platforms.) - Added --incompatible_windows_escape_jvm_flags flag: enables correct java_binary.jvm_flags and java_test.jvm_flags tokenization and escaping on Windows. (No-op on other platforms.) Important changes: - Allow running aquery against the current state of Skyframe - Added support for the "navigation" resource directory to Android resource processing in Bazel. This is used by the Navigation Architecture Component. - --incompatible_disable_runtimes_filegroups was flipped (#6942) - Incompatible flag `--incompatible_linkopts_in_user_link_flags` has been flipped (#6826) - Incompatible flag `--incompatible_dont_emit_static_libgcc` has been flipped (#6825) - --incompatible_disallow_filetype is enabled by default. - Fixed issue where exceptions and stacktraces were silently swallowed in the Android resource processing pipeline. - `--incompatible_disable_expand_if_all_available_in_flag_set` has been flipped (#7008) - --incompatible_disallow_dict_plus is enabled by default - Adds --incompatible_disable_objc_library_resources to disable resource attributes in objc_library. Please migrate these attributes to `data` instead. - --incompatible_disallow_old_style_args_add is enabled by default. - Using the `native` module in BUILD files is deprecated. It will be forbidden with --incompatible_disallow_native_in_build_file. - (Python rules) PyRuntimeInfo is exposed to Starlark, making it possible for Starlark rules to depend on or imitate `py_runtime`. The `files` attribute of `py_runtime` is no longer mandatory. - incompatible_use_toolchain_providers_in_java_common: pass JavaToolchainInfo and JavaRuntimeInfo providers to java_common APIs instead of configured targetshttps://github.com//issues/7186. - is_using_fission crosstool variable is now exposed in all compile actions when fission is active (it used to be exposed only for linking actions). - incompatible_use_toolchain_providers_in_java_common: pass JavaToolchainInfo and JavaRuntimeInfo providers to java_common APIs instead of configured targetshttps://github.com//issues/7186. - `py_runtime` gains a `python_version` attribute for specifying whether it represents a Python 2 or 3 interpreter. - `--incompatible_java_coverage` is enabled by default. - Starlark rules can safely declare attributes named "licenses" - When using --incompatible_list_based_execution_strategy_selection, Bazel will use remote execution by default (if you specify --remote_executor), otherwise persistent workers (if the action supports it), otherwise sandboxed local execution (if the action and platform supports it) and at last unsandboxed local execution. The flags --spawn_strategy and --strategy continue to work as before - this only sets new defaults for the case where you don't specify these flags. - Set default value of --incompatible_remap_main_repo to true. - Set default value of --incompatible_remap_main_repo to true. This release contains contributions from many people at Google, as well as Andrew Suffield, Brandon Lico, Chris Eason, Clint Harrison, Ed Schouten, Garrett Hopper, George Gensure, Greg, John Millikin, Julie, Keith Smiley, Laurent Le Brun, Ryan Beasley, Shmuel H, Travis Cline, Vladimir Chebotarev.
bazel-io
pushed a commit
that referenced
this issue
May 1, 2019
Baseline: 0366246 Cherry picks: + 3f7f255: Windows: fix native test wrapper's arg. escaping + afeb8d0: Flip --incompatible_windows_escape_jvm_flags + 4299b65: Sort DirectoryNode children to ensure validity. + 231270c: Conditionally use deprecated signature for initWithContentsOfURL + 75a3a53: Add http_archive entries for testing with various JDK versions. + 4a6354a: Now that ubuntu1804 uses JDK 11, remove explicit ubuntu1804_java11 tests. + ae102fb: Fix wrong name of ubuntu1804_javabase9 task. + 0020a97: Remove @executable_path/Frameworks from rpaths + 130f86d: Download stderr/stdout to a temporary FileOutErr Incompatible changes: - (Starlark rules) The legacy "py" provider can no longer be passed to or produced by native Python rules; use [PyInfo](https://docs.bazel.build/versions/master/skylark/lib/PyIn fo.html) instead. See [#7298](#7298) for more information. - (Python rules) The `default_python_version` attribute of the `py_binary` and `py_test` rules has been renamed to `python_version`. Also, the `--force_python` flag has been renamed to `--python_version`. See [#7308](#7308) for more information. - (Python rules) The python version now changes to whatever version is specified in a `py_binary` or `py_test`'s `python_version` attribute, instead of being forced to the value set by a command line flag. You can temporarily revert this change with `--incompatible_allow_python_version_transitions=false`. See [#7307](#7307) for more information. - --incompatible_disable_third_party_license_checking` is enabled by default - Introduced --incompatible_use_python_toolchains, which supersedes --python_top/--python_path. See #7899 and #7375 for more information. - Python 3 is now the default Python version (for `py_binary` and `py_test` targets that don't specify the `python_version` attribute). Targets that are built for Python 3 will no longer have their output put in a separate `-py3` directory; instead there is now a separate `-py2` directory for Python 2 targets. See #7359 and #7593 for more information. - objc_library resource attributes are now disabled by default. Please migrate them to data instead. See #7594 for more info. - Flip --incompatible_windows_escape_jvm_flags to true. See #7486 New features: - genrules now support a $(RULEDIR) variable that resolves to the directory where the outputs of the rule are put. - Added --incompatible_windows_native_test_wrapper flag: enables using the Bash-less test wrapper on Windows. (No-op on other platforms.) Important changes: - incompatible_use_jdk11_as_host_javabase: makes JDK 11 the default --host_javabase for remote jdk (#7219) - Makes genquery somepath output deterministic. - Tristate attributes of native rules now reject True/False (use 1/0) - Rollback of "Tristate attributes of native rules now reject True/False (use 1/0)" - Tristate attributes of native rules now reject True/False (use 1/0) - Added -incompatible_do_not_split_linking_cmdline flag. See #7670 - Tristate attributes of native rules now temporarily accept True/False again - `--incompatible_disable_legacy_crosstool_fields` has been flipped (#6861) `--incompatible_disable_expand_if_all_available_in_flag_set` has been flipped (#7008) - `--incompatible_disable_legacy_crosstool_fields` has been flipped (#6861) `--incompatible_disable_expand_if_all_available_in_flag_set... RELNOTES: None. - --incompatible_no_transitive_loads is enabled by default. - Makes TreeArtifact deterministic. - --incompatible_no_transitive_loads is enabled by default. - Android NDK C++ toolchain is now configured in Starlark. This should be a backwards compatible change, but in case of bugs blame unknown commit. - `--incompatible_disable_legacy_crosstool_fields` has been flipped (#6861) `--incompatible_disable_expand_if_all_available_in_flag_set` has been flipped (#7008) - --incompatible_no_transitive_loads is enabled by default. - --incompatible_bzl_disallow_load_after_statement is enabled - Added `--incompatible_require_ctx_in_configure_features`, see #7793 for details. - Flag --incompatible_merge_genfiles_directory is flipped. This removes the directory `bazel-genfiles` in favor of `bazel-bin`. - previously deprecated flag --experimental_remote_spawn_cache was removed - `--incompatible_disallow_load_labels_to_cross_package_boundaries` is enabled by default - Fix an issue where the Android resource processor did not surface errors from aapt2 compile and link actions. - --incompatible_no_attr_license is enabled by default - `--incompatible_disable_crosstool_file` has been flipped (#7320) - A new flag `--incompatible_string_join_requires_strings` is introduced. The sequence argument of `string.join` must contain only string elements. - --incompatible_symlinked_sandbox_expands_tree_artifacts_in_runfile s_tree has been flipped - Incompatible flag `--incompatible_disable_legacy_cc_provider` has been flipped (see #7036 for details). - Don't drop the analysis cache when the same --define flag is set multiple times and the last value is the same (e.g. if the current invocation was run with "--define foo=bar" and the previous one was run with "--define foo=baz --define foo=bar"). - The --incompatible_disable_genrule_cc_toolchain_dependency flag has been flipped (see #6867 for details). - Incompatible change `--incompatible_remove_cpu_and_compiler_attributes_from_cc_toolcha in` has been flipped (see #7075 for details). - --noexperimental_java_coverage is a no-op flag. - --experimental_java_coverage/--incompatible_java_coverage flag was removed. See #7425. - incompatible_use_toolchain_providers_in_java_common: pass JavaToolchainInfo and JavaRuntimeInfo providers to java_common APIs instead of configured targets (#7186.) - --incompatible_remote_symlinks has been flipped. The remote caching and execution protocol will now represent symlinks in outputs as such. See #7917 for more details. - Bazel is now ~20MiB smaller, from unbundling the Android rules' runtime dependencies. This release contains contributions from many people at Google, as well as Andreas Herrmann, Andrew Suffield, Andy Scott, Benjamin Peterson, Ed Baunton, George Gensure, Ian McGinnis, Ity Kaul, Jingwen Chen, John Millikin, Keith Smiley, Marwan Tammam, Mike Fourie, Oscar Bonilla, perwestling, petros, Robert Sayre, Ryan Beasley, silvergasp, Stanimir Mladenov, Travis Cline, Vladimir Chebotarev, ??.
dkelmer
pushed a commit
that referenced
this issue
May 6, 2019
Baseline: 0366246 Cherry picks: + 3f7f255: Windows: fix native test wrapper's arg. escaping + afeb8d0: Flip --incompatible_windows_escape_jvm_flags + 4299b65: Sort DirectoryNode children to ensure validity. + 231270c: Conditionally use deprecated signature for initWithContentsOfURL + 75a3a53: Add http_archive entries for testing with various JDK versions. + 4a6354a: Now that ubuntu1804 uses JDK 11, remove explicit ubuntu1804_java11 tests. + ae102fb: Fix wrong name of ubuntu1804_javabase9 task. + 0020a97: Remove @executable_path/Frameworks from rpaths + 130f86d: Download stderr/stdout to a temporary FileOutErr Incompatible changes: - (Starlark rules) The legacy "py" provider can no longer be passed to or produced by native Python rules; use [PyInfo](https://docs.bazel.build/versions/master/skylark/lib/PyIn fo.html) instead. See [#7298](#7298) for more information. - (Python rules) The `default_python_version` attribute of the `py_binary` and `py_test` rules has been renamed to `python_version`. Also, the `--force_python` flag has been renamed to `--python_version`. See [#7308](#7308) for more information. - (Python rules) The python version now changes to whatever version is specified in a `py_binary` or `py_test`'s `python_version` attribute, instead of being forced to the value set by a command line flag. You can temporarily revert this change with `--incompatible_allow_python_version_transitions=false`. See [#7307](#7307) for more information. - --incompatible_disable_third_party_license_checking` is enabled by default - Introduced --incompatible_use_python_toolchains, which supersedes --python_top/--python_path. See #7899 and #7375 for more information. - Python 3 is now the default Python version (for `py_binary` and `py_test` targets that don't specify the `python_version` attribute). Targets that are built for Python 3 will no longer have their output put in a separate `-py3` directory; instead there is now a separate `-py2` directory for Python 2 targets. See #7359 and #7593 for more information. - objc_library resource attributes are now disabled by default. Please migrate them to data instead. See #7594 for more info. - Flip --incompatible_windows_escape_jvm_flags to true. See #7486 New features: - genrules now support a $(RULEDIR) variable that resolves to the directory where the outputs of the rule are put. - Added --incompatible_windows_native_test_wrapper flag: enables using the Bash-less test wrapper on Windows. (No-op on other platforms.) Important changes: - incompatible_use_jdk11_as_host_javabase: makes JDK 11 the default --host_javabase for remote jdk (#7219) - Makes genquery somepath output deterministic. - Tristate attributes of native rules now reject True/False (use 1/0) - Rollback of "Tristate attributes of native rules now reject True/False (use 1/0)" - Tristate attributes of native rules now reject True/False (use 1/0) - Added -incompatible_do_not_split_linking_cmdline flag. See #7670 - Tristate attributes of native rules now temporarily accept True/False again - `--incompatible_disable_legacy_crosstool_fields` has been flipped (#6861) `--incompatible_disable_expand_if_all_available_in_flag_set` has been flipped (#7008) - `--incompatible_disable_legacy_crosstool_fields` has been flipped (#6861) `--incompatible_disable_expand_if_all_available_in_flag_set... RELNOTES: None. - --incompatible_no_transitive_loads is enabled by default. - Makes TreeArtifact deterministic. - --incompatible_no_transitive_loads is enabled by default. - Android NDK C++ toolchain is now configured in Starlark. This should be a backwards compatible change, but in case of bugs blame unknown commit. - `--incompatible_disable_legacy_crosstool_fields` has been flipped (#6861) `--incompatible_disable_expand_if_all_available_in_flag_set` has been flipped (#7008) - --incompatible_no_transitive_loads is enabled by default. - --incompatible_bzl_disallow_load_after_statement is enabled - Added `--incompatible_require_ctx_in_configure_features`, see #7793 for details. - Flag --incompatible_merge_genfiles_directory is flipped. This removes the directory `bazel-genfiles` in favor of `bazel-bin`. - previously deprecated flag --experimental_remote_spawn_cache was removed - `--incompatible_disallow_load_labels_to_cross_package_boundaries` is enabled by default - Fix an issue where the Android resource processor did not surface errors from aapt2 compile and link actions. - --incompatible_no_attr_license is enabled by default - `--incompatible_disable_crosstool_file` has been flipped (#7320) - A new flag `--incompatible_string_join_requires_strings` is introduced. The sequence argument of `string.join` must contain only string elements. - --incompatible_symlinked_sandbox_expands_tree_artifacts_in_runfile s_tree has been flipped - Incompatible flag `--incompatible_disable_legacy_cc_provider` has been flipped (see #7036 for details). - Don't drop the analysis cache when the same --define flag is set multiple times and the last value is the same (e.g. if the current invocation was run with "--define foo=bar" and the previous one was run with "--define foo=baz --define foo=bar"). - The --incompatible_disable_genrule_cc_toolchain_dependency flag has been flipped (see #6867 for details). - Incompatible change `--incompatible_remove_cpu_and_compiler_attributes_from_cc_toolcha in` has been flipped (see #7075 for details). - --noexperimental_java_coverage is a no-op flag. - --experimental_java_coverage/--incompatible_java_coverage flag was removed. See #7425. - incompatible_use_toolchain_providers_in_java_common: pass JavaToolchainInfo and JavaRuntimeInfo providers to java_common APIs instead of configured targets (#7186.) - --incompatible_remote_symlinks has been flipped. The remote caching and execution protocol will now represent symlinks in outputs as such. See #7917 for more details. - Bazel is now ~20MiB smaller, from unbundling the Android rules' runtime dependencies. This release contains contributions from many people at Google, as well as Andreas Herrmann, Andrew Suffield, Andy Scott, Benjamin Peterson, Ed Baunton, George Gensure, Ian McGinnis, Ity Kaul, Jingwen Chen, John Millikin, Keith Smiley, Marwan Tammam, Mike Fourie, Oscar Bonilla, perwestling, petros, Robert Sayre, Ryan Beasley, silvergasp, Stanimir Mladenov, Travis Cline, Vladimir Chebotarev, ??.
justkw
pushed a commit
to Intel-tensorflow/tensorflow
that referenced
this issue
May 14, 2019
This cl makes this toolchain forward compatible for Bazel's incompatible flags: * bazelbuild/bazel#7008 * bazelbuild/bazel#6861 * bazelbuild/bazel#7320 The current change creates a drop-in replacement for the proto crosstool, with the exception that: * all legacy fields are removed * templated variables are replaced by rule attributes * instead of empty paths in msvc toolchain we now use 'msvc_not_used' path (CcToolchainConfigInfo doesn't allow empty strings for paths). * introduced to_list_of_strings function so we can pass list of starlark string around The mechanical transformation makes the crosstool definition less readable than before - this will be addressed in a subsequent change. This change was tested by: 1) running cuda_configure.bzl and retrieving generated BUILD and CROSSTOOL files 2) applying this change 3) running cuda_configure.bzl and retrieving generated BUILD and cc_toolchain_config.bzl files 4) Using [cc_toolchain_compare_test](https://github.com/bazelbuild/rules_cc/blob/master/tools/migration/ctoolchain_compare.bzl#L24) rule to verify both CROSSTOOL and cc_toolchain_configs configure the C++ toolchain identically PiperOrigin-RevId: 248094053
deven-amd
pushed a commit
to ROCm/tensorflow-upstream
that referenced
this issue
May 15, 2019
This cl makes this toolchain forward compatible for Bazel's incompatible flags: * bazelbuild/bazel#7008 * bazelbuild/bazel#6861 * bazelbuild/bazel#7320 The current change creates a drop-in replacement for the proto crosstool, with the exception that: * all legacy fields are removed * templated variables are replaced by rule attributes * instead of empty paths in msvc toolchain we now use 'msvc_not_used' path (CcToolchainConfigInfo doesn't allow empty strings for paths). * introduced to_list_of_strings function so we can pass list of starlark string around The mechanical transformation makes the crosstool definition less readable than before - this will be addressed in a subsequent change. This change was tested by: 1) running cuda_configure.bzl and retrieving generated BUILD and CROSSTOOL files 2) applying this change 3) running cuda_configure.bzl and retrieving generated BUILD and cc_toolchain_config.bzl files 4) Using [cc_toolchain_compare_test](https://github.com/bazelbuild/rules_cc/blob/master/tools/migration/ctoolchain_compare.bzl#L24) rule to verify both CROSSTOOL and cc_toolchain_configs configure the C++ toolchain identically PiperOrigin-RevId: 248094053
lngart
pushed a commit
to lngart/GitSubSep
that referenced
this issue
Oct 5, 2021
This cl makes this toolchain forward compatible for Bazel's incompatible flags: * bazelbuild/bazel#7008 * bazelbuild/bazel#6861 * bazelbuild/bazel#7320 The current change creates a drop-in replacement for the proto crosstool, with the exception that: * all legacy fields are removed * templated variables are replaced by rule attributes * instead of empty paths in msvc toolchain we now use 'msvc_not_used' path (CcToolchainConfigInfo doesn't allow empty strings for paths). * introduced to_list_of_strings function so we can pass list of starlark string around The mechanical transformation makes the crosstool definition less readable than before - this will be addressed in a subsequent change. This change was tested by: 1) running cuda_configure.bzl and retrieving generated BUILD and CROSSTOOL files 2) applying this change 3) running cuda_configure.bzl and retrieving generated BUILD and cc_toolchain_config.bzl files 4) Using [cc_toolchain_compare_test](https://github.com/bazelbuild/rules_cc/blob/master/tools/migration/ctoolchain_compare.bzl#L24) rule to verify both CROSSTOOL and cc_toolchain_configs configure the C++ toolchain identically PiperOrigin-RevId: 248094053
luca-digrazia
pushed a commit
to luca-digrazia/DatasetCommitsDiffSearch
that referenced
this issue
Sep 4, 2022
…le_disable_expand_if_all_available_in_flag_set
Fixes #7008
Fixes #6861
This is an encore of bazelbuild/bazel@c18be0b.
TESTED=https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/852#5c90f69e-c5d2-44c1-8067-0bde4cba6f6d (remote execution is fixed after syncing, verified locally)
RELNOTES: `--incompatible_disable_legacy_crosstool_fields` has been flipped (bazelbuild/bazel#6861)
`--incompatible_disable_expand_if_all_available_in_flag_set` has been flipped (bazelbuild/bazel#7008)
PiperOrigin-RevId: 239567807
luca-digrazia
pushed a commit
to luca-digrazia/DatasetCommitsDiffSearch
that referenced
this issue
Sep 4, 2022
…le_disable_expand_if_all_available_in_flag_set
Fixes #7008
Fixes #6861
TESTED=https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/852#5c90f69e-c5d2-44c1-8067-0bde4cba6f6d (remote execution is fixed after syncing, verified locally)
RELNOTES: `--incompatible_disable_legacy_crosstool_fields` has been flipped (bazelbuild/bazel#6861)
`--incompatible_disable_expand_if_all_available_in_flag_set` has been flipped (bazelbuild/bazel#7008)
PiperOrigin-RevId: 237992006
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Flag: --incompatible_disable_expand_if_all_available_in_flag_set
Available since: 0.22 (January 2019 release)
Will be flipped in: 0.24 (February 2019 release)
Tracking issue: #5883
Rollout doc: docs.google.com/document/d/1uv4c1zag6KvdI31qdx8C6jiTognXPQrxgsUpVefm9fM/edit#
Motivation
This is a part of larger incompatible change #6861. This is a small and innocent cleanup, but since we have a migration tool for #6861, this will be an effortless change for users already migrating for #6861. This flag will only be flipped when #6861 is flipped.
Migration
Use the
legacy_fields_migratorfrom #6861.The text was updated successfully, but these errors were encountered: