incompatible_disable_crosstool_file: Disable loading data from CROSSTOOL files #7320
Assignees
Labels
incompatible-change
Incompatible/breaking change
P1
I'll work on this now. (Assignee required)
team-Rules-CPP
Issues for C++ rules
Comments
scentini
added
incompatible-change
hlopko
added
migration-ready
and removed
P2
|
I'm making a crosstool change here #7356 should I be editing the new file instead of the old CROSSTOOL.tpl? I attempted to run the migrator from rules_cc but ended up with a file that's very different from the one checked in, which makes me assume that's not perfectly reproducible |
|
The new one. I will remove the CROSSTOOL files and the templates very soon, they are not needed anymore. |
Closed
bazel-io
pushed a commit
that referenced
this issue
Feb 26, 2019
Baseline: 441fd75 Cherry picks: + 6ca7763: Fix a typo + 2310b1c: Ignore SIGCHLD in test setup script + f9eb1b5: Complete channel initialization in the event loop Incompatible changes: - //src:bazel uses the minimal embedded JDK, if you want to avoid the extra steps of minimizing the JDK, use //src:bazel-dev instead. - //src:bazel uses the minimal embedded JDK, if you want to avoid the extra steps of building bazel with the minimized JDK, use //src:bazel-dev instead. - The default value of --host_platform and --platforms will be changed to not be dependent on the configuration. This means that setting --cpu or --host_cpu will not affect the target or host platform. - Toolchain resolution for cc rules is now enabled via an incompatible flag, --incompatible_enable_cc_toolchain_resolution. The previous flag, --enabled_toolchain_types, is deprecated and will be removed. - java_(mutable_|)proto_library: removed strict_deps attribute. - Python rules will soon reject the legacy "py" struct provider (preview by enabling --incompatible_disallow_legacy_py_provider). Upgrade rules to use PyInfo instead. See [#7298](#7298). - java_(mutable_|)proto_library: removed strict_deps attribute. - Two changes to native Python rules: 1) `default_python_version` and `--force_python` are deprecated; use `python_version` and `--python_version` respectively instead. You can preview the removal of the deprecated names with --incompatible_remove_old_python_version_api. See [#7308](#7308). 2) The version flag will no longer override the declared version of a `py_binary` or `py_test` target. You can preview this new behavior with --incompatible_allow_python_version_transitions. See [#7307](#7307). Important changes: - There is a new flag available `--experimental_java_common_create_provider_enabled_packages` that acts as a whitelist for usages of `java_common.create_provider`. The constructor will be deprecated in Bazel 0.23. - [#7024] Allow chaining of the same function type in aquery. - Introduces --local_{ram,cpu}_resources, which will take the place of --local_resources. - [#6930] Add documentation for the aquery command. - Incompatible flag `--incompatible_dont_emit_static_libgcc` has been flipped (#6825) - Incompatible flag `--incompatible_linkopts_in_user_link_flags` has been flipped (#6826) - Flag --incompatible_range_type is removed. - Flag --incompatible_disallow_slash_operator is removed. - Flag --incompatible_disallow_conflicting_providers is removed. - `--incompatible_disallow_data_transition` is now enabled by default - Allow inclusion of param files in aquery output - [#6985] Add test to verify aquery's behavior for Cpp action templates. - --incompatible_require_feature_configuration_for_pic was flipped (#7007). - Also ignore module-info.class in multi-version Jars - objc_framework has been deleted. Please refer to apple_dynamic_framework_import and apple_static_framework_import rules available in [rules_apple](https://github.com/bazelbuild/rules_apple/blob/maste r/doc/rules-general.md) - --test_sharding_strategy=experimental_heuristic is no more - objc_bundle_library has been removed. Please migrate to rules_apple's [apple_resource_bundle](https://github.com/bazelbuild/rules_apple/ blob/master/doc/rules-resources.md#apple_resource_bundle). - You can now use the attribute `aapt_version` or the flag `--android_aapt` to pick the aapt version for android_local_test tests - In --keep_going mode, Bazel now correctly returns a non-zero exit code when encountering a package loading error during target pattern parsing of patterns like "//foo:all" and "//foo/...". - The default value for --incompatible_strict_action_env has been flipped to 'false' again, as we discovered breakages for local execution users. We'll need some more time to figure out the best way to make this work for local and remote execution. Follow #7026 for more details. - Locally-executed spawns tagged "no-cache" no longer upload their outputs to the remote cache. - Introduces --host_compiler flag to allow setting a compiler for host compilation when --host_crosstool_top is specified. - --incompatible_expand_directories is enabled by default - [aquery] Handle the case of aspect-on-aspect. - Fixed a longstanding bug in the http remote cache where the value passed to --remote_timeout would be interpreted as milliseconds instead of seconds. - Enable --incompatible_use_jdk10_as_host_javabase by default, see #6661 - Add --incompatible_use_jdk11_as_host_javabase: makes JDK 11 the default --host_javabase for remote jdk (#7219) - Highlight TreeArtifact in aquery text output. - Locally-executed spawns tagged "no-cache" no longer upload their outputs to the remote cache. - java_common APIs now accept JavaToolchainInfo and JavaRuntimeInfo instead of configured targets for java_toolchain and java_runtime - cc_common.create_cc_toolchain_config_info is stable and available for production use - incompatible_use_toolchain_providers_in_java_common: pass JavaToolchainInfo and JavaRuntimeInfo providers to java_common APIs instead of configured targets (#7186) - --incompatible_strict_argument_ordering is enabled by default. - Bazel now supports reading cache hits from a repository cache, even if it doesn't have write access to the cache. - Adding arm64e to OSX CROSSTOOL. - Ignore package-level licenses on config_setting. - Add an optional output_source_jar parameter to java_common.compile - --incompatible_disable_objc_provider_resources is now enabled by default. This disables ObjcProvider's fields related to resource processing. - Explicitly set https.protocols and exclude TLSv1.3. - Bazel now validates that JAVA_HOME points to a valid JDK and falls back to auto-detection by looking up the path of `javac`. - Upgrade the embedded JDK version to 11.0.2. - Added --incompatible_disable_crosstool_file (#7320) - --incompatible_disable_objc_provider_resources is now enabled by default. This disables ObjcProvider's fields related to resource processing. - --incompatible_disable_tools_defaults_package has been flipped. - For tests that do not generate a test.xml, Bazel now uses a separate action to generate one; this results in minor differences in the generated test.xml, and makes the generation more reliable overall. - incompatible_generate_javacommon_source_jar: java_common.compile now always generates a source jar, see #5824. - New incompatible flag --incompatible_disallow_struct_provider_syntax removes the ability for rule implementation functions to return struct. Such functions should return a list of providers instead. Migration tracking: #7347 This release contains contributions from many people at Google, as well as Benjamin Peterson, Ed Schouten, erenon, George Gensure, Greg Estren, Igal Tabachnik, Ittai Zeidman, Jannis Andrija Schnitzer, John Millikin, Keith Smiley, Kelly Campbell, Max Vorobev, nicolov, Robin Nabel.
scentini
added
migration-ready
P1
|
Due to a bug discovered in incompatible_disable_legacy_crosstool_fields, we are postponing the migration window to 0.24, and the breaking release will be 0.25. Apologies for the inconvenience. |
bazel-io
pushed a commit
that referenced
this issue
Mar 21, 2019
Before this cl, AndroidNdkRepositoryFunction generated CROSSTOOL file that configured the C++ toolchain for ndk. This cl changes this function to generate a Starlark rule providing CcToolchainConfigInfo, which is the "new" way of configuring C++ toolchains. This change should not be observable by ndk users. As a result, generated ndk toolchain is forward compatible with incompatible changes: * #7008 * #6861 * #7320 * #7075 RELNOTES: Android NDK C++ toolchain is now configured in Starlark. This should be a backwards compatible change, but in case of bugs blame unknown commit. PiperOrigin-RevId: 239565213
bazel-io
pushed a commit
that referenced
this issue
May 1, 2019
Baseline: 0366246 Cherry picks: + 3f7f255: Windows: fix native test wrapper's arg. escaping + afeb8d0: Flip --incompatible_windows_escape_jvm_flags + 4299b65: Sort DirectoryNode children to ensure validity. + 231270c: Conditionally use deprecated signature for initWithContentsOfURL + 75a3a53: Add http_archive entries for testing with various JDK versions. + 4a6354a: Now that ubuntu1804 uses JDK 11, remove explicit ubuntu1804_java11 tests. + ae102fb: Fix wrong name of ubuntu1804_javabase9 task. + 0020a97: Remove @executable_path/Frameworks from rpaths + 130f86d: Download stderr/stdout to a temporary FileOutErr Incompatible changes: - (Starlark rules) The legacy "py" provider can no longer be passed to or produced by native Python rules; use [PyInfo](https://docs.bazel.build/versions/master/skylark/lib/PyIn fo.html) instead. See [#7298](#7298) for more information. - (Python rules) The `default_python_version` attribute of the `py_binary` and `py_test` rules has been renamed to `python_version`. Also, the `--force_python` flag has been renamed to `--python_version`. See [#7308](#7308) for more information. - (Python rules) The python version now changes to whatever version is specified in a `py_binary` or `py_test`'s `python_version` attribute, instead of being forced to the value set by a command line flag. You can temporarily revert this change with `--incompatible_allow_python_version_transitions=false`. See [#7307](#7307) for more information. - --incompatible_disable_third_party_license_checking` is enabled by default - Introduced --incompatible_use_python_toolchains, which supersedes --python_top/--python_path. See #7899 and #7375 for more information. - Python 3 is now the default Python version (for `py_binary` and `py_test` targets that don't specify the `python_version` attribute). Targets that are built for Python 3 will no longer have their output put in a separate `-py3` directory; instead there is now a separate `-py2` directory for Python 2 targets. See #7359 and #7593 for more information. - objc_library resource attributes are now disabled by default. Please migrate them to data instead. See #7594 for more info. - Flip --incompatible_windows_escape_jvm_flags to true. See #7486 New features: - genrules now support a $(RULEDIR) variable that resolves to the directory where the outputs of the rule are put. - Added --incompatible_windows_native_test_wrapper flag: enables using the Bash-less test wrapper on Windows. (No-op on other platforms.) Important changes: - incompatible_use_jdk11_as_host_javabase: makes JDK 11 the default --host_javabase for remote jdk (#7219) - Makes genquery somepath output deterministic. - Tristate attributes of native rules now reject True/False (use 1/0) - Rollback of "Tristate attributes of native rules now reject True/False (use 1/0)" - Tristate attributes of native rules now reject True/False (use 1/0) - Added -incompatible_do_not_split_linking_cmdline flag. See #7670 - Tristate attributes of native rules now temporarily accept True/False again - `--incompatible_disable_legacy_crosstool_fields` has been flipped (#6861) `--incompatible_disable_expand_if_all_available_in_flag_set` has been flipped (#7008) - `--incompatible_disable_legacy_crosstool_fields` has been flipped (#6861) `--incompatible_disable_expand_if_all_available_in_flag_set... RELNOTES: None. - --incompatible_no_transitive_loads is enabled by default. - Makes TreeArtifact deterministic. - --incompatible_no_transitive_loads is enabled by default. - Android NDK C++ toolchain is now configured in Starlark. This should be a backwards compatible change, but in case of bugs blame unknown commit. - `--incompatible_disable_legacy_crosstool_fields` has been flipped (#6861) `--incompatible_disable_expand_if_all_available_in_flag_set` has been flipped (#7008) - --incompatible_no_transitive_loads is enabled by default. - --incompatible_bzl_disallow_load_after_statement is enabled - Added `--incompatible_require_ctx_in_configure_features`, see #7793 for details. - Flag --incompatible_merge_genfiles_directory is flipped. This removes the directory `bazel-genfiles` in favor of `bazel-bin`. - previously deprecated flag --experimental_remote_spawn_cache was removed - `--incompatible_disallow_load_labels_to_cross_package_boundaries` is enabled by default - Fix an issue where the Android resource processor did not surface errors from aapt2 compile and link actions. - --incompatible_no_attr_license is enabled by default - `--incompatible_disable_crosstool_file` has been flipped (#7320) - A new flag `--incompatible_string_join_requires_strings` is introduced. The sequence argument of `string.join` must contain only string elements. - --incompatible_symlinked_sandbox_expands_tree_artifacts_in_runfile s_tree has been flipped - Incompatible flag `--incompatible_disable_legacy_cc_provider` has been flipped (see #7036 for details). - Don't drop the analysis cache when the same --define flag is set multiple times and the last value is the same (e.g. if the current invocation was run with "--define foo=bar" and the previous one was run with "--define foo=baz --define foo=bar"). - The --incompatible_disable_genrule_cc_toolchain_dependency flag has been flipped (see #6867 for details). - Incompatible change `--incompatible_remove_cpu_and_compiler_attributes_from_cc_toolcha in` has been flipped (see #7075 for details). - --noexperimental_java_coverage is a no-op flag. - --experimental_java_coverage/--incompatible_java_coverage flag was removed. See #7425. - incompatible_use_toolchain_providers_in_java_common: pass JavaToolchainInfo and JavaRuntimeInfo providers to java_common APIs instead of configured targets (#7186.) - --incompatible_remote_symlinks has been flipped. The remote caching and execution protocol will now represent symlinks in outputs as such. See #7917 for more details. - Bazel is now ~20MiB smaller, from unbundling the Android rules' runtime dependencies. This release contains contributions from many people at Google, as well as Andreas Herrmann, Andrew Suffield, Andy Scott, Benjamin Peterson, Ed Baunton, George Gensure, Ian McGinnis, Ity Kaul, Jingwen Chen, John Millikin, Keith Smiley, Marwan Tammam, Mike Fourie, Oscar Bonilla, perwestling, petros, Robert Sayre, Ryan Beasley, silvergasp, Stanimir Mladenov, Travis Cline, Vladimir Chebotarev, ??.
dkelmer
pushed a commit
that referenced
this issue
May 6, 2019
Baseline: 0366246 Cherry picks: + 3f7f255: Windows: fix native test wrapper's arg. escaping + afeb8d0: Flip --incompatible_windows_escape_jvm_flags + 4299b65: Sort DirectoryNode children to ensure validity. + 231270c: Conditionally use deprecated signature for initWithContentsOfURL + 75a3a53: Add http_archive entries for testing with various JDK versions. + 4a6354a: Now that ubuntu1804 uses JDK 11, remove explicit ubuntu1804_java11 tests. + ae102fb: Fix wrong name of ubuntu1804_javabase9 task. + 0020a97: Remove @executable_path/Frameworks from rpaths + 130f86d: Download stderr/stdout to a temporary FileOutErr Incompatible changes: - (Starlark rules) The legacy "py" provider can no longer be passed to or produced by native Python rules; use [PyInfo](https://docs.bazel.build/versions/master/skylark/lib/PyIn fo.html) instead. See [#7298](#7298) for more information. - (Python rules) The `default_python_version` attribute of the `py_binary` and `py_test` rules has been renamed to `python_version`. Also, the `--force_python` flag has been renamed to `--python_version`. See [#7308](#7308) for more information. - (Python rules) The python version now changes to whatever version is specified in a `py_binary` or `py_test`'s `python_version` attribute, instead of being forced to the value set by a command line flag. You can temporarily revert this change with `--incompatible_allow_python_version_transitions=false`. See [#7307](#7307) for more information. - --incompatible_disable_third_party_license_checking` is enabled by default - Introduced --incompatible_use_python_toolchains, which supersedes --python_top/--python_path. See #7899 and #7375 for more information. - Python 3 is now the default Python version (for `py_binary` and `py_test` targets that don't specify the `python_version` attribute). Targets that are built for Python 3 will no longer have their output put in a separate `-py3` directory; instead there is now a separate `-py2` directory for Python 2 targets. See #7359 and #7593 for more information. - objc_library resource attributes are now disabled by default. Please migrate them to data instead. See #7594 for more info. - Flip --incompatible_windows_escape_jvm_flags to true. See #7486 New features: - genrules now support a $(RULEDIR) variable that resolves to the directory where the outputs of the rule are put. - Added --incompatible_windows_native_test_wrapper flag: enables using the Bash-less test wrapper on Windows. (No-op on other platforms.) Important changes: - incompatible_use_jdk11_as_host_javabase: makes JDK 11 the default --host_javabase for remote jdk (#7219) - Makes genquery somepath output deterministic. - Tristate attributes of native rules now reject True/False (use 1/0) - Rollback of "Tristate attributes of native rules now reject True/False (use 1/0)" - Tristate attributes of native rules now reject True/False (use 1/0) - Added -incompatible_do_not_split_linking_cmdline flag. See #7670 - Tristate attributes of native rules now temporarily accept True/False again - `--incompatible_disable_legacy_crosstool_fields` has been flipped (#6861) `--incompatible_disable_expand_if_all_available_in_flag_set` has been flipped (#7008) - `--incompatible_disable_legacy_crosstool_fields` has been flipped (#6861) `--incompatible_disable_expand_if_all_available_in_flag_set... RELNOTES: None. - --incompatible_no_transitive_loads is enabled by default. - Makes TreeArtifact deterministic. - --incompatible_no_transitive_loads is enabled by default. - Android NDK C++ toolchain is now configured in Starlark. This should be a backwards compatible change, but in case of bugs blame unknown commit. - `--incompatible_disable_legacy_crosstool_fields` has been flipped (#6861) `--incompatible_disable_expand_if_all_available_in_flag_set` has been flipped (#7008) - --incompatible_no_transitive_loads is enabled by default. - --incompatible_bzl_disallow_load_after_statement is enabled - Added `--incompatible_require_ctx_in_configure_features`, see #7793 for details. - Flag --incompatible_merge_genfiles_directory is flipped. This removes the directory `bazel-genfiles` in favor of `bazel-bin`. - previously deprecated flag --experimental_remote_spawn_cache was removed - `--incompatible_disallow_load_labels_to_cross_package_boundaries` is enabled by default - Fix an issue where the Android resource processor did not surface errors from aapt2 compile and link actions. - --incompatible_no_attr_license is enabled by default - `--incompatible_disable_crosstool_file` has been flipped (#7320) - A new flag `--incompatible_string_join_requires_strings` is introduced. The sequence argument of `string.join` must contain only string elements. - --incompatible_symlinked_sandbox_expands_tree_artifacts_in_runfile s_tree has been flipped - Incompatible flag `--incompatible_disable_legacy_cc_provider` has been flipped (see #7036 for details). - Don't drop the analysis cache when the same --define flag is set multiple times and the last value is the same (e.g. if the current invocation was run with "--define foo=bar" and the previous one was run with "--define foo=baz --define foo=bar"). - The --incompatible_disable_genrule_cc_toolchain_dependency flag has been flipped (see #6867 for details). - Incompatible change `--incompatible_remove_cpu_and_compiler_attributes_from_cc_toolcha in` has been flipped (see #7075 for details). - --noexperimental_java_coverage is a no-op flag. - --experimental_java_coverage/--incompatible_java_coverage flag was removed. See #7425. - incompatible_use_toolchain_providers_in_java_common: pass JavaToolchainInfo and JavaRuntimeInfo providers to java_common APIs instead of configured targets (#7186.) - --incompatible_remote_symlinks has been flipped. The remote caching and execution protocol will now represent symlinks in outputs as such. See #7917 for more details. - Bazel is now ~20MiB smaller, from unbundling the Android rules' runtime dependencies. This release contains contributions from many people at Google, as well as Andreas Herrmann, Andrew Suffield, Andy Scott, Benjamin Peterson, Ed Baunton, George Gensure, Ian McGinnis, Ity Kaul, Jingwen Chen, John Millikin, Keith Smiley, Marwan Tammam, Mike Fourie, Oscar Bonilla, perwestling, petros, Robert Sayre, Ryan Beasley, silvergasp, Stanimir Mladenov, Travis Cline, Vladimir Chebotarev, ??.
justkw
pushed a commit
to Intel-tensorflow/tensorflow
that referenced
this issue
May 14, 2019
This cl makes this toolchain forward compatible for Bazel's incompatible flags: * bazelbuild/bazel#7008 * bazelbuild/bazel#6861 * bazelbuild/bazel#7320 The current change creates a drop-in replacement for the proto crosstool, with the exception that: * all legacy fields are removed * templated variables are replaced by rule attributes * instead of empty paths in msvc toolchain we now use 'msvc_not_used' path (CcToolchainConfigInfo doesn't allow empty strings for paths). * introduced to_list_of_strings function so we can pass list of starlark string around The mechanical transformation makes the crosstool definition less readable than before - this will be addressed in a subsequent change. This change was tested by: 1) running cuda_configure.bzl and retrieving generated BUILD and CROSSTOOL files 2) applying this change 3) running cuda_configure.bzl and retrieving generated BUILD and cc_toolchain_config.bzl files 4) Using [cc_toolchain_compare_test](https://github.com/bazelbuild/rules_cc/blob/master/tools/migration/ctoolchain_compare.bzl#L24) rule to verify both CROSSTOOL and cc_toolchain_configs configure the C++ toolchain identically PiperOrigin-RevId: 248094053
deven-amd
pushed a commit
to ROCm/tensorflow-upstream
that referenced
this issue
May 15, 2019
This cl makes this toolchain forward compatible for Bazel's incompatible flags: * bazelbuild/bazel#7008 * bazelbuild/bazel#6861 * bazelbuild/bazel#7320 The current change creates a drop-in replacement for the proto crosstool, with the exception that: * all legacy fields are removed * templated variables are replaced by rule attributes * instead of empty paths in msvc toolchain we now use 'msvc_not_used' path (CcToolchainConfigInfo doesn't allow empty strings for paths). * introduced to_list_of_strings function so we can pass list of starlark string around The mechanical transformation makes the crosstool definition less readable than before - this will be addressed in a subsequent change. This change was tested by: 1) running cuda_configure.bzl and retrieving generated BUILD and CROSSTOOL files 2) applying this change 3) running cuda_configure.bzl and retrieving generated BUILD and cc_toolchain_config.bzl files 4) Using [cc_toolchain_compare_test](https://github.com/bazelbuild/rules_cc/blob/master/tools/migration/ctoolchain_compare.bzl#L24) rule to verify both CROSSTOOL and cc_toolchain_configs configure the C++ toolchain identically PiperOrigin-RevId: 248094053
lngart
pushed a commit
to lngart/GitSubSep
that referenced
this issue
Oct 5, 2021
This cl makes this toolchain forward compatible for Bazel's incompatible flags: * bazelbuild/bazel#7008 * bazelbuild/bazel#6861 * bazelbuild/bazel#7320 The current change creates a drop-in replacement for the proto crosstool, with the exception that: * all legacy fields are removed * templated variables are replaced by rule attributes * instead of empty paths in msvc toolchain we now use 'msvc_not_used' path (CcToolchainConfigInfo doesn't allow empty strings for paths). * introduced to_list_of_strings function so we can pass list of starlark string around The mechanical transformation makes the crosstool definition less readable than before - this will be addressed in a subsequent change. This change was tested by: 1) running cuda_configure.bzl and retrieving generated BUILD and CROSSTOOL files 2) applying this change 3) running cuda_configure.bzl and retrieving generated BUILD and cc_toolchain_config.bzl files 4) Using [cc_toolchain_compare_test](https://github.com/bazelbuild/rules_cc/blob/master/tools/migration/ctoolchain_compare.bzl#L24) rule to verify both CROSSTOOL and cc_toolchain_configs configure the C++ toolchain identically PiperOrigin-RevId: 248094053
luca-digrazia
pushed a commit
to luca-digrazia/DatasetCommitsDiffSearch
that referenced
this issue
Sep 4, 2022
Fixes #7320
RELNOTES: `--incompatible_disable_crosstool_file` has been flipped (bazelbuild/bazel#7320)
PiperOrigin-RevId: 240756422
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Flag:
--incompatible_disable_crosstool_fileAvailable since: 0.23 (February 2019 release)
Will be flipped in: 0.24 (March 2019 release)
Motivation
The motivation for this change is described here: design doc
#5380 tracks the effort of rewriting CROSSTOOL files in Starlark.
Migration
cc_toolchains should have one extra attribute -toolchain_configthat points to a target that provides CcToolchainConfigInfo (by callingcc_common.create_cc_toolchain_config_info()).cc_toolchain_config_lib.bzlprovides Starlark equivalents for all structures and substructures defined incrosstool_config.proto.A migrator script that converts a CROSSTOOL file to a Starlark rule can be found under
rules_cc/blob/master/tools/migration. The script assumes that the CROSSTOOL file does not contain legacy fields (see incompatible_disable_legacy_crosstool_fields).ctoolchain_compare.bzlis a test rule that compares a CToolchain from a CROSSTOOL file and a Starlark rule.The text was updated successfully, but these errors were encountered: