Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove legacy crosstool fields #5883

Closed
hlopko opened this issue Aug 14, 2018 · 0 comments
Closed

Remove legacy crosstool fields #5883

hlopko opened this issue Aug 14, 2018 · 0 comments
Assignees
@hlopko
Labels
P1 I'll work on this now. (Assignee required) team-Rules-CPP Issues for C++ rules type: feature request

Comments

@hlopko
Copy link
Member

hlopko commented Aug 14, 2018 •
edited
Loading

Remove legacy crosstool fields

For this to happen we need to:

  1. Create a CcToolchainProvider Skylark API to replace existing ctx.fragments.cpp.compiler_options() and ctx.fragments.cpp.linker_options() etc.
    Done in Implement Skylark API for C++ toolchain/feature configuration #4571
  2. Prepare migration tooling (elaborated [here]).(https://docs.google.com/document/d/1uv4c1zag6KvdI31qdx8C6jiTognXPQrxgsUpVefm9fM/edit#).
  3. Add incompatible flags to help Bazel users migrate.
  4. Migrate all crosstools to features.
  5. Remove legacy fields from crosstools:
    • all supports_* fields
    • static_runtimes_filegroup
    • dynamic_runtimes_filegroup
    • compiler_flag
    • optional_compiler_flag
    • cxx_flag
    • optional_cxx_flag
    • unfiltered_cxx_flag
    • optional_unfiltered_cxx_flag
    • linker_flag
    • optional_linker_flag
    • dynamic_library_linker_flag
    • optional_dynamic_library_linker_flag
    • test_only_linker_flag
    • objcopy_embed_flag
    • ld_embed_flag
    • ar_flag
    • ar_thin_archives_flag
    • gcc_plugin_compiler_flag
    • compilation_mode_flags
    • lipo_mode_flags
    • linking_mode_flags
    • gcc_plugin_header_directory
    • mao_plugin_header_directory
    • tool_path
@hlopko hlopko added type: feature request P1 I'll work on this now. (Assignee required) category: rules > C++ labels Aug 14, 2018
@hlopko hlopko self-assigned this Aug 14, 2018
@hlopko hlopko added team-Rules-CPP Issues for C++ rules and removed team-Rules-CPP Issues for C++ rules category: rules > C++ labels Oct 11, 2018
This was referenced Dec 7, 2018
Closed
Closed
@hlopko hlopko mentioned this issue Dec 17, 2018
Closed
bazel-io pushed a commit that referenced this issue Dec 18, 2018
@hlopko
Make cc_toolchain.(static|dynamic)_runtime_libs attributes optional
d42c2a5 
Issue for the --incompatible_disable_runtimes_filegroups incompatible flag
(which this cl is a step towards to): #6942
Tracking issue for legacy crosstool fields removal: #5883

RELNOTES: cc_toolchain.(static|dynamic)_runtime_libs attributes are now optional
PiperOrigin-RevId: 225990391
bazel-io pushed a commit that referenced this issue Dec 19, 2018
@hlopko
Add --incompatible_disable_runtimes_filegroups
2f229ad 
This change adds cc_toolchain.static_runtime_lib and
cc_toolchain.dynamic_runtime_lib attributes and an incompatible flag that
disables deprecated cc_toolchain.static_runtime_libs and
cc_toolchain.dynamic_runtime_libs.

Issue for the incompatible flag: #6942
Tracking issue for legacy crosstool fields removal: #5883

RELNOTES: Added --incompatible_disable_runtimes_filegroups
(#6942).
PiperOrigin-RevId: 226165743
bazel-io pushed a commit that referenced this issue Dec 20, 2018
@hlopko
Allow setting supports_start_end_lib crosstool field using feature
0762948 
This cl allows toolchain owners to express that toolchain supports --start-lib/--end-lib using enabled feature "supports_start_end_lib".

This cl is a step towards #5883. Also
see the rollout doc here:
https://docs.google.com/document/d/1uv4c1zag6KvdI31qdx8C6jiTognXPQrxgsUpVefm9fM/edit#.

Flag removing legacy behavior is #6861

RELNOTES: None.
PiperOrigin-RevId: 226292303
bazel-io pushed a commit that referenced this issue Dec 20, 2018
@hlopko
Allow setting supports_interface_shared_objects crosstool field using…
a5ba344 
… feature

This cl allows toolchain owners to express that toolchain supports creating interface shared libraries.

This cl is a step towards #5883. Also
see the rollout doc here:
https://docs.google.com/document/d/1uv4c1zag6KvdI31qdx8C6jiTognXPQrxgsUpVefm9fM/edit#.

Flag removing legacy behavior is #6861

RELNOTES: None.
PiperOrigin-RevId: 226302378
bazel-io pushed a commit that referenced this issue Dec 22, 2018
@hlopko
Allow setting supports_dynamic_linker crosstool capability using feature
8098e59 
This cl allows toolchain owners to express that toolchain supports creating dynamic libraries.

This is in theory a breaking change, for the crosstools that don't use `dynamic_library_linker_flag`, and don't specify `linking_mode_flags { mode: DYNAMIC }`, and they do specify feature { name: 'dynamic_linking_mode' }. This currently means the toolchain will generate shared libraries, but with this change it will not.

But since this only happens to toolchains that don't use legacy fields, and I don't think there are such toolchains in the wild, I'll go ahead and do this change without following the incompatible change process.

This cl is a step towards #5883. Also
see the rollout doc here:
https://docs.google.com/document/d/1uv4c1zag6KvdI31qdx8C6jiTognXPQrxgsUpVefm9fM/edit#.

Flag removing legacy behavior is #6861

RELNOTES: None.
PiperOrigin-RevId: 226631573
bazel-io pushed a commit that referenced this issue Dec 26, 2018
@hlopko
Allow setting supports_fission crosstool capability using feature
c2e8bcb 
`supports_fission` can now be expressed using 'per_object_debug_info' feature (should be enabled for it to take effect).

This cl is a step towards #5883. Also
see the rollout doc here:
https://docs.google.com/document/d/1uv4c1zag6KvdI31qdx8C6jiTognXPQrxgsUpVefm9fM/edit#.

Flag removing legacy behavior is #6861

RELNOTES: None.
PiperOrigin-RevId: 226950450
bazel-io pushed a commit that referenced this issue Dec 27, 2018
@hlopko
Allow setting supports_embedded_runtimes crosstool capability using f…
d717118 
…eature

`supports_embedded_runtimes` can now be expressed using 'static_link_cpp_runtimes' feature (should be enabled for it to take effect).

This cl allows toolchain owners to express that toolchain supports embedded runtimes in the same way as other crosstool capabilities are expressed.

This cl is a step towards #5883. Also
see the rollout doc here:
https://docs.google.com/document/d/1uv4c1zag6KvdI31qdx8C6jiTognXPQrxgsUpVefm9fM/edit#.

Flag removing legacy behavior is #6861

RELNOTES: None.
PiperOrigin-RevId: 227024509
bazel-io pushed a commit that referenced this issue Dec 28, 2018
@hlopko
Add --incompatible_disable_legacy_crosstool_fields
c1b4912 
Incompatible flag issue: #6861
Tracking issue: #5883

RELNOTES: Added --incompatible_disable_legacy_crosstool_fields. See the
migration notes at #6861.
PiperOrigin-RevId: 227104932
This was referenced Dec 28, 2018
Closed
Closed
bazel-io pushed a commit that referenced this issue Dec 28, 2018
@hlopko
Allow setting needsPic crosstool capability using feature
7019131 
`needsPic` can now be expressed using 'pic' feature (should be enabled for it to take effect).

This cl is a step towards #5883. Also
see the rollout doc here:
https://docs.google.com/document/d/1uv4c1zag6KvdI31qdx8C6jiTognXPQrxgsUpVefm9fM/edit#.

Flag removing legacy behavior is #6861

RELNOTES: None.
PiperOrigin-RevId: 227134726
bazel-io pushed a commit that referenced this issue Jan 2, 2019
@hlopko
Do not require passing legacy fields to CppActionConfigs
9a18367 
This cl is a step towards #5883. Also
see the rollout doc here:
https://docs.google.com/document/d/1uv4c1zag6KvdI31qdx8C6jiTognXPQrxgsUpVefm9fM/edit#.

Flag removing legacy behavior is #6861

RELNOTES: None.
PiperOrigin-RevId: 227491541
bazel-io pushed a commit that referenced this issue Jan 3, 2019
@scentini
Add a script for diffing command lines based on bazel aquery outputs
0ec99e7 
Progress towards #5380 and #5883

RELNOTES: None.
PiperOrigin-RevId: 227646729
bazel-io pushed a commit that referenced this issue Jan 3, 2019
@hlopko
Make cmd_line_differ be CWD friendly
fbd027c 
Progress towards #5380 and #5883

RELNOTES: None.
PiperOrigin-RevId: 227675648
bazel-io pushed a commit that referenced this issue Jan 7, 2019
@hlopko
Don't rely on supports_interface_shared_objects for toolchain inputs
a4529db 
Progress towards:
#6861
#5883

RELNOTES: None.
PiperOrigin-RevId: 228175730
bazel-io pushed a commit that referenced this issue Jan 7, 2019
@hlopko
Add cc_common.action_is_enabled
3af93c9 
This will help users who want to use CROSSTOOL with other than C++ rules, plus
it will enable users to make rules forward compatible for incompatible CROSSTOOL
changes.

Progress towards
#5883

RELNOTES: None.
PiperOrigin-RevId: 228216650
bazel-io pushed a commit to bazelbuild/rules_cc that referenced this issue Jan 11, 2019
@hlopko
Move legacy_fields_migrator to rules_cc
e1d74cb 
Needed for --incompatible_disable_legacy_crosstool_fields migration: bazelbuild/bazel#6861
Tracking issue: bazelbuild/bazel#5883

RELNOTES: None.
PiperOrigin-RevId: 225956311
bazel-io pushed a commit to bazelbuild/rules_cc that referenced this issue Jan 11, 2019
@hlopko
Allow setting supports_fission crosstool capability using feature
8062601 
`supports_fission` can now be expressed using 'per_object_debug_info' feature (should be enabled for it to take effect).

This cl is a step towards bazelbuild/bazel#5883. Also
see the rollout doc here:
https://docs.google.com/document/d/1uv4c1zag6KvdI31qdx8C6jiTognXPQrxgsUpVefm9fM/edit#.

Flag removing legacy behavior is bazelbuild/bazel#6861

RELNOTES: None.
PiperOrigin-RevId: 226950450
bazel-io pushed a commit to bazelbuild/rules_cc that referenced this issue Jan 11, 2019
@hlopko
Allow setting supports_embedded_runtimes crosstool capability using f…
c8a8211 
…eature

`supports_embedded_runtimes` can now be expressed using 'static_link_cpp_runtimes' feature (should be enabled for it to take effect).

This cl allows toolchain owners to express that toolchain supports embedded runtimes in the same way as other crosstool capabilities are expressed.

This cl is a step towards bazelbuild/bazel#5883. Also
see the rollout doc here:
https://docs.google.com/document/d/1uv4c1zag6KvdI31qdx8C6jiTognXPQrxgsUpVefm9fM/edit#.

Flag removing legacy behavior is bazelbuild/bazel#6861

RELNOTES: None.
PiperOrigin-RevId: 227024509
bazel-io pushed a commit to bazelbuild/rules_cc that referenced this issue Jan 11, 2019
@hlopko
Allow setting needsPic crosstool capability using feature
169818c 
`needsPic` can now be expressed using 'pic' feature (should be enabled for it to take effect).

This cl is a step towards bazelbuild/bazel#5883. Also
see the rollout doc here:
https://docs.google.com/document/d/1uv4c1zag6KvdI31qdx8C6jiTognXPQrxgsUpVefm9fM/edit#.

Flag removing legacy behavior is bazelbuild/bazel#6861

RELNOTES: None.
PiperOrigin-RevId: 227134726
bazel-io pushed a commit to bazelbuild/rules_cc that referenced this issue Jan 11, 2019
@hlopko
Fix edge cases of legacy crosstool migrator
b809b13 
bazelbuild/bazel#5883

RELNOTES: None.
PiperOrigin-RevId: 227688115
bazel-io pushed a commit to bazelbuild/rules_cc that referenced this issue Jan 11, 2019
@hlopko
Add --inline option to legacy_fields_migrator
30e3283 
bazelbuild/bazel#5883

RELNOTES: None.
PiperOrigin-RevId: 227827560
bazel-io pushed a commit to bazelbuild/rules_cc that referenced this issue Jan 11, 2019
@hlopko
Fix legacy_fields_migrator
f835b8b 
This cl fixes:

* clears 'supports_embedded_runtimes'
* adds user_compile_flags and sysroot feature
  * these are needed to appear before unfiltered_compile_flags

Progress towards:
bazelbuild/bazel#6861
bazelbuild/bazel#5883

RELNOTES: None.
PiperOrigin-RevId: 228299172
bazel-io pushed a commit to bazelbuild/rules_cc that referenced this issue Jan 11, 2019
@hlopko @copybara-github
Improve legacy_fields_migrator to work properly for objc crosstools
c0ac741 
bazelbuild/bazel#5883
bazelbuild/bazel#6861

RELNOTES: None.
PiperOrigin-RevId: 228839863
bazel-io pushed a commit that referenced this issue Jan 14, 2019
@hlopko
Do not disable static_link_cpp_runtimes when toolchain.supportsEmbedd…
00d2050 
…edRuntimes is not set

Before, Bazel explicitly added static_link_cpp_runtimes to disabled features, when toolchain didn't set supportsEmbeddedRuntimes. This is unnecessary (if the toolchain doesn't support embeddded runtimes, it can just not create/enable the feature), and it makes migration for #5883 harder. Let's remove it.

#5883
#6861

RELNOTES: None.
PiperOrigin-RevId: 229188252
bazel-io pushed a commit that referenced this issue Jan 15, 2019
@hlopko
Also move default_compile_flags to the top of the crosstool
ee8b357 
Currently we move legacy_compile_flags to the top of the crosstool, and the same behavior is needed for migrated crosstools in case of default_compile_flags.

#6861
#5883

RELNOTES: None.
PiperOrigin-RevId: 229339668
bazel-io pushed a commit to bazelbuild/rules_cc that referenced this issue Jan 15, 2019
@hlopko @copybara-github
Fix legacy_fields_migrator
04195ad 
Another round of fixes:

* if the toolchain contains legacy_compile_flags or legacy_link_flags, replace the feature with default_compile_flags or default_link_flags. This is to ensure the location of the flags stays intact.
* it fixes the order of compilation flags, the correct order is:
  1) compiler_flag
  2) compilation_mode_flags.compiler_flag
  3) cxx_flag
  4) compilation_mode_flags.cxx_flag
* We don't add cxx_flags to assemble and preprocess-assemble actions
* We don't add sysroot to assemble action

bazelbuild/bazel#6861
bazelbuild/bazel#5883

RELNOTES: None.
PiperOrigin-RevId: 229336027
bazel-io pushed a commit to bazelbuild/rules_cc that referenced this issue Jan 16, 2019
@hlopko @copybara-github
Rename/remove fields referencing legacy features in legacy_fields_mig…
0fd5bb9 
…rator

When renaming legacy_*_flags to default_*_flags, also rename other fields such as requires.

We're intentionally not replacing the implies line, just removing it, because default_*_features are enabled by default, so they don't need to be implied (Implied field is older than enabled field, so there are uses of it where enabled would work just fine. The only semantic difference is that implied features cannot be disabled, whereas enabled can. But since the standard style of writing crosstools seems to prefer enabled, I'm doing the same here.)

bazelbuild/bazel#6861
bazelbuild/bazel#5883

RELNOTES: None.
PiperOrigin-RevId: 229518029
bazel-io pushed a commit to bazelbuild/rules_cc that referenced this issue Jan 17, 2019
@hlopko @copybara-github
Always put linker_flags from linking_mode_flags.DYNAMIC to nodeps-dyn…
f9cdb36 
…amic-library

This cl fixes a bug in the migrator where it didn't pass mentioned flags to c++-nodeps-dynamic-library unconditionally (it only passed them as with feature { feature: 'dynamic_linking_mode' }, which is incorrect, the feature doesn't not apply to nodeps-dynamic-library, only to transitive linking actions.

bazelbuild/bazel#6861
bazelbuild/bazel#5883

RELNOTES: None.
PiperOrigin-RevId: 229692958
katre pushed a commit to katre/bazel that referenced this issue Jan 17, 2019
@hlopko
Add --disable_legacy_crosstool_fields to host configuration
2d0e27e 
bazelbuild#6861
bazelbuild#5883

RELNOTES: None
PiperOrigin-RevId: 229770248
bazel-io pushed a commit to bazelbuild/rules_cc that referenced this issue Jan 24, 2019
@hlopko @copybara-github
Don't require supports_fission to be set in the crosstool
ddf13fe 
Having a 'per_object_debug_data' feature enabled is giving the same signal as having supports_fission enabled. This is a safe change because all crosstools that have supports_fission: true have per_object_debug_info disabled, and with the legacy crosstool fields migration we will migrate this feature to be enabled by default for these crosstools.

bazelbuild/bazel#6861
bazelbuild/bazel#5883

RELNOTES: None.
PiperOrigin-RevId: 230701029
bazel-io pushed a commit that referenced this issue Jan 24, 2019
@hlopko
Don't require supports_fission to be set in the crosstool
0be35de 
Having a 'per_object_debug_data' feature enabled is giving the same signal as having supports_fission enabled. This is a safe change because all crosstools that have supports_fission: true have per_object_debug_info disabled, and with the legacy crosstool fields migration we will migrate this feature to be enabled by default for these crosstools.

#6861
#5883

RELNOTES: None.
PiperOrigin-RevId: 230701029
weixiao-huang pushed a commit to weixiao-huang/bazel that referenced this issue Jan 31, 2019
@hlopko @weixiao-huang
Add --disable_legacy_crosstool_fields to host configuration
f626760 
bazelbuild#6861
bazelbuild#5883

RELNOTES: None
PiperOrigin-RevId: 229770248
weixiao-huang pushed a commit to weixiao-huang/bazel that referenced this issue Jan 31, 2019
@hlopko @weixiao-huang
Don't require supports_fission to be set in the crosstool
61d2332 
Having a 'per_object_debug_data' feature enabled is giving the same signal as having supports_fission enabled. This is a safe change because all crosstools that have supports_fission: true have per_object_debug_info disabled, and with the legacy crosstool fields migration we will migrate this feature to be enabled by default for these crosstools.

bazelbuild#6861
bazelbuild#5883

RELNOTES: None.
PiperOrigin-RevId: 230701029
bazel-io pushed a commit to bazelbuild/rules_cc that referenced this issue Feb 14, 2019
@hlopko @copybara-github
Migrate repeated expand_if_(all|none)_available into nested flag_groups
dfb180b 
Crosstool in Starlark assumes these fields as singular, not collections. This cl updates the migration script to prepare crosstool in proto for this.

bazelbuild/bazel#6861
bazelbuild/bazel#5883

RELNOTES: None.
PiperOrigin-RevId: 233041028
luca-digrazia pushed a commit to luca-digrazia/DatasetCommitsDiffSearch that referenced this issue Sep 4, 2022
Remove legacy crosstool fields
cddf393 
    Closes bazelbuild/bazel#5883.

    RELNOTES: None.
    PiperOrigin-RevId: 240978300
luca-digrazia pushed a commit to luca-digrazia/DatasetCommitsDiffSearch that referenced this issue Sep 4, 2022
Don't require supports_fission to be set in the crosstool
6411de6 
    Having a 'per_object_debug_data' feature enabled is giving the same signal as having supports_fission enabled. This is a safe change because all crosstools that have supports_fission: true have per_object_debug_info disabled, and with the legacy crosstool fields migration we will migrate this feature to be enabled by default for these crosstools.

    bazelbuild/bazel#6861
    bazelbuild/bazel#5883

    RELNOTES: None.
    PiperOrigin-RevId: 230701029
luca-digrazia pushed a commit to luca-digrazia/DatasetCommitsDiffSearch that referenced this issue Sep 4, 2022
Do not disable static_link_cpp_runtimes when toolchain.supportsEmbed…
e2169ca 
…dedRuntimes is not set

    Before, Bazel explicitly added static_link_cpp_runtimes to disabled features, when toolchain didn't set supportsEmbeddedRuntimes. This is unnecessary (if the toolchain doesn't support embeddded runtimes, it can just not create/enable the feature), and it makes migration for bazelbuild/bazel#5883 harder. Let's remove it.

    bazelbuild/bazel#5883
    bazelbuild/bazel#6861

    RELNOTES: None.
    PiperOrigin-RevId: 229188252
luca-digrazia pushed a commit to luca-digrazia/DatasetCommitsDiffSearch that referenced this issue Sep 4, 2022
Add cc_common.action_is_enabled
49ea692 
    This will help users who want to use CROSSTOOL with other than C++ rules, plus
    it will enable users to make rules forward compatible for incompatible CROSSTOOL
    changes.

    Progress towards
    bazelbuild/bazel#5883

    RELNOTES: None.
    PiperOrigin-RevId: 228216650
luca-digrazia pushed a commit to luca-digrazia/DatasetCommitsDiffSearch that referenced this issue Sep 4, 2022
Don't rely on supports_interface_shared_objects for toolchain inputs
4e88855 
    Progress towards:
    bazelbuild/bazel#6861
    bazelbuild/bazel#5883

    RELNOTES: None.
    PiperOrigin-RevId: 228175730
luca-digrazia pushed a commit to luca-digrazia/DatasetCommitsDiffSearch that referenced this issue Sep 4, 2022
Do not require passing legacy fields to CppActionConfigs
abb288f 
    This cl is a step towards bazelbuild/bazel#5883. Also
    see the rollout doc here:
    https://docs.google.com/document/d/1uv4c1zag6KvdI31qdx8C6jiTognXPQrxgsUpVefm9fM/edit#.

    Flag removing legacy behavior is bazelbuild/bazel#6861

    RELNOTES: None.
    PiperOrigin-RevId: 227491541
luca-digrazia pushed a commit to luca-digrazia/DatasetCommitsDiffSearch that referenced this issue Sep 4, 2022
Add --incompatible_disable_legacy_crosstool_fields
d392280 
    Incompatible flag issue: bazelbuild/bazel#6861
    Tracking issue: bazelbuild/bazel#5883

    RELNOTES: Added --incompatible_disable_legacy_crosstool_fields. See the
    migration notes at bazelbuild/bazel#6861.
    PiperOrigin-RevId: 227104932
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hlopko hlopko

Labels
P1 I'll work on this now. (Assignee required) team-Rules-CPP Issues for C++ rules type: feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hlopko