Update rules_perl w/ includes attr patch #2631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @mortenmj, modules you maintain (rules_perl) have been updated in this PR. Please review the changes. |
bazel-io
previously approved these changes
Aug 19, 2024
meteorcloudy
added
presubmit-auto-run
meteorcloudy
previously approved these changes
Aug 19, 2024
|
Please check the presubmit failures |
bazel-io
dismissed stale reviews from mortenmj, meteorcloudy, and themself
Require module maintainers' approval for newly pushed changes.
Wyverald
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is latest rules_perl plus
includesattr to automate$PERL5LIBbazel-contrib/rules_perl#62PATH_PREFIX=./instead of failing to bazel run a program with a perl_binary data dep bazel-contrib/rules_perl#65Obviously it would be nice to get a review / merge this upstream. If that still happens we can add a new (0.2.4 ?) release without patches in the BCR.
The patch enables external rules_perl Bazel repos to work under Bzlmod. This is needed for https://github.com/lalten/rules_cpan to work out of the box
needs the
unstable source urllabel