Add Lcov

[lalten]

Add https://github.com/linux-test-project/lcov

[bazel-io]

Hello @mortenmj, modules you maintain (rules_perl) have been updated in this PR. Please review the changes.

[bazel-io]

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (lcov, rules_cpan) have been updated in this PR. Please review the changes.

[bazel-io]

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (lcov) have been updated in this PR. Please review the changes.

[lalten]

That presubmit failure is interesting... do we not keep permission bits when copying the overlay?

(09:18:45) ERROR: /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/0a46b5129a453049e136d92bfc68492c/external/lcov~/BUILD:34:8: Symlinking @@lcov~//:integration_test failed: failed to create symbolic link 'bazel-out/k8-fastbuild/bin/external/lcov~/integration_test': file 'external/lcov~/integration_test.sh' is not executable

❯ stat -c %a modules/lcov/2.1/overlay/integration_test.sh
775

[meteorcloudy]

Hmm, those files are essentially fetched by
https://cs.opensource.google/bazel/bazel/+/master:tools/build_defs/repo/utils.bzl;l=106-114, which doesn't set the executable bit. I don't think we can even get this information at this point? /cc @fzakaria @Wyverald

[lalten]

Generating the .sh with genrule(..., executable=True) now.
I now wonder if it would also have worked to keep the overlay file but then patch the permission bits with a patch file?

[meteorcloudy]

I now wonder if it would also have worked to keep the overlay file but then patch the permission bits with a patch file?

Yes, I think that's possible:
https://cs.opensource.google/bazel/bazel/+/master:src/main/java/com/google/devtools/build/lib/bazel/repository/PatchUtil.java;l=459-468

[lalten]

@meteorcloudy happy about another review. the source repo is added and this PR doesn't have the issue with the missing executable bit in the overlay anymore as it uses a genrule now

[meteorcloudy]

Thanks!