Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract dev deps to function and add in Bzlmod via WORKSPACE.bzlmod #66

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

lalten
Copy link
Contributor

@lalten lalten commented Aug 19, 2024

@fcgi and @genhtml weren't pulled in correctly for testing under Bzlmod

@lalten lalten requested a review from skeletonkey as a code owner August 19, 2024 19:13
Wyverald pushed a commit to bazelbuild/bazel-central-registry that referenced this pull request Aug 19, 2024
This is latest rules_perl plus
* bazel-contrib/rules_perl#62
* bazel-contrib/rules_perl#65
* bazel-contrib/rules_perl#66

Obviously it would be nice to get a review / merge this upstream. If
that still happens we can add a new (0.2.4 ?) release without patches in
the BCR.

The patch enables external rules_perl Bazel repos to work under Bzlmod.
This is needed for https://github.com/lalten/rules_cpan to work out of
the box

needs the `unstable source url` label
@skeletonkey skeletonkey merged commit 62294c2 into bazel-contrib:main Sep 6, 2024
2 checks passed
@lalten lalten deleted the bzlmod-dev-deps branch September 6, 2024 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants