Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent load() locations #1068

Closed
alexeagle opened this issue Aug 29, 2019 · 3 comments · Fixed by #1299
Closed

Consistent load() locations #1068

alexeagle opened this issue Aug 29, 2019 · 3 comments · Fixed by #1299
Labels
cleanup Tech debt, resolving it improves our own velocity

Comments

@alexeagle
Copy link
Collaborator

We should use index.bzl as the public API for all packages
@alexeagle alexeagle added this to the 1.0 milestone Aug 29, 2019
@alexeagle alexeagle added the cleanup Tech debt, resolving it improves our own velocity label Sep 11, 2019
@alexeagle
Copy link
Collaborator Author

This is related to Bazel having loading phase visibility for starlark load() statements someday - we don't want to leak private API

alexeagle added a commit to alexeagle/rules_nodejs that referenced this issue Sep 21, 2019
@alexeagle
refactor: add index.bzl
ce3aed8 
The build_bazel_rules_nodejs workspace is the last one using defs.bzl

see bazel-contrib#1068
alexeagle added a commit to alexeagle/rules_nodejs that referenced this issue Sep 21, 2019
@alexeagle
refactor: add index.bzl
342aa62 
The build_bazel_rules_nodejs workspace is the last one using defs.bzl

see bazel-contrib#1068
alexeagle added a commit that referenced this issue Sep 23, 2019
@alexeagle
refactor: add index.bzl
7e3e6be 
The build_bazel_rules_nodejs workspace is the last one using defs.bzl

see #1068
Toxicable pushed a commit to Toxicable/rules_nodejs that referenced this issue Oct 12, 2019
@alexeagle
refactor: add index.bzl
f16a151 
The build_bazel_rules_nodejs workspace is the last one using defs.bzl

see bazel-contrib#1068
@alexeagle
Copy link
Collaborator Author

almost done, just sent g3 cl/276494247 to update last places in rules_typescript that still reference defs.bzl

alexeagle added a commit to alexeagle/rules_nodejs that referenced this issue Oct 24, 2019
@alexeagle
chore: make defs.bzl error
63c261c 
BREAKING CHANGE:
Users must now switch to loading from index.bzl

Fixes bazel-contrib#1068
alexeagle added a commit to alexeagle/rules_nodejs that referenced this issue Oct 24, 2019
@alexeagle
chore: make defs.bzl error
3d649ee 
BREAKING CHANGE:
Users must now switch to loading from index.bzl

Fixes bazel-contrib#1068
@alexeagle alexeagle mentioned this issue Oct 24, 2019
Merged
alexeagle added a commit to alexeagle/rules_nodejs that referenced this issue Oct 24, 2019
@alexeagle
chore: make defs.bzl error
a6998bb 
BREAKING CHANGE:
Users must now switch to loading from index.bzl

Fixes bazel-contrib#1068
alexeagle added a commit to alexeagle/rules_nodejs that referenced this issue Dec 5, 2019
@alexeagle
chore: make defs.bzl error
cfefeac 
BREAKING CHANGE:
Users must now switch to loading from index.bzl

Fixes bazel-contrib#1068
@alexeagle
Copy link
Collaborator Author

We didn't fix up rules_docker in time, and it's too late to make this kind of breaking change for 1.0.
We didn't even warn users this was coming.
Also you can make the argument that the built-in package doesn't come from npm so the idiom of index.bzl doesn't apply as obviously.
This should go into a 2.0 RC

@alexeagle alexeagle removed this from the 1.0 milestone Dec 5, 2019
alexeagle added a commit to alexeagle/rules_nodejs that referenced this issue Dec 5, 2019
@alexeagle
chore: make defs.bzl error
8ad95ef 
BREAKING CHANGE:
Users must now switch to loading from index.bzl

Fixes bazel-contrib#1068
alexeagle added a commit to alexeagle/rules_nodejs that referenced this issue Dec 17, 2019
@alexeagle
chore: make defs.bzl error
4ce038a 
BREAKING CHANGE:
Users must now switch to loading from index.bzl

Fixes bazel-contrib#1068
alexeagle added a commit to alexeagle/rules_nodejs that referenced this issue Dec 17, 2019
@alexeagle
chore: make defs.bzl error
ff7ea32 
BREAKING CHANGE:
Users must now switch to loading from index.bzl

Fixes bazel-contrib#1068
alexeagle added a commit to alexeagle/rules_nodejs that referenced this issue Dec 17, 2019
@alexeagle
chore: make defs.bzl error
871be54 
BREAKING CHANGE:
Users must now switch to loading from index.bzl

Fixes bazel-contrib#1068
alexeagle added a commit that referenced this issue Dec 18, 2019
@alexeagle
chore: make defs.bzl error
3339d46 
BREAKING CHANGE:
Users must now switch to loading from index.bzl

Fixes #1068
alexeagle added a commit that referenced this issue Dec 18, 2019
@alexeagle
chore: make defs.bzl error
0283e6a 
BREAKING CHANGE:
Users must now switch to loading from index.bzl

Fixes #1068
@mattem mattem mentioned this issue Jul 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup Tech debt, resolving it improves our own velocity
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: make defs.bzl error alexeagle/rules_nodejs
1 participant
@alexeagle