Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove deprecated defs.bzl #2046

Merged
merged 1 commit into from
Jul 16, 2020

Conversation

mattem
Copy link
Collaborator

@mattem mattem commented Jul 16, 2020

Remove defs.bzl, as it's been deprecated for a while and all exported loads already throw errors.
Perhaps remind users as part of the 2.0.0 migration instructions.

relates to #1068

@mattem mattem added the cleanup Tech debt, resolving it improves our own velocity label Jul 16, 2020
Copy link
Collaborator

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah just made the cutoff for 2.0 :)

@alexeagle alexeagle merged commit 89e0475 into bazel-contrib:master Jul 16, 2020
@mattem mattem deleted the refactor/remove-defs branch July 17, 2020 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes cleanup Tech debt, resolving it improves our own velocity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants