chore: make defs.bzl error #1299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it's pretty annoying to land this right now. Should probably wait for rules_sass and rules_docker to accept my PRs and do a release so the patches aren't going to be required for all our users? OR maybe change this to just warn instead of error? |
alexeagle
force-pushed
the
rm_defs
branch
2 times, most recently
from
4ce038a to
ff7ea32
Compare
BREAKING CHANGE: Users must now switch to loading from index.bzl Fixes bazel-contrib#1068
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
Users must now switch to loading from index.bzl
Fixes #1068