Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename IPoolVersion --> IFactoryCreatedPoolVersion. #2045

Merged
merged 1 commit into from
Nov 23, 2022
Merged

Rename IPoolVersion --> IFactoryCreatedPoolVersion. #2045

merged 1 commit into from
Nov 23, 2022

Conversation

jubeira
Copy link
Contributor

@jubeira jubeira commented Nov 23, 2022

Description

Interface rename and changelog update.

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Dependency changes
  • Code refactor / cleanup
  • Documentation or wording changes
  • Other

Checklist:

  • The diff is legible and has no extraneous changes
  • Complex code has been commented, including external interfaces
  • Tests are included for all code paths
  • The base branch is either master, or there's a description of how to merge

Issue Resolution

N/A

@jubeira jubeira marked this pull request as ready for review November 23, 2022 13:08
@jubeira jubeira requested a review from nventuro November 23, 2022 13:08
@nventuro nventuro merged commit 9f79fc1 into master Nov 23, 2022
@nventuro nventuro deleted the version-changelogs branch November 23, 2022 13:21
TomAFrench added a commit that referenced this pull request Nov 25, 2022
@TomAFrench
Merge branch 'master' into deprecate-managed
000c2b3 
* master:
  Do new aave linear deploy (#2055)
  Deploy entrypoint (#2062)
  (Re) deployment preparation: `AuthorizerAdaptorEntrypoint` (#2060)
  chore: update deployment readmes to point to artifact files rather than abis (#2061)
  Expose deployment artifacts from deployments package rather than ABI + bytecode (#2058)
  chore: add missing action-ids (#2025)
  Remove Protocol Fee Splitter task (#2054)
  Adaptor entrypoint events (#2051)
  Verify AaveLinearPool on deployment (#2040)
  Rename IPoolVersion --> IFactoryCreatedPoolVersion. (#2045)
TomAFrench added a commit that referenced this pull request Nov 25, 2022
@TomAFrench
Merge branch 'master' into squashed-rebased-scp
67d3f1a 
* master: (269 commits)
  Do new aave linear deploy (#2055)
  Deploy entrypoint (#2062)
  (Re) deployment preparation: `AuthorizerAdaptorEntrypoint` (#2060)
  chore: update deployment readmes to point to artifact files rather than abis (#2061)
  Expose deployment artifacts from deployments package rather than ABI + bytecode (#2058)
  chore: add missing action-ids (#2025)
  Remove Protocol Fee Splitter task (#2054)
  Adaptor entrypoint events (#2051)
  Verify AaveLinearPool on deployment (#2040)
  Rename IPoolVersion --> IFactoryCreatedPoolVersion. (#2045)
  docs: remove deprecated networks from jsdoc (#2029)
  Add Version unit test. (#2038)
  Update linear build info (#2041)
  Make unnecessarily async functions sync (#2030)
  Do deployment (#2035)
  Aave linear pool versioning (#2032)
  Fix recovery readme (#2037)
  style: fix linter (#2036)
  Add tokens task (#2024)
  Create recovery helper deployment (#2033)
  ...
TomAFrench added a commit that referenced this pull request Nov 28, 2022
@TomAFrench
Merge branch 'master' into address-lookup
72acdde 
* master: (26 commits)
  Deprecate managed pool deployment (#2044)
  Add support for cash and managed to MockVault (#2064)
  chore: add .nvmrc file (#2066)
  Make `approveVault` payable (`BaseRelayerLibrary`). (#2067)
  Do new aave linear deploy (#2055)
  Deploy entrypoint (#2062)
  (Re) deployment preparation: `AuthorizerAdaptorEntrypoint` (#2060)
  chore: update deployment readmes to point to artifact files rather than abis (#2061)
  Expose deployment artifacts from deployments package rather than ABI + bytecode (#2058)
  chore: add missing action-ids (#2025)
  Remove Protocol Fee Splitter task (#2054)
  Adaptor entrypoint events (#2051)
  Verify AaveLinearPool on deployment (#2040)
  Rename IPoolVersion --> IFactoryCreatedPoolVersion. (#2045)
  docs: remove deprecated networks from jsdoc (#2029)
  Add Version unit test. (#2038)
  Update linear build info (#2041)
  Make unnecessarily async functions sync (#2030)
  Do deployment (#2035)
  Aave linear pool versioning (#2032)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nventuro nventuro nventuro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jubeira @nventuro