Make approveVault payable
#2067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAFrench
approved these changes
Nov 25, 2022
TomAFrench
added a commit
that referenced
this pull request
Nov 28, 2022
* master: (26 commits) Deprecate managed pool deployment (#2044) Add support for cash and managed to MockVault (#2064) chore: add .nvmrc file (#2066) Make `approveVault` payable (`BaseRelayerLibrary`). (#2067) Do new aave linear deploy (#2055) Deploy entrypoint (#2062) (Re) deployment preparation: `AuthorizerAdaptorEntrypoint` (#2060) chore: update deployment readmes to point to artifact files rather than abis (#2061) Expose deployment artifacts from deployments package rather than ABI + bytecode (#2058) chore: add missing action-ids (#2025) Remove Protocol Fee Splitter task (#2054) Adaptor entrypoint events (#2051) Verify AaveLinearPool on deployment (#2040) Rename IPoolVersion --> IFactoryCreatedPoolVersion. (#2045) docs: remove deprecated networks from jsdoc (#2029) Add Version unit test. (#2038) Update linear build info (#2041) Make unnecessarily async functions sync (#2030) Do deployment (#2035) Aave linear pool versioning (#2032) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes
approveVaultpayable inBaseRelayerLibrary.I've inspected the remaining public / external non-view functions in
BatchRelayerLibraryand they are all payable.Since we don't have slither yet, we could add tests that check that sending value to those functions doesn't revert, although it's not always straightforward when there are permissions involved. Feedback on this point is welcome; adding a simple test as reference.
Type of change
Checklist:
master, or there's a description of how to mergeIssue Resolution
Closes #1940.