Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create recovery helper deployment #2033

Merged
merged 3 commits into from
Nov 22, 2022
Merged

Conversation

nventuro
Copy link
Contributor

Description

This creates the PoolRecoveryHelper deployment, including fork tests.

This also shows some of the limitations of how we declare inputs, but I'm not too worried about them.

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Dependency changes
  • Code refactor / cleanup
  • Documentation or wording changes
  • Other

Checklist:

  • The diff is legible and has no extraneous changes
  • Complex code has been commented, including external interfaces
  • Tests are included for all code paths
  • The base branch is either master, or there's a description of how to merge

Copy link
Contributor

@TomAFrench TomAFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've built 767553e and get the same build-info as committed.

@nventuro nventuro merged commit 89b815d into master Nov 22, 2022
@nventuro nventuro deleted the recovery-helper-deployment branch November 22, 2022 17:33
TomAFrench added a commit that referenced this pull request Nov 25, 2022
* master: (269 commits)
  Do new aave linear deploy (#2055)
  Deploy entrypoint (#2062)
  (Re) deployment preparation: `AuthorizerAdaptorEntrypoint` (#2060)
  chore: update deployment readmes to point to artifact files rather than abis (#2061)
  Expose deployment artifacts from deployments package rather than ABI + bytecode (#2058)
  chore: add missing action-ids (#2025)
  Remove Protocol Fee Splitter task (#2054)
  Adaptor entrypoint events (#2051)
  Verify AaveLinearPool on deployment (#2040)
  Rename IPoolVersion --> IFactoryCreatedPoolVersion. (#2045)
  docs: remove deprecated networks from jsdoc (#2029)
  Add Version unit test. (#2038)
  Update linear build info (#2041)
  Make unnecessarily async functions sync (#2030)
  Do deployment (#2035)
  Aave linear pool versioning (#2032)
  Fix recovery readme (#2037)
  style: fix linter (#2036)
  Add tokens task (#2024)
  Create recovery helper deployment (#2033)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants