Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[travis] Get tested PHP version from Travis CI #1374

Closed
wants to merge 6 commits into from
Closed

[travis] Get tested PHP version from Travis CI #1374

wants to merge 6 commits into from

Conversation

peter-gribanov
Copy link
Contributor

I rewrite PR #1255

Badge for Symfony 2.8.0

Tested

Badge for Symfony 4.0.0

Tested

Attention

Testing Yii on HHVM starts, but fails and this affects the result.

Tested

And in .travis.yml #1258 badge it is not visible:

PHP

@shields-ci
Copy link

shields-ci commented Dec 15, 2017

Warnings
⚠️

This PR modified helper functions in lib/ but not accompanying tests. That's okay so long as it's refactoring existing code.

Messages
📖

✨ Thanks for your contribution to Shields, @peter-gribanov!

📖

We ❤️ our documentarians!

Generated by 🚫 dangerJS

@peter-gribanov
Copy link
Contributor Author

summary table

@peter-gribanov
Copy link
Contributor Author

Build failed because to exceeding GitHub limit.

@paulmelnikow
Copy link
Member

As I wrote here, I appreciate the work you put into this. This badge is different from the ones you added in #1258 or #1372. However this makes a lot of requests so it's many times more expensive, and in my estimation the slight difference in the result isn't worth all the extra overhead. If there is demand for this badge from a lot of other people I'm open to reconsidering. I'm also open to adding Composer if you'd like.

@paulmelnikow paulmelnikow added the service-badge New or updated service badge label Dec 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service-badge New or updated service badge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants