Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Danger: badge examples are not lib/ + wordsmith #1381

Merged
merged 2 commits into from
Dec 21, 2017

Conversation

paulmelnikow
Copy link
Member

Avoid issuing this warning:

This PR modified helper functions in lib/ but not accompanying tests. That's okay so long as it's refactoring existing code.

When only the badge examples have been edited.

@shields-ci
Copy link

shields-ci commented Dec 20, 2017

Messages
📖

✨ Thanks for your contribution to Shields, @paulmelnikow!

Generated by 🚫 dangerJS

@paulmelnikow paulmelnikow added the developer-experience Dev tooling, test framework, and CI label Dec 20, 2017
Copy link
Member

@RedSparr0w RedSparr0w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@paulmelnikow paulmelnikow merged commit 78bb20d into master Dec 21, 2017
@paulmelnikow paulmelnikow deleted the badge-examples-not-lib branch December 21, 2017 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer-experience Dev tooling, test framework, and CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants