[PHP-Eye] Get tested PHP version from PHP-Eye #1372
Conversation
Generated by 🚫 dangerJS |
peter-gribanov
changed the title
|
Build failed because to exceeding GitHub limit. |
|
Could the left side label be PHP tested to be more consistent with our style? PHP would be okay too, though may not be as clear as you'd like. |
lib/all-badge-examples.js
Outdated
| previewUri: '/php-eye/symfony/symfony.svg', | ||
| keywords: [ | ||
| 'PHP', | ||
| 'php-eye' |
There was a problem hiding this comment.
Since these keywords are included in the title, there's no need to list them.
There was a problem hiding this comment.
And why then did we mention them here?
There was a problem hiding this comment.
Perhaps it was missed. Those could be removed too. Might be good to automate this check in a unit test.
service-tests/php-eye.js
Outdated
|
|
||
| t.create('gets the package version of symfony') | ||
| .get('/symfony/symfony.json') | ||
| .expectJSON({ name: 'Tested', value: '7.1' }); |
There was a problem hiding this comment.
It's good that we have a test for the badge without a version because it ensures that code path is exercised. However I'm concerned this test will be brittle. Could you use a regex here instead of a constant '7.1'?
|
@paulmelnikow i fix all comments. |
|
Thanks! |
See failures: https://circleci.com/gh/badges/shields/26998 It looks like the bug is in the original regex: #1372.
For issue #819
In this PR i add badge for get PHP version only from PHP-Eye.
Badge for Symfony 2.8.0
Badge for Symfony 4.0.0
Attention
PHP-Eye does not return data about PHP 7.2, so it's best to check everything yourself.