-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Crash when Instead of View Trigger calls itself #245
Merged
forestkeeper
merged 7 commits into
babelfish-for-postgresql:BABEL_3_X_DEV__PG_15_X
from
amazon-aurora:BABEL-2170-crashfix
Nov 22, 2023
Merged
Fix Crash when Instead of View Trigger calls itself #245
forestkeeper
merged 7 commits into
babelfish-for-postgresql:BABEL_3_X_DEV__PG_15_X
from
amazon-aurora:BABEL-2170-crashfix
Nov 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forestkeeper
reviewed
Nov 1, 2023
deepakshi-mittal
force-pushed
the
BABEL-2170-crashfix
branch
from
November 6, 2023 09:50
f3760db
to
83b2540
Compare
forestkeeper
reviewed
Nov 7, 2023
deepakshi-mittal
force-pushed
the
BABEL-2170-crashfix
branch
from
November 9, 2023 15:46
4702ff0
to
4e1b87c
Compare
deepakshi-mittal
changed the base branch from
BABEL_3_X_DEV__PG_15_X
to
BABEL_3_4_STABLE__PG_15_5
November 22, 2023 19:57
deepakshi-mittal
changed the base branch from
BABEL_3_4_STABLE__PG_15_5
to
BABEL_3_X_DEV__PG_15_X
November 22, 2023 19:58
This change will fix crashes when an Instead of Trigger on View calls itself directly and indirectly Task: BABEL-2170 Signed-off-by: Deepakshi Mittal <[email protected]>
Task: BABEL-2170 Signed-off-by: Deepakshi Mittal <[email protected]>
Task: BABEl-2170 Signed-off-by: Deepakshi Mittal <[email protected]>
This commit will solve script listed in BABEL-4514 Task: BABEL-2170 Signed-off-by: Deepakshi Mittal <[email protected]>
Task: BABEL-2170 Signed-off-by: Deepakshi Mittal <[email protected]>
This reverts commit 4e1b87c.
deepakshi-mittal
force-pushed
the
BABEL-2170-crashfix
branch
from
November 22, 2023 20:00
0e66da6
to
ad5f18c
Compare
Task: BABEL-2170 Signed-off-by: Deepakshi Mittal <[email protected]>
forestkeeper
approved these changes
Nov 22, 2023
forestkeeper
merged commit Nov 22, 2023
063c6b7
into
babelfish-for-postgresql:BABEL_3_X_DEV__PG_15_X
2 checks passed
ahmed-shameem
pushed a commit
to amazon-aurora/postgresql_modified_for_babelfish
that referenced
this pull request
Nov 23, 2023
…stgresql#245) This change will fix crashes when an Instead of Trigger on View calls itself directly and indirectly Task: BABEL-2170
1 task
Sairakan
pushed a commit
to amazon-aurora/postgresql_modified_for_babelfish
that referenced
this pull request
Dec 21, 2023
…stgresql#245) This change will fix crashes when an Instead of Trigger on View calls itself directly and indirectly Task: BABEL-2170
Sairakan
pushed a commit
to amazon-aurora/postgresql_modified_for_babelfish
that referenced
this pull request
Dec 21, 2023
…stgresql#245) This change will fix crashes when an Instead of Trigger on View calls itself directly and indirectly Task: BABEL-2170
Sairakan
pushed a commit
to amazon-aurora/postgresql_modified_for_babelfish
that referenced
this pull request
Dec 27, 2023
…stgresql#245) This change will fix crashes when an Instead of Trigger on View calls itself directly and indirectly Task: BABEL-2170
priyansx
pushed a commit
that referenced
this pull request
Dec 29, 2023
This change will fix crashes when an Instead of Trigger on View calls itself directly and indirectly Task: BABEL-2170
roshan0708
pushed a commit
to amazon-aurora/postgresql_modified_for_babelfish
that referenced
this pull request
Oct 15, 2024
…-for-postgresql#245) This change will fix crashes when an Instead of Trigger on View calls itself directly and indirectly Task: BABEL-2170
roshan0708
pushed a commit
to amazon-aurora/postgresql_modified_for_babelfish
that referenced
this pull request
Oct 18, 2024
…-for-postgresql#245) This change will fix crashes when an Instead of Trigger on View calls itself directly and indirectly Task: BABEL-2170
roshan0708
pushed a commit
to amazon-aurora/postgresql_modified_for_babelfish
that referenced
this pull request
Oct 18, 2024
…-for-postgresql#245) This change will fix crashes when an Instead of Trigger on View calls itself directly and indirectly Task: BABEL-2170
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change will fix crashes when an
Instead of Trigger on View calls itself directly
Also fix crash IO view trigger inserted is used with join (BABEL-4514)
Task: BABEL-2170
Issues Resolved
BABEL-2170
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the PostgreSQL license, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.