Revert "Fix crash for indirect recursion"

This reverts commit 4e1b87c.
babelfish-for-postgresql · Nov 22, 2023 · ad5f18c · ad5f18c
1 parent 41efcba
commit ad5f18c
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 32 deletions.
diff --git a/src/backend/commands/trigger.c b/src/backend/commands/trigger.c
@@ -5446,29 +5446,6 @@ isTsqlInsteadofTriggerExecution(EState *estate, ResultRelInfo *relinfo, TriggerE
 	return false;
 }
 
-void checkRecursiveTriggerDepth(ResultRelInfo *relinfo)
-{
-	if (triggerOids && relinfo->ri_TrigDesc)
-	{
-		TriggerDesc *trigdesc;
-		int i;
-		trigdesc = relinfo->ri_TrigDesc;
-		for (i = 0; i < trigdesc->numtriggers; i++)
-		{
-			Trigger *trigger = &trigdesc->triggers[i];
-			Oid current_tgoid = trigger->tgoid;
-			Oid prev_tgoid = lfirst_oid(list_tail(triggerOids));
-			if (prev_tgoid != current_tgoid && list_member_oid(triggerOids, current_tgoid))
-			{
-				/** Indirect recursive trigger case*/
-				ereport(ERROR,
-						(errcode(ERRCODE_SYNTAX_ERROR),
-						 errmsg("Maximum stored procedure, function, trigger, or view nesting level exceeded (limit 32)")));
-			}
-		}
-	}
-}
-
 /* ----------
  * AfterTriggerBeginXact()
  *

diff --git a/src/backend/executor/nodeModifyTable.c b/src/backend/executor/nodeModifyTable.c
@@ -802,9 +802,6 @@ ExecInsert(ModifyTableContext *context,
 	if (resultRelInfo->ri_projectReturning)
 		result = ExecProcessReturning(resultRelInfo, slot, planSlot);
 
-	if (sql_dialect == SQL_DIALECT_TSQL)
-		checkRecursiveTriggerDepth(resultRelInfo);
-
 	/* INSTEAD OF ROW INSERT Triggers */
 	if (resultRelInfo->ri_TrigDesc &&
 		resultRelInfo->ri_TrigDesc->trig_insert_instead_row)
@@ -1480,8 +1477,6 @@ ExecDelete(ModifyTableContext *context,
 
 		ExecClearTuple(slot);
 	}
-	if (sql_dialect == SQL_DIALECT_TSQL)
-		checkRecursiveTriggerDepth(resultRelInfo);
 
 	if (resultRelInfo->ri_TrigDesc &&
 		resultRelInfo->ri_TrigDesc->trig_delete_instead_statement &&
@@ -2338,9 +2333,6 @@ ExecUpdate(ModifyTableContext *context, ResultRelInfo *resultRelInfo,
 	if (resultRelInfo->ri_projectReturning && sql_dialect == SQL_DIALECT_TSQL)
 		rslot = ExecProcessReturning(resultRelInfo, slot, context->planSlot);
 
-	if (sql_dialect == SQL_DIALECT_TSQL)
-		checkRecursiveTriggerDepth(resultRelInfo);
-
 	if (resultRelInfo->ri_TrigDesc &&
 		resultRelInfo->ri_TrigDesc->trig_update_instead_statement &&
 		sql_dialect == SQL_DIALECT_TSQL &&

diff --git a/src/include/commands/trigger.h b/src/include/commands/trigger.h
@@ -298,7 +298,6 @@ extern void ExecASTruncateTriggers(EState *estate,
 								   ResultRelInfo *relinfo);
 
 extern bool isTsqlInsteadofTriggerExecution(EState *estate, ResultRelInfo *relinfo, TriggerEvent event);
-extern void checkRecursiveTriggerDepth(ResultRelInfo *relinfo);
 
 extern void AfterTriggerBeginXact(void);
 extern void AfterTriggerBeginQuery(void);