Fix Crash when Instead of View Trigger calls itself #1970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forestkeeper
reviewed
Nov 1, 2023
deepakshi-mittal
force-pushed
the
BABEL-2170-crashfix
branch
from
4ab85a0 to
a25ba5b
Compare
lejaokri
reviewed
Nov 7, 2023
deepakshi-mittal
force-pushed
the
BABEL-2170-crashfix
branch
from
69d5f7b to
ce1eff3
Compare
This change will fix crashes when an Instead of Trigger on View calls itself directly and indirectly Task: BABEL-2170 Signed-off-by: Deepakshi Mittal <[email protected]>
Task: BABEL-2170 Signed-off-by: Deepakshi Mittal <[email protected]>
Task: BABEL-2170 Signed-off-by: Deepakshi Mittal <[email protected]>
This commit will solve crash script listed in BABEL-4514 When inserted table is used with join inside trigger body, Instead of Trigger on View was causing server crash Task: BABEL-2170 Signed-off-by: Deepakshi Mittal <[email protected]>
The query plan might be cached and cant rely on erroring out iin analyzer phase. Task: BABEL-2170 Signed-off-by: Deepakshi Mittal <[email protected]>
deepakshi-mittal
force-pushed
the
BABEL-2170-crashfix
branch
from
ce1eff3 to
f847083
Compare
… previously" This reverts commit ce1eff3.
Task: BABEL-2170 Signed-off-by: Deepakshi Mittal <[email protected]>
deepakshi-mittal
force-pushed
the
BABEL-2170-crashfix
branch
from
f847083 to
e2d8cf1
Compare
forestkeeper
approved these changes
Nov 22, 2023
forestkeeper
merged commit feeb336
into
babelfish-for-postgresql:BABEL_3_X_DEV
29 checks passed
1 task
Sairakan
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Dec 21, 2023
…stgresql#1970) This change will fix crashes when an Instead of Trigger on View calls itself directly and indirectly Task: BABEL-2170 Signed-off-by: Deepakshi Mittal <[email protected]>
Sairakan
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Dec 24, 2023
…stgresql#1970) This change will fix crashes when an Instead of Trigger on View calls itself directly and indirectly Task: BABEL-2170 Signed-off-by: Deepakshi Mittal <[email protected]>
Sairakan
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Dec 24, 2023
…stgresql#1970) This change will fix crashes when an Instead of Trigger on View calls itself directly and indirectly Task: BABEL-2170 Signed-off-by: Deepakshi Mittal <[email protected]>
Sairakan
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Dec 24, 2023
…stgresql#1970) This change will fix crashes when an Instead of Trigger on View calls itself directly and indirectly Task: BABEL-2170 Signed-off-by: Deepakshi Mittal <[email protected]>
Sairakan
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Dec 28, 2023
…stgresql#1970) This change will fix crashes when an Instead of Trigger on View calls itself directly and indirectly Task: BABEL-2170 Signed-off-by: Deepakshi Mittal <[email protected]>
Sairakan
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Dec 28, 2023
…stgresql#1970) This change will fix crashes when an Instead of Trigger on View calls itself directly and indirectly Task: BABEL-2170 Signed-off-by: Deepakshi Mittal <[email protected]>
priyansx
pushed a commit
that referenced
this pull request
Dec 29, 2023
This change will fix crashes when an Instead of Trigger on View calls itself directly and indirectly Task: BABEL-2170 Signed-off-by: Deepakshi Mittal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change will fix crashes when an
Instead of Trigger on View calls itself directly and indirectly
Also fix crash IO view trigger inserted is used with join (BABEL-4514)
Task: BABEL-2170
Engine PR: babelfish-for-postgresql/postgresql_modified_for_babelfish#245
Issues Resolved
BABEL-2170
Test Scenarios Covered
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.