Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs + simple generic gripper controller interface + minor bug fixes #64

Merged
merged 36 commits into from
Sep 11, 2018

Conversation

alex-mitrevski
Copy link
Member

@alex-mitrevski alex-mitrevski commented Aug 19, 2018

This pull request adds a new package mdr_gripper_controller under the mdr_manipulation metapackage; the package includes a high-level gripper controller base class that declares methods for opening and closing a gripper; robot-specific implementations can then define the methods so that they interact with a robot-specific gripper controller. The new implementation makes the pickup and place actions more robot-independent (the previous functionality for controlling the gripper in the actions was not sufficiently robot-independent). The pickup and place actions have been appropriately updated.

A few error/bug fixes are also included in the pull request:

  • The launch files in mdr_2dnav had syntax errors that have now been resolved
  • In the move_arm action, dmp.py had various frame names as hardcoded strings, which was making the script robot-dependent

Finally, I've added a Doxyfile and included documentation for the following packages:

  • mdr_hri
  • mdr_command_robot
  • mdr_sound_vocalisation
  • mdr_rosplan_interface

@argenos
Copy link
Contributor

argenos commented Aug 25, 2018

@alex-mitrevski @abhishek098 we need to fix a version for kdl and kdl_parser, since they seem to be making some issues. Do you know the exact version number?
The error in travis is this one:

Errors kdl_parser:make /kinetic/logs/kdl_parser/build.make.000.log
/opt/ros/kinetic/lib/liburdf.so: undefined reference to `rosconsole_bridge::RegisterOutputHandlerProxy::~RegisterOutputHandlerProxy()'
collect2: error: ld returned 1 exit status
make[2]: *** [/kinetic/devel/.private/kdl_parser/lib/kdl_parser/check_kdl_parser] Error 1
make[1]: *** [CMakeFiles/check_kdl_parser.dir/all] Error 2
make: *** [all] Error 2

Copy link
Contributor

@argenos argenos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest changes have fixed the previous build problems.
There is one caveat though... the current Travis build is not checking for dependencies added to the mas-domestic.rosinstall file to keep the build times low. I'll open a new issue to find a smarter way to check for those.

@argenos
Copy link
Contributor

argenos commented Sep 11, 2018

Issue #70 reflects the shortcomings of the current Travis setup.

@argenos
Copy link
Contributor

argenos commented Sep 11, 2018

@alex-mitrevski we might want to create a release, given the number of changes since we last published one.

@argenos argenos merged commit 1941af2 into kinetic Sep 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants