Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit gas to 3500 #127

Merged
merged 1 commit into from
Dec 20, 2022
Merged

Limit gas to 3500 #127

merged 1 commit into from
Dec 20, 2022

Conversation

nxqbao
Copy link
Contributor

@nxqbao nxqbao commented Dec 19, 2022 •
edited
Loading

Description

  • On RON transfer to unknown addresses, the gas forwarded is limited to 3500. This follows these recommendations: Link 1, Link 2, Link 3

Checklist

  • I have clearly commented on all the main functions following the NatSpec Format
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works

@nxqbao nxqbao changed the base branch from main to dev December 19, 2022 03:46
ducthotran2010
ducthotran2010 approved these changes Dec 20, 2022
View reviewed changes
Copy link
Collaborator

@ducthotran2010 ducthotran2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nxqbao nxqbao merged commit d724cd4 into dev Dec 20, 2022
nxqbao added a commit that referenced this pull request Jan 3, 2023
@nxqbao
v0.4.0 (#135)
80f9852 
* Limit gas to 3500 (#127) 
* Implement function emergency exit for Validators (#126) 
* [ValidatorSet] Replace error messages by custom erorrs (#129) 
* [RoninGovernanceAdmin] Expose function & store bridge operator set (#132) 
* [ValidatorSet] Add details for `StakingRewardDistributed` event (#133) 
* Impl forwarder contract (#128) 
* Support voting without signatures on the Ronin network (#130)
* [Staking] Rename for clarity between pools and active pools (#134)
@nxqbao nxqbao deleted the PSC-127-limit-gas-on-ron-transfer-to-treasury-address branch January 3, 2023 06:41
@nxqbao nxqbao mentioned this pull request Mar 9, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ducthotran2010 ducthotran2010 ducthotran2010 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nxqbao @ducthotran2010