Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ValidatorSet] Add details for StakingRewardDistributed event #133

Merged
merged 2 commits into from
Dec 28, 2022
Merged

[ValidatorSet] Add details for StakingRewardDistributed event #133

merged 2 commits into from
Dec 28, 2022

Conversation

nxqbao
Copy link
Contributor

@nxqbao nxqbao commented Dec 27, 2022

Description

Emits list of validators and their corresponding amount of reward in StakingRewardDistributed.

ABI changes

Old New
event StakingRewardDistributed(uint256 amount) event StakingRewardDistributed(uint256 totalAmount, address[] consensusAddrs, uint256[] amounts)
event StakingRewardDistributionFailed(uint256 amount) event StakingRewardDistributionFailed(uint256 totalAmount, address[] consensusAddrs, uint256[] amounts, uint256 contractBalance)

Checklist

  • I have clearly commented on all the main functions following the NatSpec Format
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works

@nxqbao nxqbao force-pushed the PSC-142-validator-set-add-details-for-staking-reward-distributed-event branch from fb0a1ab to a86cdf3 Compare December 27, 2022 11:23
@nxqbao nxqbao changed the title PSC-142-validator-set-add-details-for-staking-reward-distributed-event [ValidatorSet] Add details for StakingRewardDistributed event Dec 27, 2022
@nxqbao nxqbao merged commit 463022d into dev Dec 28, 2022
nxqbao added a commit that referenced this pull request Jan 3, 2023
@nxqbao
v0.4.0 (#135)
80f9852 
* Limit gas to 3500 (#127) 
* Implement function emergency exit for Validators (#126) 
* [ValidatorSet] Replace error messages by custom erorrs (#129) 
* [RoninGovernanceAdmin] Expose function & store bridge operator set (#132) 
* [ValidatorSet] Add details for `StakingRewardDistributed` event (#133) 
* Impl forwarder contract (#128) 
* Support voting without signatures on the Ronin network (#130)
* [Staking] Rename for clarity between pools and active pools (#134)
@nxqbao nxqbao deleted the PSC-142-validator-set-add-details-for-staking-reward-distributed-event branch January 3, 2023 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ducthotran2010 ducthotran2010 ducthotran2010 approved these changes

Assignees
No one assigned
Labels
ABI changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nxqbao @ducthotran2010