Fix addition gas in external calls #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ducthotran2010
approved these changes
Mar 9, 2023
nxqbao
added a commit
that referenced
this pull request
Mar 10, 2023
* fix contracts * add fallback test * Fix gas addition gas to be 1200 (3500 in total) * Remove gas striction between cross-contract call * remove console * revert garbage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In low-level call
<contract>.call{ value: _amount, gas: _gas }(), the actual amount of gas stipend forwarding to the external is2300 + _gas. The compiler determines this, regardless of hardfork of the chain.Since we design that the recipient will receive 3500 gas (as in #127), this PR reduces the number of 3500 in the parameter of
.callto 1200.Contract storage
No slot of storage is shuffled after this PR.
Contract changes
The table below shows the following info:
Checklist