Deprecating botocore.vendored.requests #324
Assignees
Milestone
Comments
|
Good catch @hynynen . Hopefully ADF is not affected |
sbkok
added a commit
to sbkok/aws-deployment-framework
that referenced
this issue
Feb 5, 2021
**Why?** Releases of botocore will no longer support the requests library as part of its vendored libraries. The samples/sample-expunge-vpc code was relying on this dependency indirectly. **What?** The samples/sample-expunge-vpc code included the crhelper library directly. This change will remove the dependency from being committed into this repository and install it on the fly instead. The latest update of the crhelper is removing the dependency of the botocore.vendored.requests library. So by changing this to update/install on the fly it will resolve issue awslabs#324.
|
Hi @hynynen, Thanks for raising this as an issue. I have created a fix for this and will open that as a separate PR. Best regards, Simon |
sbkok
added a commit
to sbkok/aws-deployment-framework
that referenced
this issue
Feb 12, 2021
**Features 🏗** * Adds Enterprise Support to account creation process awslabs#233, closes awslabs#232: * ADF will raise a ticket to add the account to an existing AWS support subscription when an account is created. As a prerequisite, your organization master account must already have enterprise support activated. * Adds nested deployment map support awslabs#266 and awslabs#328, closes awslabs#265: * This enables usage of sub directories within the deployment_maps folder. **Fixes 🐞** * Fixes specific role usage to be used in Build and Deploy only awslabs#295. * Corrects removing pipelines anchor in docs awslabs#279. * Fixes CI builds due to isort version mismatch awslabs#284. * Fixes error handling of generate_params intrinsic upload function awslabs#277, closes awslabs#276. * Fixes spec_inline attribute of CodeBuild in docs awslabs#289. * Fixes provider spec_inline support of CodeBuild in awslabs#293. * Fixes supported list of intrinsic upload path styles, enables usage of s3-url and s3-key-only awslabs#275, closes awslabs#299. * Fixes create deployment account concurrency failure awslabs#287, closes awslabs#280. * Fixes approval stage usage, by limiting specific role usage to Build and Deploy steps awslabs#295. * Fixes yarnpkg GPG awslabs#313, closes awslabs#325. * Removes dependency on botocore.vendored.requests awslabs#326, closes awslabs#324. **Improvements ✨** * Improves docs on providers and their properties awslabs#274. * Separates pipeline cleanup from input generation script awslabs#288. * Upgrades Python from v3.7 to v3.8 awslabs#313. * Upgrades CodeBuild image from "aws/codebuild/standard:2.0" to "aws/codebuild/standard:5.0" awslabs#313, closes awslabs#267, closes awslabs#300. * Upgrades CDK from v1.32 to v1.88 awslabs#313, closes awslabs#292.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello!
We have been receiving this warnings. How is this affected to ADF? We had advise:
Lambda function must be "refreshed" so that it pulls the latest version of cfnresponse.
"If you are using the cfn-response module for a Lambda-backed custom resource, you must modify your Lambda function resource’s Code or Runtime property and update your stack(s) in order to get the latest version of the cfn-response module which removed its dependency on botocore.requests."
Do we need to manually update ADF Lambdas somehow? Any new releases coming out before April 1st?
The text was updated successfully, but these errors were encountered: