Skip to content

Commit

Permalink
Remove dependency on botocore.vendored.requests
Browse files Browse the repository at this point in the history
**Why?**

Releases of botocore will no longer support the requests library as part
of its vendored libraries. The samples/sample-expunge-vpc code was
relying on this dependency indirectly.

**What?**

The samples/sample-expunge-vpc code included the crhelper library
directly. This change will remove the dependency from being committed
into this repository and install it on the fly instead.

The latest update of the crhelper is removing the dependency of the
botocore.vendored.requests library. So by changing this to
update/install on the fly it will resolve issue awslabs#324.
  • Loading branch information
sbkok committed Feb 5, 2021
1 parent 31f4719 commit 5fefdad
Show file tree
Hide file tree
Showing 6 changed files with 11 additions and 432 deletions.
9 changes: 9 additions & 0 deletions samples/sample-expunge-vpc/build-lambda.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
#!/usr/bin/env bash

set -e

cd src/lambda_vpc

pip install crhelper -t .

cd -
3 changes: 2 additions & 1 deletion samples/sample-expunge-vpc/buildspec.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ phases:
- python adf-build/generate_params.py
build:
commands:
- ./build-lambda.sh
- bash adf-build/helpers/package_transform.sh
artifacts:
files: "**/*"
files: "**/*"

This file was deleted.

83 changes: 0 additions & 83 deletions samples/sample-expunge-vpc/src/lambda_vpc/crhelper/log_helper.py

This file was deleted.

Loading

0 comments on commit 5fefdad

Please sign in to comment.