Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing the yarnpkg GPG public key #325

Closed
jarsto opened this issue Feb 4, 2021 · 2 comments · Fixed by #329
Closed

Missing the yarnpkg GPG public key #325

jarsto opened this issue Feb 4, 2021 · 2 comments · Fixed by #329
Assignees
@sbkok
Milestone
v3.1.0

Comments

@jarsto
Copy link

jarsto commented Feb 4, 2021

Hi there

In the file:
src/template.yml
before line 479 should be
- curl -sS https://dl.yarnpkg.com/debian/pubkey.gpg | apt-key add -

Thanks,
JS
@sbkok
Copy link
Collaborator

sbkok commented Feb 4, 2021

Hi JS,

Thanks for reporting, the issue is the expiry date of the GPG key for yarn got extended to 2021.
Since the current key in the CodeBuild image is referring to 2020, it fails to run the apt-get update command.

I'm working on a fix and testing it in my own account at the moment.
For those who are blocked by this issue: I would recommend updating the ADF CloudFormation template in the main/root account to remove the apt-get update -qq line.

Many thanks, Simon

@sbkok sbkok self-assigned this Feb 4, 2021
sbkok added a commit to sbkok/aws-deployment-framework that referenced this issue Feb 4, 2021
@sbkok
Remove apt-get update, rely on repeatable packages in the image
3b06a01 
**Why?**

The `apt-get update` could fail as it fetches the latest updates that
might break the build. Instead, we should rely on the packages that have
been installed in the CodeBuild image instead.

**What?**

Changed to rely on the latest STANDARD:5.0 container image packages.

**References**

* Fix for issue awslabs#325
@sbkok sbkok mentioned this issue Feb 4, 2021
Merged
sbkok added a commit to sbkok/aws-deployment-framework that referenced this issue Feb 4, 2021
@sbkok
Remove apt-get update, rely on repeatable packages in the image
c78ac9c 
**Why?**

The `apt-get update` could fail as it fetches the latest updates that
might break the build. Instead, we should rely on the packages that have
been installed in the CodeBuild image instead.

**What?**

Changed to rely on the latest STANDARD:5.0 container image packages.

**References**

* Fix for issue awslabs#325
@engrun
Copy link

engrun commented Feb 8, 2021 •
edited
Loading

Hit this blocker before the weekend.

Another possible workaround :
Edit the CodeBuild project, and remove the apt-get update -qq line from the buildspec directly.

@sbkok sbkok added this to the v3.1.0 milestone Feb 12, 2021
sbkok added a commit to sbkok/aws-deployment-framework that referenced this issue Feb 12, 2021
@sbkok
Release v3.1.0
b4b0983 
**Features 🏗**

* Adds Enterprise Support to account creation process awslabs#233, closes awslabs#232:
  * ADF will raise a ticket to add the account to an existing AWS support subscription when an account is created. As a prerequisite, your organization master account must already have enterprise support activated.
* Adds nested deployment map support awslabs#266 and awslabs#328, closes awslabs#265:
  * This enables usage of sub directories within the deployment_maps folder.

**Fixes 🐞**

* Fixes specific role usage to be used in Build and Deploy only awslabs#295.
* Corrects removing pipelines anchor in docs awslabs#279.
* Fixes CI builds due to isort version mismatch awslabs#284.
* Fixes error handling of generate_params intrinsic upload function awslabs#277, closes awslabs#276.
* Fixes spec_inline attribute of CodeBuild in docs awslabs#289.
* Fixes provider spec_inline support of CodeBuild in awslabs#293.
* Fixes supported list of intrinsic upload path styles, enables usage of s3-url and s3-key-only awslabs#275, closes awslabs#299.
* Fixes create deployment account concurrency failure awslabs#287, closes awslabs#280.
* Fixes approval stage usage, by limiting specific role usage to Build and Deploy steps awslabs#295.
* Fixes yarnpkg GPG awslabs#313,  closes awslabs#325.
* Removes dependency on botocore.vendored.requests awslabs#326, closes awslabs#324.

**Improvements ✨**

* Improves docs on providers and their properties awslabs#274.
* Separates pipeline cleanup from input generation script awslabs#288.
* Upgrades Python from v3.7 to v3.8 awslabs#313.
* Upgrades CodeBuild image from "aws/codebuild/standard:2.0" to "aws/codebuild/standard:5.0" awslabs#313, closes awslabs#267, closes awslabs#300.
* Upgrades CDK from v1.32 to v1.88 awslabs#313, closes awslabs#292.
@sbkok sbkok mentioned this issue Feb 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbkok sbkok

Labels
None yet
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging a pull request may close this issue.

Release v3.1.0 sbkok/aws-deployment-framework
3 participants
@engrun @sbkok @jarsto