Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Get object with checksum leak when retry happens #346

Merged
merged 17 commits into from
Sep 7, 2023
Merged

Conversation

TingDaoK
Copy link
Contributor

@TingDaoK TingDaoK commented Aug 31, 2023

  • We allocate buffers and checksum, but in case of error, we never free them.
  • The fix is just free them on either case
  • TODO: I think we can probably move the checksum stuff into the send_data so it gets clean up with request/response data and make it cleaner.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2023

Codecov Report

Merging #346 (15f8a76) into main (a0ee6a9) will decrease coverage by 0.11%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #346      +/-   ##
==========================================
- Coverage   89.63%   89.53%   -0.11%     
==========================================
  Files          17       17              
  Lines        4940     4931       -9     
==========================================
- Hits         4428     4415      -13     
- Misses        512      516       +4     
Files Changed Coverage Δ
source/s3_meta_request.c 92.60% <100.00%> (-0.60%) ⬇️
📢 Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs).

.github/workflows/ci.yml Outdated Show resolved Hide resolved
tests/mock_s3_server/mock_s3_server.py Outdated Show resolved Hide resolved
tests/mock_s3_server/mock_s3_server.py Outdated Show resolved Hide resolved
@TingDaoK TingDaoK requested a review from graebm September 1, 2023 22:58
Copy link
Contributor

@graebm graebm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to get hung up on dumb scripts 😓

tests/mock_s3_server/mock_s3_server.py Outdated Show resolved Hide resolved
tests/mock_s3_server/mock_s3_server.py Outdated Show resolved Hide resolved
tests/mock_s3_server/mock_s3_server.py Outdated Show resolved Hide resolved
@TingDaoK TingDaoK requested a review from graebm September 6, 2023 18:43
Copy link
Contributor

@graebm graebm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix & ship

tests/mock_s3_server/mock_s3_server.py Outdated Show resolved Hide resolved
tests/mock_s3_server/mock_s3_server.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants