Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aws-sdk-cpp] update to 1.11.160 and update dependencies #33708

Merged
merged 10 commits into from
Sep 14, 2023

Conversation

ConorRyan
Copy link
Contributor

Main goal for the PR is to include the fix for a memory leak: awslabs/aws-c-s3#346

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@ConorRyan ConorRyan marked this pull request as ready for review September 11, 2023 22:06
@MonicaLiu0311 MonicaLiu0311 added the category:port-update The issue is with a library, which is requesting update new revision label Sep 12, 2023
@MonicaLiu0311
Copy link
Contributor

MonicaLiu0311 commented Sep 13, 2023

aws-sdk-cpp

All features are tested successfully in the following triplet:

x86-windows
x64-windows
x64-windows-static

The usage test passed on x64-windows (header files found):

The package aws-sdk-cpp:x86-windows provides CMake targets:

    When using AWSSDK, AWSSDK_ROOT_DIR must be defined by the user.
    find_package(AWSSDK CONFIG COMPONENTS core dynamodb kinesis s3 REQUIRED)
    target_include_directories(main PRIVATE ${AWSSDK_INCLUDE_DIRS})
    target_link_libraries(main PRIVATE ${AWSSDK_LIBRARIES})

    OR

    find_package(aws-cpp-sdk-core REQUIRED)
    target_include_directories(main PRIVATE aws-cpp-sdk-core)
    target_link_libraries(main PRIVATE aws-cpp-sdk-core)

MonicaLiu0311
MonicaLiu0311 previously approved these changes Sep 13, 2023
@MonicaLiu0311 MonicaLiu0311 added the info:reviewed Pull Request changes follow basic guidelines label Sep 13, 2023
# Conflicts:
#	ports/aws-sdk-cpp/vcpkg.json
#	versions/a-/aws-sdk-cpp.json
#	versions/baseline.json
@BillyONeal BillyONeal removed the info:reviewed Pull Request changes follow basic guidelines label Sep 13, 2023
@BillyONeal BillyONeal marked this pull request as draft September 13, 2023 23:25
@BillyONeal
Copy link
Member

@ConorRyan @teo-tsirpanis Can one of you double check that I merged this change with b6aef4b correctly and re-set 'ready for review' if it looks good? Thanks!

@ConorRyan ConorRyan marked this pull request as ready for review September 14, 2023 01:52
@BillyONeal BillyONeal merged commit 2c40186 into microsoft:master Sep 14, 2023
@BillyONeal
Copy link
Member

Thanks for the updates!

@ConorRyan ConorRyan deleted the aws-1.11.160 branch September 14, 2023 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants