Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CRT submodules #529

Merged
merged 2 commits into from
Sep 22, 2023
Merged

Update CRT submodules #529

merged 2 commits into from
Sep 22, 2023

Conversation

passaro
Copy link
Contributor

@passaro passaro commented Sep 21, 2023

Description of change

Update the CRT submodules to the latest releases.

In particular, includes the following fixes to aws-c-s3:

Does this change impact existing behavior?

No.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).

@passaro passaro added the performance PRs to run benchmarks on label Sep 21, 2023
@passaro passaro temporarily deployed to PR benchmarks September 21, 2023 21:39 — with GitHub Actions Inactive
@passaro passaro temporarily deployed to PR integration tests September 21, 2023 21:39 — with GitHub Actions Inactive
@passaro passaro temporarily deployed to PR integration tests September 21, 2023 21:39 — with GitHub Actions Inactive
@passaro passaro temporarily deployed to PR integration tests September 21, 2023 21:39 — with GitHub Actions Inactive
@passaro passaro temporarily deployed to PR integration tests September 21, 2023 21:39 — with GitHub Actions Inactive
@passaro passaro marked this pull request as ready for review September 21, 2023 22:08
@passaro passaro temporarily deployed to PR benchmarks September 22, 2023 02:52 — with GitHub Actions Inactive
@passaro passaro temporarily deployed to PR benchmarks September 22, 2023 02:52 — with GitHub Actions Inactive
Copy link
Member

@jamesbornholt jamesbornholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming the benchmark failure (which I just retried) was just a blip.

@passaro passaro added this pull request to the merge queue Sep 22, 2023
Merged via the queue into awslabs:main with commit c722533 Sep 22, 2023
0 of 2 checks passed
@passaro passaro deleted the crt-update branch September 22, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance PRs to run benchmarks on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants