fixing external shingling and preprocessor #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaituo
approved these changes
Sep 26, 2021
kaituo
added a commit
to kaituo/anomaly-detection-1
that referenced
this pull request
Sep 27, 2021
Previously, I used shingleSize 1 for externally shingled ThresholdedRandomCutForest because of the double multiplication with shingle size in RCF. Now RCF has fixed the issue. This commits adds new RCF libraries from aws/random-cut-forest-by-aws#278 and passes the correct shingleSize to ThresholdedRandomCutForest. This commits adds new RCF libraries from aws/random-cut-forest-by-aws#278 and passes the correct shingleSize to ThresholdedRandomCutForest.
kaituo
added a commit
to kaituo/anomaly-detection-1
that referenced
this pull request
Sep 27, 2021
Previously, I used shingleSize 1 for externally shingled ThresholdedRandomCutForest because of the double multiplication with shingle size in RCF. Now RCF has fixed the issue. This commits adds new RCF libraries from aws/random-cut-forest-by-aws#278 and passes the correct shingleSize to ThresholdedRandomCutForest. This commits adds new RCF libraries from aws/random-cut-forest-by-aws#278 and passes the correct shingleSize to ThresholdedRandomCutForest.
kaituo
added a commit
to opensearch-project/anomaly-detection
that referenced
this pull request
Sep 27, 2021
* [1.1] Bump OpenSearch core to 1.1 in CI (#212) Signed-off-by: Tyler Ohlsen <[email protected]> * add thresholded rcf (#215) Signed-off-by: lai <[email protected]> * Integrating with ThresholdedRandomCutForest This PR contains: PRs (all approved) related to integrating ThresholdedRandomCutForest: #221 #222 #223 #224 #226 #227 #228 rebased PR: #201 #202 #216 * pass the correct shingleSize to ThresholdedRandomCutForest Previously, I used shingleSize 1 for externally shingled ThresholdedRandomCutForest because of the double multiplication with shingle size in RCF. Now RCF has fixed the issue. This commits adds new RCF libraries from aws/random-cut-forest-by-aws#278 and passes the correct shingleSize to ThresholdedRandomCutForest. This commits adds new RCF libraries from aws/random-cut-forest-by-aws#278 and passes the correct shingleSize to ThresholdedRandomCutForest. Co-authored-by: Tyler Ohlsen <[email protected]> Co-authored-by: Lai <[email protected]>
kaituo
added a commit
to kaituo/anomaly-detection-1
that referenced
this pull request
Sep 27, 2021
Previously, I used shingleSize 1 for externally shingled ThresholdedRandomCutForest because of the double multiplication with shingle size in RCF. Now RCF has fixed the issue. This commits adds new RCF libraries from aws/random-cut-forest-by-aws#278 and passes the correct shingleSize to ThresholdedRandomCutForest. This commits adds new RCF libraries from aws/random-cut-forest-by-aws#278 and passes the correct shingleSize to ThresholdedRandomCutForest.
kaituo
added a commit
to opensearch-project/anomaly-detection
that referenced
this pull request
Sep 27, 2021
* backport changes on ThresholdedRandomCutForest integration * pass the correct shingleSize to ThresholdedRandomCutForest Previously, I used shingleSize 1 for externally shingled ThresholdedRandomCutForest because of the double multiplication with shingle size in RCF. Now RCF has fixed the issue. This commits adds new RCF libraries from aws/random-cut-forest-by-aws#278 and passes the correct shingleSize to ThresholdedRandomCutForest.
kaituo
added a commit
to opensearch-project/anomaly-detection
that referenced
this pull request
Sep 27, 2021
* backport changes on ThresholdedRandomCutForest integration * pass the correct shingleSize to ThresholdedRandomCutForest Previously, I used shingleSize 1 for externally shingled ThresholdedRandomCutForest because of the double multiplication with shingle size in RCF. Now RCF has fixed the issue. This commits adds new RCF libraries from aws/random-cut-forest-by-aws#278 and passes the correct shingleSize to ThresholdedRandomCutForest.
jotok
approved these changes
Sep 30, 2021
hamersu9t
added a commit
to hamersu9t/anomaly-detection
that referenced
this pull request
Aug 10, 2024
* [1.1] Bump OpenSearch core to 1.1 in CI (#212) Signed-off-by: Tyler Ohlsen <[email protected]> * add thresholded rcf (#215) Signed-off-by: lai <[email protected]> * Integrating with ThresholdedRandomCutForest This PR contains: PRs (all approved) related to integrating ThresholdedRandomCutForest: opensearch-project/anomaly-detection#221 opensearch-project/anomaly-detection#222 opensearch-project/anomaly-detection#223 opensearch-project/anomaly-detection#224 opensearch-project/anomaly-detection#226 opensearch-project/anomaly-detection#227 opensearch-project/anomaly-detection#228 rebased PR: opensearch-project/anomaly-detection#201 opensearch-project/anomaly-detection#202 opensearch-project/anomaly-detection#216 * pass the correct shingleSize to ThresholdedRandomCutForest Previously, I used shingleSize 1 for externally shingled ThresholdedRandomCutForest because of the double multiplication with shingle size in RCF. Now RCF has fixed the issue. This commits adds new RCF libraries from aws/random-cut-forest-by-aws#278 and passes the correct shingleSize to ThresholdedRandomCutForest. This commits adds new RCF libraries from aws/random-cut-forest-by-aws#278 and passes the correct shingleSize to ThresholdedRandomCutForest. Co-authored-by: Tyler Ohlsen <[email protected]> Co-authored-by: Lai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes: fixes preprocessor to not multiple by shinglesize for external shingling
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.