Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR 238 to 1.x #240

Merged
merged 2 commits into from
Sep 27, 2021
Merged

Conversation

kaituo
Copy link
Collaborator

@kaituo kaituo commented Sep 27, 2021

Description

This PR backports #238

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Previously, I used shingleSize 1 for externally shingled ThresholdedRandomCutForest because of the double multiplication with shingle size in RCF.  Now RCF has fixed the issue. This commits adds new RCF libraries from aws/random-cut-forest-by-aws#278 and passes the correct shingleSize to ThresholdedRandomCutForest.

This commits adds new RCF libraries from aws/random-cut-forest-by-aws#278 and passes the correct shingleSize to ThresholdedRandomCutForest.
@kaituo kaituo requested a review from ylwu-amzn September 27, 2021 19:54
@codecov-commenter
Copy link

Codecov Report

Merging #240 (bd333d4) into 1.x (59ae734) will increase coverage by 0.23%.
The diff coverage is 79.43%.

Impacted file tree graph

@@             Coverage Diff              @@
##                1.x     #240      +/-   ##
============================================
+ Coverage     78.37%   78.60%   +0.23%     
+ Complexity     3750     3725      -25     
============================================
  Files           277      275       -2     
  Lines         15790    15569     -221     
  Branches       1648     1624      -24     
============================================
- Hits          12375    12238     -137     
+ Misses         2679     2625      -54     
+ Partials        736      706      -30     
Flag Coverage Δ
plugin 78.60% <79.43%> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...in/java/org/opensearch/ad/caching/CacheBuffer.java 76.42% <0.00%> (ø)
...pensearch/ad/settings/AnomalyDetectorSettings.java 100.00% <ø> (ø)
.../main/java/org/opensearch/ad/ml/CheckpointDao.java 69.55% <65.62%> (+3.26%) ⬆️
src/main/java/org/opensearch/ad/ml/RcfResult.java 92.30% <66.66%> (-3.70%) ⬇️
...n/java/org/opensearch/ad/ml/EntityColdStarter.java 81.94% <71.42%> (-1.12%) ⬇️
...c/main/java/org/opensearch/ad/ml/ModelManager.java 83.33% <76.92%> (-2.74%) ⬇️
.../java/org/opensearch/ad/caching/PriorityCache.java 69.16% <80.00%> (+0.83%) ⬆️
...rg/opensearch/ad/ml/SingleStreamModelIdMapper.java 88.88% <88.88%> (ø)
...rch/ad/transport/AnomalyResultTransportAction.java 80.00% <90.62%> (ø)
.../java/org/opensearch/ad/AnomalyDetectorPlugin.java 94.85% <100.00%> (ø)
... and 36 more

@kaituo kaituo changed the title Threshold rcf 1x Backport PR 238 to 1.x Sep 27, 2021
@kaituo kaituo merged commit d3c79f7 into opensearch-project:1.x Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants