add thresholded rcf #215
Merged
add thresholded rcf #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you create a remote branch and we can open PR to check into code there? Don't want to impact other people's testing. After we are ready, we will check into mainline and and backport to 1.1. |
|
yes, i am using the trcf remote branch. |
kaituo
reviewed
Sep 15, 2021
| if (json.has(ENTITY_TRCF)) { | ||
| trcf = toTrcf(json.getAsJsonPrimitive(ENTITY_TRCF).getAsString()); | ||
| } | ||
| // TODO: convert rcf and threshold to trcf |
There was a problem hiding this comment.
Could you put line 560~571 under the else branch? Want to make it explicit that we only expect trcf or rcf/threshold, but not both.
Signed-off-by: lai <[email protected]>
kaituo
approved these changes
Sep 16, 2021
kaituo
pushed a commit
to kaituo/anomaly-detection-1
that referenced
this pull request
Sep 23, 2021
Signed-off-by: lai <[email protected]>
kaituo
pushed a commit
to kaituo/anomaly-detection-1
that referenced
this pull request
Sep 25, 2021
Signed-off-by: lai <[email protected]>
kaituo
pushed a commit
to kaituo/anomaly-detection-1
that referenced
this pull request
Sep 25, 2021
Signed-off-by: lai <[email protected]>
kaituo
added a commit
that referenced
this pull request
Sep 27, 2021
* [1.1] Bump OpenSearch core to 1.1 in CI (#212) Signed-off-by: Tyler Ohlsen <[email protected]> * add thresholded rcf (#215) Signed-off-by: lai <[email protected]> * Integrating with ThresholdedRandomCutForest This PR contains: PRs (all approved) related to integrating ThresholdedRandomCutForest: #221 #222 #223 #224 #226 #227 #228 rebased PR: #201 #202 #216 * pass the correct shingleSize to ThresholdedRandomCutForest Previously, I used shingleSize 1 for externally shingled ThresholdedRandomCutForest because of the double multiplication with shingle size in RCF. Now RCF has fixed the issue. This commits adds new RCF libraries from aws/random-cut-forest-by-aws#278 and passes the correct shingleSize to ThresholdedRandomCutForest. This commits adds new RCF libraries from aws/random-cut-forest-by-aws#278 and passes the correct shingleSize to ThresholdedRandomCutForest. Co-authored-by: Tyler Ohlsen <[email protected]> Co-authored-by: Lai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr adds thresholded rcf to replace existing rcf and sketch-based threshold.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.