[Rocky] Update CHANGELOG and handle unsupported kernel version for Fsx Lustre Client #2474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
himani2411
changed the title
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2474 +/- ##
========================================
Coverage 76.06% 76.06%
========================================
Files 13 13
Lines 1876 1876
========================================
Hits 1427 1427
Misses 449 449
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
himani2411
force-pushed
the
wip/rocky
branch
from
38670eb to
e0a7e91
Compare
…tre Client installation for Rocky Linux 8 Update system_authentication w.r.t rhel8
himani2411
force-pushed
the
wip/rocky
branch
from
d303f5a to
9dae1c7
Compare
| # rhel8 kernel 4.18.0-425.3.1.el8 has broken kABI compat https://github.com/openzfs/zfs/issues/14724 | ||
| elsif node['cluster']['kernel_release'].include? "4.18.0-425.3.1.el8" | ||
| log "FSx for Lustre is not supported in kernel version 4.18.0-425.3.1.el8 of Rocky Linux, please update the kernel version" do | ||
| elsif version.to_f == 8.7 && (node['cluster']['kernel_release'].include?("4.18.0-425.3.1.el8") || node['cluster']['kernel_release'].include?("4.18.0-425.13.1.el8_7")) |
There was a problem hiding this comment.
Why is version.to_f == 8.7 needed? If it is needed, is the logical operators precedence correct?
There was a problem hiding this comment.
This is part of the Patch and openzfs/zfs#14724
hanwen-pcluste
approved these changes
Sep 28, 2023
hgreebe
pushed a commit
to hgreebe/aws-parallelcluster-cookbook
that referenced
this pull request
Nov 13, 2023
…tre Client installation for Rocky Linux 8 (aws#2474) Update system_authentication w.r.t rhel8 Co-authored-by: Himani Deshpande <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update CHANGELOG.md and handle unsupported kernel version for Fsx Lustre Client installation for Rocky Linux 8
Update system_authentication for rocky w.r.t RHEL8
Updates from below related PR's
Checklist
developadd the branch name as prefix in the PR title (e.g.[release-3.6]).Please review the guidelines for contributing and Pull Request Instructions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.