[POC] Add support for Rocky Linux 8 #2324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2324 +/- ##
========================================
Coverage 76.06% 76.06%
========================================
Files 13 13
Lines 1876 1876
========================================
Hits 1427 1427
Misses 449 449
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
enrico-usai
force-pushed
the
wip/rocky
branch
6 times, most recently
from
38c6650 to
6cb57a8
Compare
enrico-usai
changed the title
enrico-usai
changed the title
enrico-usai
force-pushed
the
wip/rocky
branch
9 times, most recently
from
e912b14 to
d859272
Compare
enrico-usai
force-pushed
the
wip/rocky
branch
3 times, most recently
from
61bf33e to
fdc9339
Compare
|
TODO verify if there are "redhat" conditions in the chefspec and inspec tests that must be converted to rocky. (e.g. os_type_spec is missing rocky case). |
Used the new utility `os-resources.py` to create new resources for rocky linux, starting from redhat8 resources. Manually modified: * efa -> Replaced RHEL with Rocky Linux in log messages * lustre -> Replaced RHEL with Rocky Linux in log messages * users --> Replaced ec2-user with rocky * os_type --> Replaced rhel with rocky * install_packages --> Removed postgresql packages Removed redhat_on_docker condition from: * stunnel * system_authentication * efa Signed-off-by: Enrico Usai <[email protected]>
* platform_url_component should point to the same of rhel Signed-off-by: Enrico Usai <[email protected]>
Copied from RedHat files Signed-off-by: Enrico Usai <[email protected]>
Copied from rhel8 with minor changes: * AMI name prefix took from EC2 Rocky Linux official AMI * `kernel_release` version took from an EC2 Rocky Linux instance * username `rocky` found in kitchen-ec2 driver documentation. Added Rocky Linux to kitchen tests hooks ### References * https://hub.docker.com/r/dokken/rockylinux-8 * https://github.com/test-kitchen/kitchen-ec2/tree/main/lib/kitchen/driver/aws/standard_platform Signed-off-by: Enrico Usai <[email protected]>
Signed-off-by: Enrico Usai <[email protected]>
Signed-off-by: Enrico Usai <[email protected]>
Needed by hwloc-devel blas-devel libedit-devel and glibc-static packages Signed-off-by: Enrico Usai <[email protected]>
This package conflicts by design with `coreutils-single`. `coreutils-single` cannot be removed because related to `sudo`. This change permits the install_package test to be executed on docker. Signed-off-by: Enrico Usai <[email protected]>
Define os_properties for rocky linux Signed-off-by: Enrico Usai <[email protected]>
Signed-off-by: Enrico Usai <[email protected]>
Signed-off-by: Enrico Usai <[email protected]>
Signed-off-by: Enrico Usai <[email protected]>
enrico-usai
force-pushed
the
wip/rocky
branch
from
fdc9339 to
6da2ce4
Compare
himani2411
reviewed
Sep 26, 2023
| @@ -32,6 +32,7 @@ This file is used to list changes made in each version of the AWS ParallelCluste | |||
| ------ | |||
|
|
|||
| **ENHANCEMENTS** | |||
| - Add support for Rocky Linux 8. | |||
There was a problem hiding this comment.
I am approving this PR as I will be making changes in the next PR
himani2411
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Used new utility
os-resources.pyintroduced as part of #2328 to create new resources for rocky linux, starting from redhat8 resources.Manually modified:
Removed redhat_on_docker condition from:
Relevant fixes to the code:
platform_url_componentshould point to the same of rhelTests
kernel_releaseversion took from an EC2 Rocky Linux instancerockyfound in kitchen-ec2 driver documentation.coreutils-single.coreutils-singlecannot be removed because related tosudo.References