Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rocky] Update CHANGELOG and handle unsupported kernel version for Fsx Lustre Client #2474

Merged
merged 1 commit into from
Sep 28, 2023
Merged

[Rocky] Update CHANGELOG and handle unsupported kernel version for Fsx Lustre Client #2474

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ This file is used to list changes made in each version of the AWS ParallelCluste
------

**ENHANCEMENTS**
- Add support for Rocky Linux 8.
- Install [Spack](https://spack.io) by default in cluster user's home directory.
- Add support for `Scheduling/SlurmSettings/Database/DatabaseName` parameter to render `StorageLoc` in the slurmdbd configuration generated by ParallelCluster.

Expand All @@ -33,7 +34,6 @@ This file is used to list changes made in each version of the AWS ParallelCluste
------

**ENHANCEMENTS**
- Add support for Rocky Linux 8.
- Allow configuration of static and dynamic node priorities in compute resources via the ParallelCluster configuration YAML file.
- Forward SLURM_RESUME_FILE to ParallelCluster resume program.
- Allow to override aws-parallelcluster-node package at cluster creation and update time (only on the head node during update).
Expand Down
8 changes: 5 additions & 3 deletions cookbooks/aws-parallelcluster-environment/resources/lustre/lustre_rocky8.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,15 @@

action :setup do
version = node['platform_version']
log "Installing FSx for Lustre. Platform version: #{version}, kernel version: #{node['cluster']['kernel_release']}"
if version.to_f < 8.2
log "FSx for Lustre is not supported in this Rocky Linux version #{version}, supported versions are >= 8.2" do
level :warn
end
# rhel8 kernel 4.18.0-425.3.1.el8 has broken kABI compat https://github.com/openzfs/zfs/issues/14724
elsif node['cluster']['kernel_release'].include? "4.18.0-425.3.1.el8"
log "FSx for Lustre is not supported in kernel version 4.18.0-425.3.1.el8 of Rocky Linux, please update the kernel version" do
elsif version.to_f == 8.7 && (node['cluster']['kernel_release'].include?("4.18.0-425.3.1.el8") || node['cluster']['kernel_release'].include?("4.18.0-425.13.1.el8_7"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is version.to_f == 8.7 needed? If it is needed, is the logical operators precedence correct?

Copy link
Contributor Author

@himani2411 himani2411 Sep 28, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is part of the Patch and openzfs/zfs#14724

# Rhel8.7 kernel 4.18.0-425.3.1.el8 and 4.18.0-425.13.1.el8_7 has broken kABI compat
# See https://access.redhat.com/solutions/6985596 and https://github.com/openzfs/zfs/issues/14724
log "FSx for Lustre is not supported in kernel version #{node['cluster']['kernel_release']} of Rocky Linux, please update the kernel version" do
level :warn
end
else
Expand Down
1 change: 1 addition & 0 deletions ...rallelcluster-environment/resources/system_authentication/system_authentication_rocky8.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
# authconfig is a compatibility tool, replaced by authselect
command "authselect select sssd with-mkhomedir"
sensitive true
default_env true
end
end

Expand Down
2 changes: 1 addition & 1 deletion kitchen.docker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,4 +75,4 @@ platforms:
attributes:
cluster:
base_os: rocky8
kernel_release: '4.18.0-477.10.1.el8_8.x86_64'
kernel_release: '4.18.0-477.10.1.el8_8.fake-value'
4 changes: 4 additions & 0 deletions test/environments/kitchen.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,21 +9,25 @@
'ebs_mount-vol_array/centos7' => '',
'ebs_mount-vol_array/ubuntu2004' => '',
'ebs_mount-vol_array/ubuntu2204' => '',
'ebs_mount-vol_array/rocky8' => '',
'ebs_unmount-vol_array/alinux2' => '',
'ebs_unmount-vol_array/rhel8' => '',
'ebs_unmount-vol_array/centos7' => '',
'ebs_unmount-vol_array/ubuntu2004' => '',
'ebs_unmount-vol_array/ubuntu2204' => '',
'ebs_unmount-vol_array/rocky8' => '',
'raid_mount-raid_vol_array/alinux2' => '',
'raid_mount-raid_vol_array/rhel8' => '',
'raid_mount-raid_vol_array/centos7' => '',
'raid_mount-raid_vol_array/ubuntu2004' => '',
'raid_mount-raid_vol_array/ubuntu2204' => '',
'raid_mount-raid_vol_array/rocky8' => '',
'raid_unmount-raid_vol_array/alinux2' => '',
'raid_unmount-raid_vol_array/rhel8' => '',
'raid_unmount-raid_vol_array/centos7' => '',
'raid_unmount-raid_vol_array/ubuntu2004' => '',
'raid_unmount-raid_vol_array/ubuntu2204' => '',
'raid_unmount-raid_vol_array/rocky8' => '',
'lustre_mount-fsx_fs_id_array' => ["fs-0ab11b3ade43091fe"],
'lustre_mount-fsx_dns_name_array' => ["fs-0ab11b3ade43091fe.fsx.us-west-2.amazonaws.com"],
'lustre_mount-fsx_mount_name_array' => ["qz5b7bev"],
Expand Down